From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: handle_mm_fault() calling convention cleanup.. Date: Sun, 05 Jul 2009 07:08:38 +1000 Message-ID: <1246741718.7551.22.camel@pasglop> References: <1246664107.7551.11.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: owner-linux-mm@kvack.org To: Linus Torvalds Cc: linux-arch@vger.kernel.org, Hugh Dickins , Nick Piggin , Andrew Morton , linux-mm@kvack.org, Wu Fengguang , Ingo Molnar List-Id: linux-arch.vger.kernel.org On Sat, 2009-07-04 at 09:44 -0700, Linus Torvalds wrote: > Just a tiny word of warning: right now, the conversion I did pretty much > depended on the fact that even if I missed a spot, it wouldn't actually > make any difference. If somebody used "flags" as a binary value (ie like > the old "write_access" kind of semantics), things would still all work, > because it was still a "zero-vs-nonzero" issue wrt writes. .../... Right. Oh well.. we'll see when I get to it. I have a few higher priority things on my pile at the moment. Cheers, Ben. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org ([63.228.1.57]:36717 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751438AbZGDVLe (ORCPT ); Sat, 4 Jul 2009 17:11:34 -0400 Subject: Re: handle_mm_fault() calling convention cleanup.. From: Benjamin Herrenschmidt In-Reply-To: References: <1246664107.7551.11.camel@pasglop> Content-Type: text/plain Date: Sun, 05 Jul 2009 07:08:38 +1000 Message-ID: <1246741718.7551.22.camel@pasglop> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Linus Torvalds Cc: linux-arch@vger.kernel.org, Hugh Dickins , Nick Piggin , Andrew Morton , linux-mm@kvack.org, Wu Fengguang , Ingo Molnar Message-ID: <20090704210838.JAo5geU3LeKnOBq0S8UC8OAzSNXuFIJxYf0AWUn8Nv4@z> On Sat, 2009-07-04 at 09:44 -0700, Linus Torvalds wrote: > Just a tiny word of warning: right now, the conversion I did pretty much > depended on the fact that even if I missed a spot, it wouldn't actually > make any difference. If somebody used "flags" as a binary value (ie like > the old "write_access" kind of semantics), things would still all work, > because it was still a "zero-vs-nonzero" issue wrt writes. .../... Right. Oh well.. we'll see when I get to it. I have a few higher priority things on my pile at the moment. Cheers, Ben.