Re: [PATCH 03/20] percpu: rename 4k first chunk allocator to page

Tejun Heo
2009-07-22T04:40:07Z

Christoph Lameter wrote:
> On Tue, 21 Jul 2009, Tejun Heo wrote:
>
>> - * Boring fallback 4k allocator. This allocator puts more pressure on
>> - * PTE TLBs but other than that behaves nicely on both UMA and NUMA.
>> + * Boring fallback 4k page allocator. This allocator puts more
>
> Guess this should not mentione 4k anymroe? page size allocation?

That's x86 specific code and PAGE_SIZE is always 4k there, so....
Also, this comment gets completely deleted by later patches anyway.

>> pr_warning("PERCPU: %s allocator failed (%zd), "
>> - "falling back to 4k\n",
>> + "falling back to page\n",
>
> "falling back to page size"?

So updated.

Thanks.

--
tejun