* [PATCH 0/5] More unreachable() conversions.
2009-12-10 17:25 [PATCH 0/5] More unreachable() conversions David Daney
@ 2009-12-10 17:25 ` David Daney
2009-12-10 17:28 ` [PATCH 1/5] mn10300: Convert BUG() to use unreachable() David Daney
` (4 subsequent siblings)
5 siblings, 0 replies; 16+ messages in thread
From: David Daney @ 2009-12-10 17:25 UTC (permalink / raw)
To: Andrew Morton, David Howells, Koichi Yasutake, linux-am33-list,
Kyle McMartin, Helge Deller, linux-parisc, Benjamin Herrenschmidt,
Paul Mackerras, linuxppc-dev, Richard Henderson, Ivan Kokshaysky,
Matt Turner, linux-alpha, Mike Frysinger, uclinux-dist-devel
Cc: Linux Kernel Mailing List, linux-arch, Linus Torvalds
Back in commit 38938c879eb0c39edf85d5164aa0cffe2874304c the new macro
unreachable() was added. We can use it in BUG instead of a variety of
ad hoc endless loops.
This patch set consists of the patches from the original set that were
never Acked-by anyone. Although they are completely untested, they
seem plausible.
I don't plan on pushing these things out any more, so if you
like them please merge them via your architecture trees.
I will reply with the 5 patches.
David Daney (5):
mn10300: Convert BUG() to use unreachable()
parisc: Convert BUG() to use unreachable()
powerpc: Convert BUG() to use unreachable()
alpha: Convert BUG() to use unreachable()
blackfin: Convert BUG() to use unreachable()
arch/alpha/include/asm/bug.h | 3 ++-
arch/blackfin/include/asm/bug.h | 2 +-
arch/mn10300/include/asm/bug.h | 3 ++-
arch/parisc/include/asm/bug.h | 4 ++--
arch/powerpc/include/asm/bug.h | 2 +-
5 files changed, 8 insertions(+), 6 deletions(-)
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 1/5] mn10300: Convert BUG() to use unreachable()
2009-12-10 17:25 [PATCH 0/5] More unreachable() conversions David Daney
2009-12-10 17:25 ` David Daney
@ 2009-12-10 17:28 ` David Daney
2009-12-10 17:28 ` David Daney
2009-12-10 17:28 ` [PATCH 2/5] parisc: " David Daney
` (3 subsequent siblings)
5 siblings, 1 reply; 16+ messages in thread
From: David Daney @ 2009-12-10 17:28 UTC (permalink / raw)
To: linux-kernel, linux-arch
Cc: akpm, torvalds, David Daney, David Howells, Koichi Yasutake,
linux-am33-list
Use the new unreachable() macro instead of while(1).
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
CC: David Howells <dhowells@redhat.com>
CC: Koichi Yasutake <yasutake.koichi@jp.panasonic.com>
CC: linux-am33-list@redhat.com
---
arch/mn10300/include/asm/bug.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/mn10300/include/asm/bug.h b/arch/mn10300/include/asm/bug.h
index aa6a388..447a7e6 100644
--- a/arch/mn10300/include/asm/bug.h
+++ b/arch/mn10300/include/asm/bug.h
@@ -27,7 +27,8 @@ do { \
: \
: "i"(__FILE__), "i"(__LINE__) \
); \
-} while (1)
+ unreachable(); \
+} while (0)
#define HAVE_ARCH_BUG
#endif /* CONFIG_BUG */
--
1.6.2.5
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 1/5] mn10300: Convert BUG() to use unreachable()
2009-12-10 17:28 ` [PATCH 1/5] mn10300: Convert BUG() to use unreachable() David Daney
@ 2009-12-10 17:28 ` David Daney
0 siblings, 0 replies; 16+ messages in thread
From: David Daney @ 2009-12-10 17:28 UTC (permalink / raw)
To: linux-kernel, linux-arch
Cc: akpm, torvalds, David Daney, David Howells, Koichi Yasutake,
linux-am33-list
Use the new unreachable() macro instead of while(1).
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
CC: David Howells <dhowells@redhat.com>
CC: Koichi Yasutake <yasutake.koichi@jp.panasonic.com>
CC: linux-am33-list@redhat.com
---
arch/mn10300/include/asm/bug.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/mn10300/include/asm/bug.h b/arch/mn10300/include/asm/bug.h
index aa6a388..447a7e6 100644
--- a/arch/mn10300/include/asm/bug.h
+++ b/arch/mn10300/include/asm/bug.h
@@ -27,7 +27,8 @@ do { \
: \
: "i"(__FILE__), "i"(__LINE__) \
); \
-} while (1)
+ unreachable(); \
+} while (0)
#define HAVE_ARCH_BUG
#endif /* CONFIG_BUG */
--
1.6.2.5
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/5] parisc: Convert BUG() to use unreachable()
2009-12-10 17:25 [PATCH 0/5] More unreachable() conversions David Daney
2009-12-10 17:25 ` David Daney
2009-12-10 17:28 ` [PATCH 1/5] mn10300: Convert BUG() to use unreachable() David Daney
@ 2009-12-10 17:28 ` David Daney
2009-12-10 17:28 ` David Daney
2009-12-10 21:54 ` Kyle McMartin
2009-12-10 17:28 ` [PATCH 3/5] powerpc: " David Daney
` (2 subsequent siblings)
5 siblings, 2 replies; 16+ messages in thread
From: David Daney @ 2009-12-10 17:28 UTC (permalink / raw)
To: linux-kernel, linux-arch
Cc: akpm, torvalds, David Daney, Kyle McMartin, Helge Deller,
linux-parisc
Use the new unreachable() macro instead of for(;;);
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
CC: Kyle McMartin <kyle@mcmartin.ca>
CC: Helge Deller <deller@gmx.de>
CC: linux-parisc@vger.kernel.org
---
arch/parisc/include/asm/bug.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/parisc/include/asm/bug.h b/arch/parisc/include/asm/bug.h
index 8cfc553..75e46c5 100644
--- a/arch/parisc/include/asm/bug.h
+++ b/arch/parisc/include/asm/bug.h
@@ -32,14 +32,14 @@
"\t.popsection" \
: : "i" (__FILE__), "i" (__LINE__), \
"i" (0), "i" (sizeof(struct bug_entry)) ); \
- for(;;) ; \
+ unreachable(); \
} while(0)
#else
#define BUG() \
do { \
asm volatile(PARISC_BUG_BREAK_ASM : : ); \
- for(;;) ; \
+ unreachable(); \
} while(0)
#endif
--
1.6.2.5
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 2/5] parisc: Convert BUG() to use unreachable()
2009-12-10 17:28 ` [PATCH 2/5] parisc: " David Daney
@ 2009-12-10 17:28 ` David Daney
2009-12-10 21:54 ` Kyle McMartin
1 sibling, 0 replies; 16+ messages in thread
From: David Daney @ 2009-12-10 17:28 UTC (permalink / raw)
To: linux-kernel, linux-arch
Cc: akpm, torvalds, David Daney, Kyle McMartin, Helge Deller,
linux-parisc
Use the new unreachable() macro instead of for(;;);
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
CC: Kyle McMartin <kyle@mcmartin.ca>
CC: Helge Deller <deller@gmx.de>
CC: linux-parisc@vger.kernel.org
---
arch/parisc/include/asm/bug.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/parisc/include/asm/bug.h b/arch/parisc/include/asm/bug.h
index 8cfc553..75e46c5 100644
--- a/arch/parisc/include/asm/bug.h
+++ b/arch/parisc/include/asm/bug.h
@@ -32,14 +32,14 @@
"\t.popsection" \
: : "i" (__FILE__), "i" (__LINE__), \
"i" (0), "i" (sizeof(struct bug_entry)) ); \
- for(;;) ; \
+ unreachable(); \
} while(0)
#else
#define BUG() \
do { \
asm volatile(PARISC_BUG_BREAK_ASM : : ); \
- for(;;) ; \
+ unreachable(); \
} while(0)
#endif
--
1.6.2.5
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 2/5] parisc: Convert BUG() to use unreachable()
2009-12-10 17:28 ` [PATCH 2/5] parisc: " David Daney
2009-12-10 17:28 ` David Daney
@ 2009-12-10 21:54 ` Kyle McMartin
2009-12-10 21:54 ` Kyle McMartin
1 sibling, 1 reply; 16+ messages in thread
From: Kyle McMartin @ 2009-12-10 21:54 UTC (permalink / raw)
To: David Daney
Cc: linux-kernel, linux-arch, akpm, torvalds, Kyle McMartin,
Helge Deller, linux-parisc
On Thu, Dec 10, 2009 at 09:28:18AM -0800, David Daney wrote:
> Use the new unreachable() macro instead of for(;;);
>
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> CC: Kyle McMartin <kyle@mcmartin.ca>
> CC: Helge Deller <deller@gmx.de>
> CC: linux-parisc@vger.kernel.org
> ---
Thanks David, I'll bash this into my tree now that the macro is
upstream.
regards, Kyle
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/5] parisc: Convert BUG() to use unreachable()
2009-12-10 21:54 ` Kyle McMartin
@ 2009-12-10 21:54 ` Kyle McMartin
0 siblings, 0 replies; 16+ messages in thread
From: Kyle McMartin @ 2009-12-10 21:54 UTC (permalink / raw)
To: David Daney
Cc: linux-kernel, linux-arch, akpm, torvalds, Kyle McMartin,
Helge Deller, linux-parisc
On Thu, Dec 10, 2009 at 09:28:18AM -0800, David Daney wrote:
> Use the new unreachable() macro instead of for(;;);
>
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> CC: Kyle McMartin <kyle@mcmartin.ca>
> CC: Helge Deller <deller@gmx.de>
> CC: linux-parisc@vger.kernel.org
> ---
Thanks David, I'll bash this into my tree now that the macro is
upstream.
regards, Kyle
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 3/5] powerpc: Convert BUG() to use unreachable()
2009-12-10 17:25 [PATCH 0/5] More unreachable() conversions David Daney
` (2 preceding siblings ...)
2009-12-10 17:28 ` [PATCH 2/5] parisc: " David Daney
@ 2009-12-10 17:28 ` David Daney
2009-12-10 17:28 ` [PATCH 4/5] alpha: " David Daney
2009-12-10 17:28 ` [PATCH 5/5] blackfin: " David Daney
5 siblings, 0 replies; 16+ messages in thread
From: David Daney @ 2009-12-10 17:28 UTC (permalink / raw)
To: linux-kernel, linux-arch
Cc: akpm, torvalds, David Daney, Benjamin Herrenschmidt,
Paul Mackerras, linuxppc-dev
Use the new unreachable() macro instead of for(;;);
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <paulus@samba.org>
CC: linuxppc-dev@ozlabs.org
---
arch/powerpc/include/asm/bug.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/include/asm/bug.h b/arch/powerpc/include/asm/bug.h
index 64e1fdc..2c15212 100644
--- a/arch/powerpc/include/asm/bug.h
+++ b/arch/powerpc/include/asm/bug.h
@@ -68,7 +68,7 @@
_EMIT_BUG_ENTRY \
: : "i" (__FILE__), "i" (__LINE__), \
"i" (0), "i" (sizeof(struct bug_entry))); \
- for(;;) ; \
+ unreachable(); \
} while (0)
#define BUG_ON(x) do { \
--
1.6.2.5
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 4/5] alpha: Convert BUG() to use unreachable()
2009-12-10 17:25 [PATCH 0/5] More unreachable() conversions David Daney
` (3 preceding siblings ...)
2009-12-10 17:28 ` [PATCH 3/5] powerpc: " David Daney
@ 2009-12-10 17:28 ` David Daney
2009-12-11 0:42 ` Matt Turner
2009-12-10 17:28 ` [PATCH 5/5] blackfin: " David Daney
5 siblings, 1 reply; 16+ messages in thread
From: David Daney @ 2009-12-10 17:28 UTC (permalink / raw)
To: linux-kernel, linux-arch
Cc: akpm, torvalds, David Daney, Richard Henderson, Ivan Kokshaysky,
Matt Turner, linux-alpha
Use the new unreachable() macro instead of for(;;);
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
CC: Richard Henderson <rth@twiddle.net>
CC: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
CC: Matt Turner <mattst88@gmail.com>
CC: linux-alpha@vger.kernel.org
---
arch/alpha/include/asm/bug.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/alpha/include/asm/bug.h b/arch/alpha/include/asm/bug.h
index 1720c8a..f091682 100644
--- a/arch/alpha/include/asm/bug.h
+++ b/arch/alpha/include/asm/bug.h
@@ -13,7 +13,8 @@
"call_pal %0 # bugchk\n\t" \
".long %1\n\t.8byte %2" \
: : "i"(PAL_bugchk), "i"(__LINE__), "i"(__FILE__)); \
- for ( ; ; ); } while (0)
+ unreachable(); \
+ } while (0)
#define HAVE_ARCH_BUG
#endif
--
1.6.2.5
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 4/5] alpha: Convert BUG() to use unreachable()
2009-12-10 17:28 ` [PATCH 4/5] alpha: " David Daney
@ 2009-12-11 0:42 ` Matt Turner
0 siblings, 0 replies; 16+ messages in thread
From: Matt Turner @ 2009-12-11 0:42 UTC (permalink / raw)
To: David Daney
Cc: linux-kernel, linux-arch, akpm, torvalds, Richard Henderson,
Ivan Kokshaysky, linux-alpha
On Thu, Dec 10, 2009 at 12:28 PM, David Daney <ddaney@caviumnetworks.com> wrote:
> Use the new unreachable() macro instead of for(;;);
>
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> CC: Richard Henderson <rth@twiddle.net>
> CC: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
> CC: Matt Turner <mattst88@gmail.com>
> CC: linux-alpha@vger.kernel.org
> ---
> arch/alpha/include/asm/bug.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/alpha/include/asm/bug.h b/arch/alpha/include/asm/bug.h
> index 1720c8a..f091682 100644
> --- a/arch/alpha/include/asm/bug.h
> +++ b/arch/alpha/include/asm/bug.h
> @@ -13,7 +13,8 @@
> "call_pal %0 # bugchk\n\t" \
> ".long %1\n\t.8byte %2" \
> : : "i"(PAL_bugchk), "i"(__LINE__), "i"(__FILE__)); \
> - for ( ; ; ); } while (0)
> + unreachable(); \
> + } while (0)
>
> #define HAVE_ARCH_BUG
> #endif
> --
> 1.6.2.5
Thanks David. I've pushed this into my tree.
Matt
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 5/5] blackfin: Convert BUG() to use unreachable()
2009-12-10 17:25 [PATCH 0/5] More unreachable() conversions David Daney
` (4 preceding siblings ...)
2009-12-10 17:28 ` [PATCH 4/5] alpha: " David Daney
@ 2009-12-10 17:28 ` David Daney
2009-12-10 17:28 ` David Daney
2009-12-10 21:33 ` [Uclinux-dist-devel] " Mike Frysinger
5 siblings, 2 replies; 16+ messages in thread
From: David Daney @ 2009-12-10 17:28 UTC (permalink / raw)
To: linux-kernel, linux-arch
Cc: akpm, torvalds, David Daney, Mike Frysinger, uclinux-dist-devel
Use the new unreachable() macro instead of for(;;);
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
CC: Mike Frysinger <vapier@gentoo.org>
CC: uclinux-dist-devel@blackfin.uclinux.org
---
arch/blackfin/include/asm/bug.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/blackfin/include/asm/bug.h b/arch/blackfin/include/asm/bug.h
index 6f4548a..75f6dc3 100644
--- a/arch/blackfin/include/asm/bug.h
+++ b/arch/blackfin/include/asm/bug.h
@@ -47,7 +47,7 @@
#define BUG() \
do { \
_BUG_OR_WARN(0); \
- for (;;); \
+ unreachable(); \
} while (0)
#define WARN_ON(condition) \
--
1.6.2.5
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 5/5] blackfin: Convert BUG() to use unreachable()
2009-12-10 17:28 ` [PATCH 5/5] blackfin: " David Daney
@ 2009-12-10 17:28 ` David Daney
2009-12-10 21:33 ` [Uclinux-dist-devel] " Mike Frysinger
1 sibling, 0 replies; 16+ messages in thread
From: David Daney @ 2009-12-10 17:28 UTC (permalink / raw)
To: linux-kernel, linux-arch
Cc: akpm, torvalds, David Daney, Mike Frysinger, uclinux-dist-devel
Use the new unreachable() macro instead of for(;;);
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
CC: Mike Frysinger <vapier@gentoo.org>
CC: uclinux-dist-devel@blackfin.uclinux.org
---
arch/blackfin/include/asm/bug.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/blackfin/include/asm/bug.h b/arch/blackfin/include/asm/bug.h
index 6f4548a..75f6dc3 100644
--- a/arch/blackfin/include/asm/bug.h
+++ b/arch/blackfin/include/asm/bug.h
@@ -47,7 +47,7 @@
#define BUG() \
do { \
_BUG_OR_WARN(0); \
- for (;;); \
+ unreachable(); \
} while (0)
#define WARN_ON(condition) \
--
1.6.2.5
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [Uclinux-dist-devel] [PATCH 5/5] blackfin: Convert BUG() to use unreachable()
2009-12-10 17:28 ` [PATCH 5/5] blackfin: " David Daney
2009-12-10 17:28 ` David Daney
@ 2009-12-10 21:33 ` Mike Frysinger
2009-12-10 21:35 ` David Daney
1 sibling, 1 reply; 16+ messages in thread
From: Mike Frysinger @ 2009-12-10 21:33 UTC (permalink / raw)
To: David Daney; +Cc: linux-kernel, linux-arch, akpm, torvalds, uclinux-dist-devel
On Thu, Dec 10, 2009 at 12:28, David Daney wrote:
> Use the new unreachable() macro instead of for(;;);
sorry, i guess i missed this back in Sept. change looks fine to me
(i'll test it later when finishing putting together other patches).
you want me to push though my queue ? doesnt matter to me.
-mike
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Uclinux-dist-devel] [PATCH 5/5] blackfin: Convert BUG() to use unreachable()
2009-12-10 21:33 ` [Uclinux-dist-devel] " Mike Frysinger
@ 2009-12-10 21:35 ` David Daney
2009-12-10 22:42 ` Mike Frysinger
0 siblings, 1 reply; 16+ messages in thread
From: David Daney @ 2009-12-10 21:35 UTC (permalink / raw)
To: Mike Frysinger
Cc: linux-kernel, linux-arch, akpm, torvalds, uclinux-dist-devel
Mike Frysinger wrote:
> On Thu, Dec 10, 2009 at 12:28, David Daney wrote:
>> Use the new unreachable() macro instead of for(;;);
>
> sorry, i guess i missed this back in Sept. change looks fine to me
> (i'll test it later when finishing putting together other patches).
> you want me to push though my queue ? doesnt matter to me.
Yes, if you test it and are happy with it. I have no queue and plan no
further action.
David Daney
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Uclinux-dist-devel] [PATCH 5/5] blackfin: Convert BUG() to use unreachable()
2009-12-10 21:35 ` David Daney
@ 2009-12-10 22:42 ` Mike Frysinger
0 siblings, 0 replies; 16+ messages in thread
From: Mike Frysinger @ 2009-12-10 22:42 UTC (permalink / raw)
To: David Daney; +Cc: linux-kernel, linux-arch, akpm, torvalds, uclinux-dist-devel
On Thu, Dec 10, 2009 at 16:35, David Daney wrote:
> Mike Frysinger wrote:
>> On Thu, Dec 10, 2009 at 12:28, David Daney wrote:
>>> Use the new unreachable() macro instead of for(;;);
>>
>> sorry, i guess i missed this back in Sept. change looks fine to me
>> (i'll test it later when finishing putting together other patches).
>> you want me to push though my queue ? doesnt matter to me.
>
> Yes, if you test it and are happy with it. I have no queue and plan no
> further action.
rgr
-mike
^ permalink raw reply [flat|nested] 16+ messages in thread