linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@suse.de>
To: linux-arch@vger.kernel.org
Cc: linux-parisc@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Russell King <rmk@arm.linux.org.uk>,
	Paul Mundt <lethal@linux-sh.org>,
	James Bottomley <James.Bottomley@suse.de>
Subject: [PATCHv2 5/5] xfs: fix xfs to work with Virtually Indexed architectures
Date: Wed, 23 Dec 2009 15:22:25 -0600	[thread overview]
Message-ID: <1261603345-2494-6-git-send-email-James.Bottomley@suse.de> (raw)
In-Reply-To: <1261603345-2494-5-git-send-email-James.Bottomley@suse.de>

xfs_buf.c includes what is essentially a hand rolled version of
blk_rq_map_kern().  In order to work properly with the vmalloc buffers
that xfs uses, this hand rolled routine must also implement the flushing
API for vmap/vmalloc areas.

Signed-off-by: James Bottomley <James.Bottomley@suse.de>
---
 fs/xfs/linux-2.6/xfs_buf.c |   20 +++++++++++++++++++-
 1 files changed, 19 insertions(+), 1 deletions(-)

diff --git a/fs/xfs/linux-2.6/xfs_buf.c b/fs/xfs/linux-2.6/xfs_buf.c
index 77b8be8..4c77d96 100644
--- a/fs/xfs/linux-2.6/xfs_buf.c
+++ b/fs/xfs/linux-2.6/xfs_buf.c
@@ -76,6 +76,19 @@ struct workqueue_struct *xfsconvertd_workqueue;
 #define xfs_buf_deallocate(bp) \
 	kmem_zone_free(xfs_buf_zone, (bp));
 
+STATIC int
+xfs_bp_is_vmapped(
+	xfs_buf_t	*bp)
+{
+	/* return true if the buffer is vmapped. The XBF_MAPPED flag
+	 * is set if the buffer should be mapped, but the code is
+	 * clever enough to know it doesn't have to map a single page,
+	 * so the check has to be both for XBF_MAPPED and
+	 * bp->b_page_count > 1 */
+	return (bp->b_flags & XBF_MAPPED) && bp->b_page_count > 1;
+}
+
+
 /*
  *	Page Region interfaces.
  *
@@ -314,7 +327,7 @@ xfs_buf_free(
 	if (bp->b_flags & (_XBF_PAGE_CACHE|_XBF_PAGES)) {
 		uint		i;
 
-		if ((bp->b_flags & XBF_MAPPED) && (bp->b_page_count > 1))
+		if (xfs_bp_is_vmapped(bp))
 			free_address(bp->b_addr - bp->b_offset);
 
 		for (i = 0; i < bp->b_page_count; i++) {
@@ -1107,6 +1120,9 @@ xfs_buf_bio_end_io(
 
 	xfs_buf_ioerror(bp, -error);
 
+	if (!error && xfs_bp_is_vmapped(bp))
+		invalidate_kernel_vmap_range(bp->b_addr, (bp->b_page_count * PAGE_SIZE) - bp->b_offset);
+
 	do {
 		struct page	*page = bvec->bv_page;
 
@@ -1216,6 +1232,8 @@ next_chunk:
 
 submit_io:
 	if (likely(bio->bi_size)) {
+		if (xfs_bp_is_vmapped(bp))
+			flush_kernel_vmap_range(bp->b_addr, (bp->b_page_count * PAGE_SIZE) - bp->b_offset);
 		submit_bio(rw, bio);
 		if (size)
 			goto next_chunk;
-- 
1.6.5

  parent reply	other threads:[~2009-12-23 21:22 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-23 21:22 [PATCHv2 0/5] fix xfs by making I/O to vmap/vmalloc areas work James Bottomley
2009-12-23 21:22 ` [PATCHv2 1/5] mm: add coherence API for DMA to vmalloc/vmap areas James Bottomley
2009-12-23 21:22   ` James Bottomley
2009-12-23 21:22   ` [PATCHv2 2/5] parisc: add mm " James Bottomley
2009-12-23 21:22     ` [PATCHv2 3/5] arm: " James Bottomley
2009-12-23 21:22       ` [PATCHv2 4/5] sh: " James Bottomley
2009-12-23 21:22         ` James Bottomley
2009-12-23 21:22         ` James Bottomley [this message]
2009-12-24 11:03           ` [PATCHv2 5/5] xfs: fix xfs to work with Virtually Indexed architectures Christoph Hellwig
2009-12-24 11:03             ` Christoph Hellwig
2009-12-27 15:32             ` James Bottomley
2010-01-02 21:33     ` [PATCHv2 2/5] parisc: add mm API for DMA to vmalloc/vmap areas Benjamin Herrenschmidt
2010-01-02 21:33       ` Benjamin Herrenschmidt
2010-01-02 21:53       ` James Bottomley
2010-01-03 20:12         ` Benjamin Herrenschmidt
2010-01-03 20:12           ` Benjamin Herrenschmidt
2009-12-24 10:08   ` [PATCHv2 1/5] mm: add coherence " Matt Fleming
2009-12-24 10:08     ` Matt Fleming
2009-12-24 12:39     ` Matthew Wilcox
2009-12-24 12:39       ` Matthew Wilcox
2009-12-24 13:06       ` Matt Fleming
2009-12-24 13:06         ` Matt Fleming
2009-12-27 15:37       ` James Bottomley
2010-01-02 21:27       ` Benjamin Herrenschmidt
2010-01-02 21:54         ` James Bottomley
2010-01-03 20:14           ` Benjamin Herrenschmidt
2010-01-03 20:14             ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1261603345-2494-6-git-send-email-James.Bottomley@suse.de \
    --to=james.bottomley@suse.de \
    --cc=hch@lst.de \
    --cc=lethal@linux-sh.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).