From: Steven Rostedt <rostedt@goodmis.org>
To: Julia Lawall <julia@diku.dk>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arch@vger.kernel.org, Greg KH <greg@kroah.com>,
Andy Whitcroft <apw@canonical.com>
Subject: Re: Lots of bugs with current->state = TASK_*INTERRUPTIBLE
Date: Tue, 19 Jan 2010 16:08:53 -0500 [thread overview]
Message-ID: <1263935333.4561.26.camel@frodo> (raw)
In-Reply-To: <Pine.LNX.4.64.1001192155490.28583@ask.diku.dk>
On Tue, 2010-01-19 at 21:58 +0100, Julia Lawall wrote:
> > Anyway, this looks like a good janitorial work. Anything that assigns
> > state outside the rq locks to something other than TASK_RUNNING and that
> > is not before a schedule() (perhaps even those) should be converted to:
> >
> > set_current_task(<state>).
>
> Does "not before a schedule" mean not before a schedule_timeout as well?
Yep.
>
> Also, I assume you mean set_current_state?
Yep!
Thanks!
-- Steve
next prev parent reply other threads:[~2010-01-19 21:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 20:29 Lots of bugs with current->state = TASK_*INTERRUPTIBLE Steven Rostedt
2010-01-19 20:58 ` Julia Lawall
2010-01-19 20:58 ` Julia Lawall
2010-01-19 21:08 ` Steven Rostedt [this message]
2010-01-21 10:47 ` Julia Lawall
2010-01-21 10:47 ` Julia Lawall
2010-01-21 10:53 ` Frederic Weisbecker
2010-01-21 10:56 ` Peter Zijlstra
2010-01-21 10:59 ` Frederic Weisbecker
2010-01-21 17:31 ` Steven Rostedt
2010-01-21 17:31 ` Steven Rostedt
2010-01-21 18:12 ` Julia Lawall
2010-01-21 19:18 ` David Daney
2010-01-21 19:34 ` Steven Rostedt
2010-01-21 19:57 ` David Daney
2010-01-21 20:18 ` Steven Rostedt
2010-01-21 20:18 ` Steven Rostedt
2010-01-21 20:21 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263935333.4561.26.camel@frodo \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=greg@kroah.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox