From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Yinghai Lu <yinghai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [RFC PATCH -v3 1/2] lmb: seperate region array from lmb_region struct
Date: Wed, 24 Mar 2010 15:45:55 +1100 [thread overview]
Message-ID: <1269405955.8599.156.camel@pasglop> (raw)
In-Reply-To: <20100323104241.GA1189@elte.hu>
On Tue, 2010-03-23 at 11:42 +0100, Ingo Molnar wrote:
> * Yinghai Lu <yinghai@kernel.org> wrote:
>
> > void __init lmb_init(void)
> > {
> > + lmb.memory.region = lmb_memory_region;
> > + lmb.memory.region_array_size = ARRAY_SIZE(lmb_memory_region);
> > + lmb.reserved.region = lmb_reserved_region;
> > + lmb.reserved.region_array_size = ARRAY_SIZE(lmb_reserved_region);
> > +
>
> That's rather unreadable and has random whitespace noise.
>
> Should be something like:
>
> lmb.memory.region = lmb_memory_region;
> lmb.memory.region_array_size = ARRAY_SIZE(lmb_memory_region);
> lmb.reserved.region = lmb_reserved_region;
> lmb.reserved.region_array_size = ARRAY_SIZE(lmb_reserved_region);
>
> also, i'd suggest to shorten region_array_size to region_size (we know it's an
> array), so it would become:
I dislike those arrays anyways. See my other message about turning them
into lists, which would get rid of capacity constraints completely. What
do you think ?
Cheers,
Ben.
next prev parent reply other threads:[~2010-03-24 4:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 8:39 [PATCH 00/04] use lmb with x86 Yinghai Lu
2010-03-23 8:39 ` Yinghai Lu
2010-03-23 8:39 ` [PATCH 1/4] x86: do not free zero sized per cpu areas Yinghai Lu
2010-03-23 8:39 ` Yinghai Lu
2010-03-23 8:39 ` [PATCH 2/4] x86: add find_e820_area_node Yinghai Lu
2010-03-23 8:39 ` Yinghai Lu
2010-03-23 8:39 ` [PATCH 3/4] x86: add sanitize_e820_map Yinghai Lu
2010-03-23 8:39 ` Yinghai Lu
2010-03-23 8:39 ` [RFC PATCH -v2 4/4] x86: use lmb to replace early_res Yinghai Lu
2010-03-23 8:39 ` Yinghai Lu
2010-03-23 9:14 ` Ingo Molnar
2010-03-23 10:36 ` [RFC PATCH -v3 1/2] lmb: seperate region array from lmb_region struct Yinghai Lu
2010-03-23 10:36 ` Yinghai Lu
2010-03-23 10:42 ` Ingo Molnar
2010-03-23 13:18 ` Paul Mundt
2010-03-23 13:18 ` Paul Mundt
2010-03-23 17:17 ` Yinghai Lu
2010-03-23 18:13 ` Paul Mundt
2010-03-23 18:13 ` Paul Mundt
2010-03-24 4:45 ` Benjamin Herrenschmidt [this message]
2010-03-24 5:36 ` [RFC PATCH v4 " Yinghai Lu
2010-03-24 5:37 ` [RFC PATCH -v4 2/2] x86: use lmb to replace early_res Yinghai Lu
2010-03-24 5:46 ` [RFC PATCH -v3 1/2] lmb: seperate region array from lmb_region struct Yinghai Lu
2010-03-24 7:41 ` Benjamin Herrenschmidt
2010-03-23 15:07 ` Thomas Gleixner
2010-03-23 17:38 ` Yinghai Lu
2010-03-23 18:08 ` Ingo Molnar
2010-03-23 10:37 ` [RFC PATCH -v3 2/2] x86: use lmb to replace early_res Yinghai Lu
2010-03-23 10:37 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269405955.8599.156.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox