From: Yinghai Lu <yinghai@kernel.org> To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>, Andrew Morton <akpm@linux-foundation.org>, David Miller <davem@davemloft.net>, Be Cc: Johannes Weiner <hannes@cmpxchg.org>, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Yinghai Lu <yinghai@kernel.org> Subject: [PATCH 23/24] x86, lmb: Use lmb_memory_size()/lmb_free_memory_size() to get correct dma_reserve Date: Fri, 26 Mar 2010 15:21:53 -0700 [thread overview] Message-ID: <1269642114-16588-24-git-send-email-yinghai@kernel.org> (raw) In-Reply-To: <1269642114-16588-1-git-send-email-yinghai@kernel.org> lmb_memory_size() will return memory size in lmb.memory.region. lmb_free_memory_size() will return free memory size in lmb.memory.region. So We can get exact reseved size. Set the size right after initmem_init(), because later bootmem API will get area from 16M. (except some fallback). Later after we remove the bootmem, We could call that just before paging_init(). Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- arch/x86/include/asm/e820.h | 2 ++ arch/x86/kernel/e820.c | 17 +++++++++++++++++ arch/x86/kernel/setup.c | 1 + arch/x86/mm/init_64.c | 7 ------- 4 files changed, 20 insertions(+), 7 deletions(-) diff --git a/arch/x86/include/asm/e820.h b/arch/x86/include/asm/e820.h index de6cd06..334281f 100644 --- a/arch/x86/include/asm/e820.h +++ b/arch/x86/include/asm/e820.h @@ -117,6 +117,8 @@ extern u64 early_reserve_e820(u64 startt, u64 sizet, u64 align); void init_lmb_memory(void); void fill_lmb_memory(void); +void find_lmb_dma_reserve(void); + extern void finish_e820_parsing(void); extern void e820_reserve_resources(void); extern void e820_reserve_resources_late(void); diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c index 78ba396..e0257b8 100644 --- a/arch/x86/kernel/e820.c +++ b/arch/x86/kernel/e820.c @@ -1100,3 +1100,20 @@ void __init fill_lmb_memory(void) lmb_analyze(); lmb_dump_all(); } + +void __init find_lmb_dma_reserve(void) +{ +#ifdef CONFIG_X86_64 + u64 free_size_pfn; + u64 mem_size_pfn; + /* + * need to find out used area below MAX_DMA_PFN + * need to use lmb to get free size in [0, MAX_DMA_PFN] + * at first, and assume boot_mem will not take below MAX_DMA_PFN + */ + mem_size_pfn = lmb_memory_size(0, MAX_DMA_PFN << PAGE_SHIFT) >> PAGE_SHIFT; + free_size_pfn = lmb_free_memory_size(0, MAX_DMA_PFN << PAGE_SHIFT) >> PAGE_SHIFT; + set_dma_reserve(mem_size_pfn - free_size_pfn); +#endif +} + diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index f0a32a4..6b62d9b 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -979,6 +979,7 @@ void __init setup_arch(char **cmdline_p) #endif initmem_init(0, max_pfn, acpi, k8); + find_lmb_dma_reserve(); #ifndef CONFIG_NO_BOOTMEM lmb_to_bootmem(0, max_low_pfn<<PAGE_SHIFT); #endif diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index b86492e..f1af41c 100644 --- a/arch/x86/mm/init_64.c +++ b/arch/x86/mm/init_64.c @@ -52,8 +52,6 @@ #include <asm/init.h> #include <linux/bootmem.h> -static unsigned long dma_reserve __initdata; - static int __init parse_direct_gbpages_off(char *arg) { direct_gbpages = 0; @@ -820,11 +818,6 @@ int __init reserve_bootmem_generic(unsigned long phys, unsigned long len, reserve_bootmem(phys, len, flags); - if (phys+len <= MAX_DMA_PFN*PAGE_SIZE) { - dma_reserve += len / PAGE_SIZE; - set_dma_reserve(dma_reserve); - } - return 0; } #endif -- 1.6.4.2
WARNING: multiple messages have this Message-ID (diff)
From: Yinghai Lu <yinghai@kernel.org> To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>, Andrew Morton <akpm@linux-foundation.org>, David Miller <davem@davemloft.net>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Linus Torvalds <torvalds@linux-foundation.org> Cc: Johannes Weiner <hannes@cmpxchg.org>, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Yinghai Lu <yinghai@kernel.org> Subject: [PATCH 23/24] x86, lmb: Use lmb_memory_size()/lmb_free_memory_size() to get correct dma_reserve Date: Fri, 26 Mar 2010 15:21:53 -0700 [thread overview] Message-ID: <1269642114-16588-24-git-send-email-yinghai@kernel.org> (raw) Message-ID: <20100326222153.TMi50n3E5HjlR2hQlN6EDhGL2jvQTMVcMel9CPjNyVI@z> (raw) In-Reply-To: <1269642114-16588-1-git-send-email-yinghai@kernel.org> lmb_memory_size() will return memory size in lmb.memory.region. lmb_free_memory_size() will return free memory size in lmb.memory.region. So We can get exact reseved size. Set the size right after initmem_init(), because later bootmem API will get area from 16M. (except some fallback). Later after we remove the bootmem, We could call that just before paging_init(). Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- arch/x86/include/asm/e820.h | 2 ++ arch/x86/kernel/e820.c | 17 +++++++++++++++++ arch/x86/kernel/setup.c | 1 + arch/x86/mm/init_64.c | 7 ------- 4 files changed, 20 insertions(+), 7 deletions(-) diff --git a/arch/x86/include/asm/e820.h b/arch/x86/include/asm/e820.h index de6cd06..334281f 100644 --- a/arch/x86/include/asm/e820.h +++ b/arch/x86/include/asm/e820.h @@ -117,6 +117,8 @@ extern u64 early_reserve_e820(u64 startt, u64 sizet, u64 align); void init_lmb_memory(void); void fill_lmb_memory(void); +void find_lmb_dma_reserve(void); + extern void finish_e820_parsing(void); extern void e820_reserve_resources(void); extern void e820_reserve_resources_late(void); diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c index 78ba396..e0257b8 100644 --- a/arch/x86/kernel/e820.c +++ b/arch/x86/kernel/e820.c @@ -1100,3 +1100,20 @@ void __init fill_lmb_memory(void) lmb_analyze(); lmb_dump_all(); } + +void __init find_lmb_dma_reserve(void) +{ +#ifdef CONFIG_X86_64 + u64 free_size_pfn; + u64 mem_size_pfn; + /* + * need to find out used area below MAX_DMA_PFN + * need to use lmb to get free size in [0, MAX_DMA_PFN] + * at first, and assume boot_mem will not take below MAX_DMA_PFN + */ + mem_size_pfn = lmb_memory_size(0, MAX_DMA_PFN << PAGE_SHIFT) >> PAGE_SHIFT; + free_size_pfn = lmb_free_memory_size(0, MAX_DMA_PFN << PAGE_SHIFT) >> PAGE_SHIFT; + set_dma_reserve(mem_size_pfn - free_size_pfn); +#endif +} + diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index f0a32a4..6b62d9b 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -979,6 +979,7 @@ void __init setup_arch(char **cmdline_p) #endif initmem_init(0, max_pfn, acpi, k8); + find_lmb_dma_reserve(); #ifndef CONFIG_NO_BOOTMEM lmb_to_bootmem(0, max_low_pfn<<PAGE_SHIFT); #endif diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index b86492e..f1af41c 100644 --- a/arch/x86/mm/init_64.c +++ b/arch/x86/mm/init_64.c @@ -52,8 +52,6 @@ #include <asm/init.h> #include <linux/bootmem.h> -static unsigned long dma_reserve __initdata; - static int __init parse_direct_gbpages_off(char *arg) { direct_gbpages = 0; @@ -820,11 +818,6 @@ int __init reserve_bootmem_generic(unsigned long phys, unsigned long len, reserve_bootmem(phys, len, flags); - if (phys+len <= MAX_DMA_PFN*PAGE_SIZE) { - dma_reserve += len / PAGE_SIZE; - set_dma_reserve(dma_reserve); - } - return 0; } #endif -- 1.6.4.2
next prev parent reply other threads:[~2010-03-26 22:26 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-03-26 22:21 [PATCH -v8 00/24] use lmb with x86 Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 01/24] x86: Make smp_locks end with page alignment Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 23:33 ` Johannes Weiner 2010-03-26 22:21 ` [PATCH 02/24] x86: Make sure free_init_pages() free pages in boundary Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 23:06 ` Johannes Weiner 2010-03-26 23:06 ` Johannes Weiner 2010-03-26 23:45 ` Yinghai Lu 2010-03-27 0:07 ` Johannes Weiner 2010-03-27 0:07 ` Johannes Weiner 2010-03-27 0:17 ` Yinghai Lu 2010-03-27 0:17 ` Yinghai Lu 2010-03-27 1:19 ` [PATCH -v3] " Yinghai Lu 2010-03-28 0:03 ` Johannes Weiner 2010-03-28 0:50 ` Yinghai Lu 2010-03-28 1:01 ` Johannes Weiner 2010-03-28 1:58 ` Yinghai Lu 2010-03-28 23:35 ` [patch v5] x86: page-alin initrd area size Johannes Weiner 2010-03-29 0:41 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 03/24] x86: Do not free zero sized per cpu areas Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 23:42 ` Johannes Weiner 2010-03-26 23:42 ` Johannes Weiner 2010-03-26 23:49 ` Yinghai Lu 2010-03-26 23:49 ` Yinghai Lu 2010-03-26 23:54 ` Johannes Weiner 2010-03-26 23:56 ` Yinghai Lu 2010-03-27 1:18 ` [PATCH -v8] " Yinghai Lu 2010-03-26 22:21 ` [PATCH 04/24] lmb: Move lmb.c to mm/ Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 05/24] lmb: Seperate region array from lmb_region struct Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 06/24] lmb: Add find_lmb_area() Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 07/24] lmb: Add reserve_lmb/free_lmb Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 08/24] lmb: Add find_lmb_area_size() Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 09/24] bootmem, x86: Add weak version of reserve_bootmem_generic Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 10/24] lmb: Add lmb_to_bootmem() Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 11/24] lmb: Add get_free_all_memory_range() Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 12/24] lmb: Add lmb_register_active_regions() and lmb_hole_size() Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 13/24] lmb: Prepare to include linux/lmb.h in core file Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 14/24] lmb: Add find_memory_core_early() Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 15/24] lmb: Add find_lmb_area_node() Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 16/24] lmb: Add lmb_free_memory_size() Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 17/24] lmb: Add lmb_memory_size() Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 18/24] lmb: Add reserve_lmb_overlap_ok() Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 19/24] x86: Add sanitize_e820_map() Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 20/24] x86: Use lmb to replace early_res Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 21/24] x86: Replace e820_/_early string with lmb_ Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` [PATCH 22/24] x86: Remove not used early_res code Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu [this message] 2010-03-26 22:21 ` [PATCH 23/24] x86, lmb: Use lmb_memory_size()/lmb_free_memory_size() to get correct dma_reserve Yinghai Lu 2010-03-26 22:21 ` [PATCH 24/24] x86: Align e820 ram range to page Yinghai Lu 2010-03-26 22:21 ` Yinghai Lu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1269642114-16588-24-git-send-email-yinghai@kernel.org \ --to=yinghai@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=davem@davemloft.net \ --cc=hannes@cmpxchg.org \ --cc=hpa@zytor.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@elte.hu \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).