From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yinghai Lu Subject: [PATCH 03/31] x86: Do not free zero sized per cpu areas Date: Sun, 28 Mar 2010 19:42:56 -0700 Message-ID: <1269830604-26214-4-git-send-email-yinghai@kernel.org> References: <1269830604-26214-1-git-send-email-yinghai@kernel.org> Return-path: Received: from rcsinet11.oracle.com ([148.87.113.123]:19546 "EHLO rcsinet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755946Ab0C2Cq6 (ORCPT ); Sun, 28 Mar 2010 22:46:58 -0400 In-Reply-To: <1269830604-26214-1-git-send-email-yinghai@kernel.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , David Miller , Be Cc: Johannes Weiner , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Ian Campbell , Yinghai Lu , Peter Zijlstra , Ingo Molnar From: Ian Campbell This avoids an infinite loop in free_early_partial(). Add a warning to free_early_partial to catch future problems. -v5: put back start > end back into WARN_ONCE() -v6: use one line for warning according to linus -v7: more test by -v8: remove the function name according to Johannes WARN_ONCE will print that function name. Signed-off-by: Ian Campbell Signed-off-by: Yinghai Lu Tested-by: Konrad Rzeszutek Wilk Tested-by: Joel Becker Tested-by: Stanislaw Gruszka Acked-by: Johannes Weiner Cc: Peter Zijlstra Cc: Ingo Molnar --- kernel/early_res.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/kernel/early_res.c b/kernel/early_res.c index 3cb2c66..31aa933 100644 --- a/kernel/early_res.c +++ b/kernel/early_res.c @@ -333,6 +333,12 @@ void __init free_early_partial(u64 start, u64 end) struct early_res *r; int i; + if (start == end) + return; + + if (WARN_ONCE(start > end, " wrong range [%#llx, %#llx]\n", start, end)) + return; + try_next: i = find_overlapped_early(start, end); if (i >= max_early_res) -- 1.6.4.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcsinet11.oracle.com ([148.87.113.123]:19546 "EHLO rcsinet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755946Ab0C2Cq6 (ORCPT ); Sun, 28 Mar 2010 22:46:58 -0400 From: Yinghai Lu Subject: [PATCH 03/31] x86: Do not free zero sized per cpu areas Date: Sun, 28 Mar 2010 19:42:56 -0700 Message-ID: <1269830604-26214-4-git-send-email-yinghai@kernel.org> In-Reply-To: <1269830604-26214-1-git-send-email-yinghai@kernel.org> References: <1269830604-26214-1-git-send-email-yinghai@kernel.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , David Miller , Benjamin Herrenschmidt , Linus Torvalds Cc: Johannes Weiner , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Ian Campbell , Yinghai Lu , Peter Zijlstra Message-ID: <20100329024256.aRvKvU41bqqQq6dgIrOxQhHC31PUm58zjnfoEAUpzvo@z> From: Ian Campbell This avoids an infinite loop in free_early_partial(). Add a warning to free_early_partial to catch future problems. -v5: put back start > end back into WARN_ONCE() -v6: use one line for warning according to linus -v7: more test by -v8: remove the function name according to Johannes WARN_ONCE will print that function name. Signed-off-by: Ian Campbell Signed-off-by: Yinghai Lu Tested-by: Konrad Rzeszutek Wilk Tested-by: Joel Becker Tested-by: Stanislaw Gruszka Acked-by: Johannes Weiner Cc: Peter Zijlstra Cc: Ingo Molnar --- kernel/early_res.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/kernel/early_res.c b/kernel/early_res.c index 3cb2c66..31aa933 100644 --- a/kernel/early_res.c +++ b/kernel/early_res.c @@ -333,6 +333,12 @@ void __init free_early_partial(u64 start, u64 end) struct early_res *r; int i; + if (start == end) + return; + + if (WARN_ONCE(start > end, " wrong range [%#llx, %#llx]\n", start, end)) + return; + try_next: i = find_overlapped_early(start, end); if (i >= max_early_res) -- 1.6.4.2