From: Peter Zijlstra <peterz@infradead.org>
To: David Miller <davem@davemloft.net>
Cc: mingo@elte.hu, acme@redhat.com, paulus@samba.org, efault@gmx.de,
fweisbec@gmail.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/2] sparc64: Implement local_irq_save_nmi().
Date: Wed, 07 Apr 2010 08:52:26 +0200 [thread overview]
Message-ID: <1270623146.5109.532.camel@twins> (raw)
In-Reply-To: <20100406.163955.28809295.davem@davemloft.net>
On Tue, 2010-04-06 at 16:39 -0700, David Miller wrote:
> It disables up to PIL_NMI instead of just PIL_NORMAL_MAX.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> diff --git a/arch/sparc/include/asm/irqflags_64.h b/arch/sparc/include/asm/irqflags_64.h
> index 8b49bf9..fa1e00e 100644
> --- a/arch/sparc/include/asm/irqflags_64.h
> +++ b/arch/sparc/include/asm/irqflags_64.h
> @@ -49,6 +49,16 @@ static inline void raw_local_irq_disable(void)
> );
> }
>
> +static inline void raw_local_irq_disable_nmi(void)
> +{
> + __asm__ __volatile__(
> + "wrpr %0, %%pil"
> + : /* no outputs */
> + : "i" (PIL_NMI)
> + : "memory"
> + );
> +}
> +
Isn't this wrong when used from !NMI context?
Should this thing do something like:
if (rdpr() < PIL_NORMAL_MAX)
wrpr(PIL_NORMAL_MAX);
so that it only disables IRQs, but doesn't enable NMIs.
next prev parent reply other threads:[~2010-04-07 6:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 23:39 [PATCH 1/2] sparc64: Implement local_irq_save_nmi() David Miller
2010-04-06 23:39 ` David Miller
2010-04-07 6:52 ` Peter Zijlstra [this message]
2010-04-07 6:52 ` Peter Zijlstra
2010-04-07 7:06 ` David Miller
2010-04-07 7:24 ` Peter Zijlstra
2010-04-07 7:24 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270623146.5109.532.camel@twins \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=davem@davemloft.net \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox