From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yinghai <yinghai.lu@oracle.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 18/39] lmb: Add lmb_reserve_area_overlap_ok()
Date: Tue, 13 Apr 2010 15:10:50 +1000 [thread overview]
Message-ID: <1271135450.13059.72.camel@pasglop> (raw)
In-Reply-To: <4BC3F6C8.4020303@oracle.com>
On Mon, 2010-04-12 at 21:44 -0700, Yinghai wrote:
> that is only for some special cases about area that is reserved for fw region.
And ? From what I can see in the code, it will still not work properly
unless all your special cases end up fitting right with the bug you
effectively have..
> and even there is overlapped area, it the code still can go through when lmb_to_bootmem or create range list for slab.
> because they are using range array subtract.
Well, either we just have overlapped areas or we don't ... we shouldn't
have some kind of overlap_ok() thing that does the right thing ..
sometimes, but maybe not, but we don't care anyways, which is what you
seem to be saying.
> > Besides, lmb_reserve_area_overlap_ok() sucks as a name :-)
>
> any suggestion for better name?
Well, what you actually implemented is
lmb_reserve_area_overlap_maybe_ok_not_too_sure_though()
What we should decide is once for all, is it ok to have lmb_reserve() be
called for overlapping ranges. I think the answer is yes and in fact, we
don't take special care in powerpc either there so overlap could happen
in theory.
Now, do we want to avoid actually creating overlapping regions in the
array ? I think we should look into it, but then we should fix
lmb_reserve() to do the right thing here and coalesce all the overlaps.
Cheers,
Ben.
> YH
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2010-04-13 5:12 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 6:03 [PATCH -v12 00/39] use lmb with x86 Yinghai Lu
2010-04-09 6:03 ` [PATCH 01/39] swiotlb: Use page alignment for early buffer allocation Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-09 6:03 ` [PATCH 02/39] x86: Add sanitize_e820_map() Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-09 6:03 ` [PATCH 03/39] x86: Align e820 ram range to page Yinghai Lu
2010-04-09 6:03 ` [PATCH 04/39] lmb: Move lmb.c to mm/ Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-13 3:52 ` Benjamin Herrenschmidt
2010-04-09 6:03 ` [PATCH 05/39] lmb: Seperate region array from lmb_region struct Yinghai Lu
2010-04-13 3:56 ` Benjamin Herrenschmidt
2010-04-09 6:03 ` [PATCH 06/39] lmb: Seperate __lmb_find_base() from __lmb_alloc_base() Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-13 3:58 ` Benjamin Herrenschmidt
2010-04-13 4:31 ` Yinghai
2010-04-09 6:03 ` [PATCH 07/39] lmb: Add lmb_find_area() Yinghai Lu
2010-04-13 4:05 ` Benjamin Herrenschmidt
2010-04-13 4:29 ` Yinghai
2010-04-13 5:07 ` Benjamin Herrenschmidt
2010-04-13 5:26 ` Yinghai
2010-04-13 5:46 ` H. Peter Anvin
2010-04-13 10:15 ` Benjamin Herrenschmidt
2010-04-09 6:03 ` [PATCH 08/39] lmb: Add lmb_reserve_area/lmb_free_area Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-13 4:15 ` Benjamin Herrenschmidt
2010-04-09 6:03 ` [PATCH 09/39] bootmem, x86: Add weak version of reserve_bootmem_generic Yinghai Lu
2010-04-09 6:03 ` [PATCH 10/39] lmb: Add lmb_to_bootmem() Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-09 6:03 ` [PATCH 11/39] lmb: Add get_free_all_memory_range() Yinghai Lu
2010-04-09 6:03 ` [PATCH 12/39] lmb: Add lmb_register_active_regions() and lmb_hole_size() Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-09 6:03 ` [PATCH 13/39] lmb: Prepare to include linux/lmb.h in core file Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-09 6:03 ` [PATCH 14/39] lmb: Add find_memory_core_early() Yinghai Lu
2010-04-09 6:03 ` [PATCH 15/39] lmb: Add lmb_find_area_node() Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-13 4:18 ` Benjamin Herrenschmidt
2010-04-13 4:37 ` Yinghai
2010-04-09 6:03 ` [PATCH 16/39] lmb: Add lmb_free_memory_size() Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-09 6:03 ` [PATCH 17/39] lmb: Add lmb_memory_size() Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-09 6:03 ` [PATCH 18/39] lmb: Add lmb_reserve_area_overlap_ok() Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-13 4:21 ` Benjamin Herrenschmidt
2010-04-13 4:44 ` Yinghai
2010-04-13 5:10 ` Benjamin Herrenschmidt [this message]
2010-04-13 5:37 ` Yinghai
2010-04-13 5:37 ` Yinghai
2010-04-09 6:03 ` [PATCH 19/39] lmb: Use lmb_debug to control debug message print out Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-09 6:03 ` [PATCH 20/39] lmb: Add ARCH_DISCARD_LMB to put lmb code to .init Yinghai Lu
2010-04-09 6:03 ` [PATCH 21/39] lmb: Add __free/__reserve/__clear_lmb_reserved_region_array() Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-09 6:03 ` [PATCH 22/39] x86, lmb: Add lmb_find_area_size() Yinghai Lu
2010-04-09 6:03 ` [PATCH 23/39] x86, lmb: Add x86 version of __lmb_find_area() Yinghai Lu
2010-04-09 6:03 ` [PATCH 24/39] x86: Use lmb to replace early_res Yinghai Lu
2010-04-09 6:03 ` [PATCH 25/39] x86: Replace e820_/_early string with lmb_ Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-09 6:03 ` [PATCH 26/39] nobootmem: use lmb.default_alloc_limit in alloc_bootmem path Yinghai Lu
2010-04-13 4:23 ` Benjamin Herrenschmidt
2010-04-13 4:50 ` Yinghai
2010-04-13 5:13 ` Benjamin Herrenschmidt
2010-04-13 5:42 ` Yinghai
2010-04-09 6:03 ` [PATCH 27/39] x86, lmb: turn off ARCH_LMB_FIND_AREA Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-09 6:03 ` [PATCH 28/39] x86: Remove not used early_res code Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-09 6:03 ` [PATCH 29/39] x86, lmb: Use lmb_memory_size()/lmb_free_memory_size() to get correct dma_reserve Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-09 6:03 ` [PATCH 30/39] x86: put 64 bit numa node memmap above 16M Yinghai Lu
2010-04-09 6:03 ` Yinghai Lu
2010-04-09 6:04 ` [PATCH 31/39] x86: Use wake_system_ram_range() instead of e820_any_mapped() in agp path Yinghai Lu
2010-04-09 6:04 ` Yinghai Lu
2010-04-09 6:04 ` [PATCH 32/39] x86: Add get_centaur_ram_top() Yinghai Lu
2010-04-09 6:04 ` Yinghai Lu
2010-04-09 6:04 ` [PATCH 33/39] x86: Change e820_any_mapped() to __init Yinghai Lu
2010-04-09 6:04 ` Yinghai Lu
2010-04-09 6:04 ` [PATCH 34/39] x86: Use walk_system_ream_range() instead of referring e820.map directly for tboot Yinghai Lu
2010-04-09 6:04 ` Yinghai Lu
2010-04-09 6:04 ` [PATCH 35/39] x86: make e820 to be __initdata Yinghai Lu
2010-04-09 6:04 ` Yinghai Lu
2010-04-09 6:04 ` [PATCH 36/39] bootmem: Add nobootmem.c to reduce the #ifdef Yinghai Lu
2010-04-09 6:04 ` Yinghai Lu
2010-04-09 6:04 ` [PATCH 37/39] mm: move contig_page_data define to bootmem.c/nobootmem.c Yinghai Lu
2010-04-09 6:04 ` [PATCH 38/39] lmb: move __alloc_memory_core_early() to nobootmem.c Yinghai Lu
2010-04-09 6:04 ` Yinghai Lu
2010-04-09 6:04 ` [PATCH 39/39] x86: have nobootmem version setup_bootmem_allocator() Yinghai Lu
2010-04-09 6:04 ` Yinghai Lu
2010-04-13 3:41 ` [PATCH -v12 00/39] use lmb with x86 Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271135450.13059.72.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=hannes@cmpxchg.org \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai.lu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).