From: Yinghai Lu <yinghai@kernel.org>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: David Miller <davem@davemloft.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH 06/22] bootmem, x86: Add weak version of reserve_bootmem_generic
Date: Sat, 8 May 2010 08:17:24 -0700 [thread overview]
Message-ID: <1273331860-14325-7-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1273331860-14325-1-git-send-email-yinghai@kernel.org>
It will be used lmb_to_bootmem converting
It is an wrapper for reserve_bootmem, and x86 64bit is using special one.
Also clean up that version for x86_64. We don't need to take care of numa
path for that, bootmem can handle it how
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
arch/x86/mm/init_32.c | 6 ------
arch/x86/mm/init_64.c | 20 ++------------------
mm/bootmem.c | 6 ++++++
3 files changed, 8 insertions(+), 24 deletions(-)
diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
index bca7909..90e0545 100644
--- a/arch/x86/mm/init_32.c
+++ b/arch/x86/mm/init_32.c
@@ -1069,9 +1069,3 @@ void mark_rodata_ro(void)
#endif
}
#endif
-
-int __init reserve_bootmem_generic(unsigned long phys, unsigned long len,
- int flags)
-{
- return reserve_bootmem(phys, len, flags);
-}
diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index ee41bba..634fa08 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -799,13 +799,10 @@ void mark_rodata_ro(void)
#endif
+#ifndef CONFIG_NO_BOOTMEM
int __init reserve_bootmem_generic(unsigned long phys, unsigned long len,
int flags)
{
-#ifdef CONFIG_NUMA
- int nid, next_nid;
- int ret;
-#endif
unsigned long pfn = phys >> PAGE_SHIFT;
if (pfn >= max_pfn) {
@@ -821,21 +818,7 @@ int __init reserve_bootmem_generic(unsigned long phys, unsigned long len,
return -EFAULT;
}
- /* Should check here against the e820 map to avoid double free */
-#ifdef CONFIG_NUMA
- nid = phys_to_nid(phys);
- next_nid = phys_to_nid(phys + len - 1);
- if (nid == next_nid)
- ret = reserve_bootmem_node(NODE_DATA(nid), phys, len, flags);
- else
- ret = reserve_bootmem(phys, len, flags);
-
- if (ret != 0)
- return ret;
-
-#else
reserve_bootmem(phys, len, flags);
-#endif
if (phys+len <= MAX_DMA_PFN*PAGE_SIZE) {
dma_reserve += len / PAGE_SIZE;
@@ -844,6 +827,7 @@ int __init reserve_bootmem_generic(unsigned long phys, unsigned long len,
return 0;
}
+#endif
int kern_addr_valid(unsigned long addr)
{
diff --git a/mm/bootmem.c b/mm/bootmem.c
index 58c66cc..ee31b95 100644
--- a/mm/bootmem.c
+++ b/mm/bootmem.c
@@ -526,6 +526,12 @@ int __init reserve_bootmem(unsigned long addr, unsigned long size,
}
#ifndef CONFIG_NO_BOOTMEM
+int __weak __init reserve_bootmem_generic(unsigned long phys, unsigned long len,
+ int flags)
+{
+ return reserve_bootmem(phys, len, flags);
+}
+
static unsigned long __init align_idx(struct bootmem_data *bdata,
unsigned long idx, unsigned long step)
{
--
1.6.4.2
next prev parent reply other threads:[~2010-05-08 15:20 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-08 15:17 [PATCH -v14 00/22] Use lmb with x86 Yinghai Lu
2010-05-08 15:17 ` Yinghai Lu
2010-05-08 15:17 ` [PATCH 01/22] lmb: Move lmb.c to mm/ Yinghai Lu
2010-05-08 15:17 ` [PATCH 02/22] lmb: Seperate region array from lmb_region struct Yinghai Lu
2010-05-08 15:17 ` Yinghai Lu
2010-05-08 15:17 ` [PATCH 03/22] lmb: Seperate __lmb_find_base() from __lmb_alloc_base() Yinghai Lu
2010-05-08 15:17 ` [PATCH 04/22] lmb: Add lmb_find_area() Yinghai Lu
2010-05-08 15:17 ` [PATCH 05/22] lmb: Add lmb_reserve_area/lmb_free_area Yinghai Lu
2010-05-10 7:10 ` Benjamin Herrenschmidt
2010-05-10 18:09 ` Yinghai
2010-05-10 21:44 ` H. Peter Anvin
2010-05-10 21:53 ` Benjamin Herrenschmidt
2010-05-08 15:17 ` Yinghai Lu [this message]
2010-05-08 15:17 ` [PATCH 07/22] lmb: Add lmb_to_bootmem() Yinghai Lu
2010-05-08 15:17 ` Yinghai Lu
2010-05-10 3:13 ` Benjamin Herrenschmidt
2010-05-10 4:31 ` Yinghai
2010-05-12 0:03 ` Benjamin Herrenschmidt
2010-05-12 0:50 ` yinghai.lu
2010-05-08 15:17 ` [PATCH 08/22] lmb: Add get_free_all_memory_range() Yinghai Lu
2010-05-10 4:04 ` Benjamin Herrenschmidt
2010-05-10 4:04 ` Benjamin Herrenschmidt
2010-05-10 7:29 ` Benjamin Herrenschmidt
2010-05-08 15:17 ` [PATCH 09/22] lmb: Add lmb_register_active_regions() and lmb_hole_size() Yinghai Lu
2010-05-08 15:17 ` Yinghai Lu
2010-05-08 15:17 ` [PATCH 10/22] lmb: Prepare to include linux/lmb.h in core file Yinghai Lu
2010-05-08 15:17 ` [PATCH 11/22] lmb: Add find_memory_core_early() Yinghai Lu
2010-05-08 15:17 ` [PATCH 12/22] lmb: Add lmb_find_area_node() Yinghai Lu
2010-05-10 6:23 ` Benjamin Herrenschmidt
2010-05-10 6:23 ` Benjamin Herrenschmidt
2010-05-08 15:17 ` [PATCH 13/22] lmb: Add lmb_free_memory_size() Yinghai Lu
2010-05-08 15:17 ` Yinghai Lu
2010-05-10 6:24 ` Benjamin Herrenschmidt
2010-05-08 15:17 ` [PATCH 14/22] lmb: Add lmb_memory_size() Yinghai Lu
2010-05-10 6:25 ` Benjamin Herrenschmidt
2010-05-08 15:17 ` [PATCH 15/22] lmb: Add lmb_reserve_area_overlap_ok() Yinghai Lu
2010-05-08 15:17 ` Yinghai Lu
2010-05-10 6:34 ` Benjamin Herrenschmidt
2010-05-08 15:17 ` [PATCH 16/22] lmb: Use lmb_debug to control debug message print out Yinghai Lu
2010-05-08 15:17 ` Yinghai Lu
2010-05-08 15:17 ` [PATCH 17/22] lmb: Add ARCH_DISCARD_LMB to put lmb code to .init Yinghai Lu
2010-05-08 15:17 ` Yinghai Lu
2010-05-10 6:16 ` Benjamin Herrenschmidt
2010-05-08 15:17 ` [PATCH 18/22] lmb: Add __free/__reserve/__clear_lmb_reserved_region_array() Yinghai Lu
2010-05-08 15:17 ` Yinghai Lu
2010-05-10 6:18 ` Benjamin Herrenschmidt
2010-05-08 15:17 ` [PATCH 19/22] x86, lmb: Add lmb_find_area_size() Yinghai Lu
2010-05-08 15:17 ` Yinghai Lu
2010-05-08 15:17 ` [PATCH 20/22] x86: Use lmb to replace early_res Yinghai Lu
2010-05-08 15:17 ` Yinghai Lu
2010-05-08 15:17 ` [PATCH 21/22] x86: Replace e820_/_early string with lmb_ Yinghai Lu
2010-05-08 15:17 ` Yinghai Lu
2010-05-08 15:17 ` [PATCH 22/22] x86: Remove not used early_res code Yinghai Lu
2010-05-10 2:38 ` [PATCH -v14 00/22] Use lmb with x86 Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273331860-14325-7-git-send-email-yinghai@kernel.org \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=hannes@cmpxchg.org \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).