From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Tim Abbott <tabbott@ksplice.com>
Cc: Matt Fleming <matt@console-pimps.org>,
linux-arch@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
Michal Marek <mmarek@suse.cz>,
Denys Vlasenko <vda.linux@googlemail.com>,
linux-parisc@vger.kernel.org
Subject: Re: [PATCH 1/5] vmlinux.lds.h: Include *(.text.*) in TEXT_TEXT
Date: Mon, 14 Jun 2010 18:14:59 -0500 [thread overview]
Message-ID: <1276557299.5374.847.camel@mulgrave.site> (raw)
In-Reply-To: <alpine.DEB.1.10.1006141534490.1248@dr-wily.mit.edu>
On Mon, 2010-06-14 at 18:21 -0400, Tim Abbott wrote:
> On Mon, 14 Jun 2010, Matt Fleming wrote:
>
> > Do these special kernel sections include things like the parisc
> > .text.do_softirq, .text.sys_exit, etc? James raised a good objection to
> > the parisc patch of this series. I'm guessing most people saw it already
> > but I'll paste it here for reference,
> >
> > This would destroy all of the named parisc text ordering we do above the
> > removed line because now you'd have swept up all the function sections
> > before we get to them, won't it?
> >
> > The ordering is an execution speed up on 32 bit systems because our
> > relative jump is so short.
> >
> > Will you changes handle this OK?
>
> I think I addressed this in my reply to James just now, but to be super
> clear, this -ffunction-sections plan involves renaming .text.do_softirq to
> .text..do_softirq (etc.) first.
OK, so that doesn't make a lot of sense to me; I suspect because you
don't understand what parisc is doing. These aren't names of linux
special sections ... they're names of function sections. For
efficiency, we take specific hot functions and place them together in
the linker script so the jumps between them are small enough to be coded
as relative on the 32 bit architecture. It's really just a more
efficient way of laying out the binary.
James
next prev parent reply other threads:[~2010-06-14 23:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 12:38 [PATCH 1/5] vmlinux.lds.h: Include *(.text.*) in TEXT_TEXT Matt Fleming
2010-06-14 12:38 ` Matt Fleming
2010-06-14 12:38 ` [PATCH 2/5] blackfin: Remove *(.text.*) pattern from the linker script Matt Fleming
2010-06-14 12:38 ` Matt Fleming
2010-06-14 19:58 ` Mike Frysinger
2010-06-14 12:38 ` [PATCH 3/5] mips: " Matt Fleming
2010-06-14 12:38 ` Matt Fleming
2010-06-14 12:38 ` [PATCH 4/5] parisc: " Matt Fleming
2010-06-14 12:38 ` Matt Fleming
2010-06-14 15:20 ` James Bottomley
2010-06-14 19:13 ` Matt Fleming
2010-06-14 12:38 ` [PATCH 5/5] score: " Matt Fleming
2010-06-14 12:38 ` Matt Fleming
2010-06-14 14:32 ` [PATCH 1/5] vmlinux.lds.h: Include *(.text.*) in TEXT_TEXT Tim Abbott
2010-06-14 19:33 ` Matt Fleming
2010-06-14 20:05 ` James Bottomley
2010-06-14 22:02 ` Tim Abbott
2010-06-14 23:08 ` James Bottomley
2010-06-15 2:45 ` Tim Abbott
2010-06-15 2:45 ` Tim Abbott
2010-06-16 21:40 ` James Bottomley
2010-06-16 21:40 ` James Bottomley
2010-06-17 19:11 ` Denys Vlasenko
2010-06-17 19:56 ` James Bottomley
2010-06-17 20:19 ` Denys Vlasenko
2010-06-17 20:19 ` Denys Vlasenko
2010-06-17 20:38 ` James Bottomley
2010-06-17 18:54 ` Denys Vlasenko
2010-06-14 22:21 ` Tim Abbott
2010-06-14 23:14 ` James Bottomley [this message]
2010-06-15 2:52 ` Tim Abbott
2010-06-15 2:52 ` Tim Abbott
2010-06-14 18:22 ` Sam Ravnborg
2010-06-14 18:22 ` Sam Ravnborg
2010-06-14 19:21 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276557299.5374.847.camel@mulgrave.site \
--to=james.bottomley@hansenpartnership.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mmarek@suse.cz \
--cc=sam@ravnborg.org \
--cc=tabbott@ksplice.com \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).