public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Miller <davem@davemloft.net>,
	Be
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH 01/23] lmb: lmb_find_base() should return LMB_ERROR on failing path
Date: Sat,  3 Jul 2010 23:56:05 -0700	[thread overview]
Message-ID: <1278226587-31213-2-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1278226587-31213-1-git-send-email-yinghai@kernel.org>

all callees assume it return LMB_ERROR when it fail to find a range

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
 lib/lmb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/lmb.c b/lib/lmb.c
index 2421b2a..13d1a04 100644
--- a/lib/lmb.c
+++ b/lib/lmb.c
@@ -154,7 +154,7 @@ static phys_addr_t __init lmb_find_base(phys_addr_t size, phys_addr_t align,
 		if (found != LMB_ERROR)
 			return found;
 	}
-	return 0;
+	return LMB_ERROR;
 }
 
 static void lmb_remove_region(struct lmb_type *type, unsigned long r)
-- 
1.6.4.2

WARNING: multiple messages have this Message-ID (diff)
From: Yinghai Lu <yinghai@kernel.org>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Miller <davem@davemloft.net>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH 01/23] lmb: lmb_find_base() should return LMB_ERROR on failing path
Date: Sat,  3 Jul 2010 23:56:05 -0700	[thread overview]
Message-ID: <1278226587-31213-2-git-send-email-yinghai@kernel.org> (raw)
Message-ID: <20100704065605.vytrPUG3RcwT-uJe_PbZwp2YgldE4SULdej_zZQSUEk@z> (raw)
In-Reply-To: <1278226587-31213-1-git-send-email-yinghai@kernel.org>

all callees assume it return LMB_ERROR when it fail to find a range

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
 lib/lmb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/lmb.c b/lib/lmb.c
index 2421b2a..13d1a04 100644
--- a/lib/lmb.c
+++ b/lib/lmb.c
@@ -154,7 +154,7 @@ static phys_addr_t __init lmb_find_base(phys_addr_t size, phys_addr_t align,
 		if (found != LMB_ERROR)
 			return found;
 	}
-	return 0;
+	return LMB_ERROR;
 }
 
 static void lmb_remove_region(struct lmb_type *type, unsigned long r)
-- 
1.6.4.2


  parent reply	other threads:[~2010-07-04  6:59 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-04  6:56 [PATCH -v22 00/23] Use lmb with x86 Yinghai Lu
2010-07-04  6:56 ` Yinghai Lu
2010-07-04  6:56 ` Yinghai Lu [this message]
2010-07-04  6:56   ` [PATCH 01/23] lmb: lmb_find_base() should return LMB_ERROR on failing path Yinghai Lu
2010-07-04  6:56 ` [PATCH 02/23] lmb: Prepare x86 to use lmb to replace early_res Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 03/23] lmb: Print new doubled array location info Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-08 18:55   ` Bjorn Helgaas
2010-07-08 20:07     ` Yinghai Lu
2010-07-09  6:19       ` Benjamin Herrenschmidt
2010-07-09  6:19         ` Benjamin Herrenschmidt
2010-07-04  6:56 ` [PATCH 04/23] lmb: Export LMB_ERROR again Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 05/23] lmb: Prepare to include linux/lmb.h in core file Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 06/23] lmb: Add ARCH_DISCARD_LMB to put lmb code to .init Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 07/23] lmb: Add lmb_find_in_range() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 08/23] x86, lmb: Add lmb_x86_find_in_range_size() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 09/23] bootmem, x86: Add weak version of reserve_bootmem_generic Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 10/23] x86, lmb: Add lmb_x86_to_bootmem() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 11/23] x86,lmb: Add lmb_x86_reserve_range/lmb_x86_free_range Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 12/23] x86, lmb: Add get_free_all_memory_range() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 13/23] x86, lmb: Add lmb_x86_register_active_regions() and lmb_x86_hole_size() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 14/23] lmb: Add find_memory_core_early() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 15/23] x86, lmb: Add lmb_x86_find_in_range_node() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 16/23] x86, lmb: Add lmb_x86_free_memory_in_range() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 17/23] x86, lmb: Add lmb_x86_memory_in_range() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 18/23] x86, lmb: Use lmb_debug to control debug message print out Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 19/23] x86: Use lmb to replace early_res Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 20/23] x86: Replace e820_/_early string with lmb_ Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 21/23] x86: Remove not used early_res code Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 22/23] x86, lmb: Use lmb_memory_size()/lmb_free_memory_size() to get correct dma_reserve Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 23/23] x86: remove old bootmem code Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278226587-31213-2-git-send-email-yinghai@kernel.org \
    --to=yinghai@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=hannes@cmpxchg.org \
    --cc=hpa@zytor.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox