Generic Linux architectural discussions
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: David Miller <davem@davemloft.net>,
	mingo@elte.hu, hpa@zytor.com, tglx@linutronix.de,
	torvalds@linux-foundation.org, linux-arch@vger.kernel.org
Subject: Re: LMB bits
Date: Mon, 12 Jul 2010 13:24:41 +1000	[thread overview]
Message-ID: <1278905081.28659.157.camel@pasglop> (raw)
In-Reply-To: <4C38DDE3.9010303@kernel.org>

On Sat, 2010-07-10 at 13:53 -0700, Yinghai Lu wrote:

> Ben/David, 
> 
> can you fold in following patch in your patchset too?
> 
> also please use -v2 [PATCH] lmb: rename to memblock
> that is removing one wrong change with microblaze dts

Will do. I'm also fixing another bug David found. I'll have an updated
branch later today.

Cheers,
Ben.

> Thanks
> 
> Yinghai
> 
> 
> Subject: [PATCH] memblock: memblock_find_base() should return MEMBLOCK_ERROR on failing path
> 
> all callees assume it return MEMBLOCK_ERROR when it fail to find a range
> 
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> 
> ---
>  mm/memblock.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6/mm/memblock.c
> ===================================================================
> --- linux-2.6.orig/mm/memblock.c
> +++ linux-2.6/mm/memblock.c
> @@ -154,7 +154,7 @@ static phys_addr_t __init memblock_find_
>  		if (found != MEMBLOCK_ERROR)
>  			return found;
>  	}
> -	return 0;
> +	return MEMBLOCK_ERROR;
>  }
>  
>  static void memblock_remove_region(struct memblock_type *type, unsigned long r)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arch" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-07-12  3:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1278031351-23223-1-git-send-email-yinghai@kernel.org>
2010-07-09  7:11 ` LMB bits Benjamin Herrenschmidt
2010-07-09  7:24   ` Ingo Molnar
2010-07-09  7:28     ` David Miller
2010-07-09  7:33       ` Ingo Molnar
2010-07-09  8:24     ` Geert Uytterhoeven
2010-07-09 13:51       ` Ingo Molnar
2010-07-10  0:20     ` David Miller
2010-07-10  3:55       ` David Miller
2010-07-10 11:01         ` Benjamin Herrenschmidt
2010-07-10 20:14           ` David Miller
2010-07-10 20:53             ` Yinghai Lu
2010-07-12  3:24               ` Benjamin Herrenschmidt [this message]
2010-07-12  7:38                 ` Benjamin Herrenschmidt
2010-07-12 22:34                   ` David Miller
2010-07-13  7:12                     ` Benjamin Herrenschmidt
2010-07-13  8:54                       ` Ingo Molnar
2010-07-13 15:11                       ` Linus Torvalds
2010-07-13 16:45                         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278905081.28659.157.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=hpa@zytor.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox