From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Jan Beulich <jbeulich@novell.com>
Subject: Re: [PATCH 05/16] x86, memblock: Add get_free_all_memory_range()
Date: Wed, 28 Jul 2010 15:02:18 +1000 [thread overview]
Message-ID: <1280293338.1970.235.camel@pasglop> (raw)
In-Reply-To: <1279824241-17582-6-git-send-email-yinghai@kernel.org>
On Thu, 2010-07-22 at 11:43 -0700, Yinghai Lu wrote:
>
> + /* Take out region array itself at first*/
> + if (memblock.reserved.regions != memblock_reserved_init_regions)
> + memblock_free(__pa(memblock.reserved.regions), sizeof(struct memblock_region) * memblock.reserved.max);
> +
More of that horror. Don't.
Another option from what i proposed earlier is to actually have a function
inside mm/memblock to free it (memblock_free_arrays()) that does nothing
if memblock is to survive init.
I hate exporting variables or data structures like that. Functions are
semantically a lot cleaner.
Ben.
next prev parent reply other threads:[~2010-07-28 5:02 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 18:43 [PATCH -v26 00/16] Use memblock with x86 Yinghai Lu
2010-07-22 18:43 ` Yinghai Lu
2010-07-22 18:43 ` [PATCH 01/16] x86, memblock: Add memblock_x86_find_in_range_size() Yinghai Lu
2010-07-22 18:43 ` Yinghai Lu
2010-07-28 4:49 ` Benjamin Herrenschmidt
2010-07-22 18:43 ` [PATCH 02/16] bootmem, x86: Add weak version of reserve_bootmem_generic Yinghai Lu
2010-07-22 18:43 ` Yinghai Lu
2010-07-28 4:51 ` Benjamin Herrenschmidt
2010-07-22 18:43 ` [PATCH 03/16] x86, memblock: Add memblock_x86_to_bootmem() Yinghai Lu
2010-07-22 18:43 ` Yinghai Lu
2010-07-28 5:00 ` Benjamin Herrenschmidt
2010-07-28 5:40 ` Yinghai Lu
2010-07-22 18:43 ` [PATCH 04/16] x86,memblock: Add memblock_x86_reserve_range/memblock_x86_free_range Yinghai Lu
2010-07-22 18:43 ` Yinghai Lu
2010-07-22 18:43 ` [PATCH 05/16] x86, memblock: Add get_free_all_memory_range() Yinghai Lu
2010-07-22 18:43 ` Yinghai Lu
2010-07-28 5:02 ` Benjamin Herrenschmidt [this message]
2010-07-28 5:41 ` Yinghai Lu
2010-07-28 19:15 ` Yinghai Lu
2010-07-22 18:43 ` [PATCH 06/16] x86, memblock: Add memblock_x86_register_active_regions() and memblock_x86_hole_size() Yinghai Lu
2010-07-22 18:43 ` Yinghai Lu
2010-07-22 18:43 ` [PATCH 07/16] memblock: Add find_memory_core_early() Yinghai Lu
2010-07-22 18:43 ` Yinghai Lu
2010-07-22 18:43 ` [PATCH 08/16] x86, memblock: Add memblock_x86_find_in_range_node() Yinghai Lu
2010-07-22 18:43 ` Yinghai Lu
2010-07-22 18:43 ` [PATCH 09/16] x86, memblock: Add memblock_x86_free_memory_in_range() Yinghai Lu
2010-07-22 18:43 ` Yinghai Lu
2010-07-22 18:43 ` [PATCH 10/16] x86, memblock: Add memblock_x86_memory_in_range() Yinghai Lu
2010-07-22 18:43 ` Yinghai Lu
2010-07-22 18:43 ` [PATCH 11/16] x86, memblock: Use memblock_debug to control debug message print out Yinghai Lu
2010-07-22 18:43 ` Yinghai Lu
2010-07-22 18:43 ` [PATCH 12/16] x86: Use memblock to replace early_res Yinghai Lu
2010-07-22 18:43 ` Yinghai Lu
2010-07-22 18:43 ` [PATCH 13/16] x86: Replace e820_/_early string with memblock_ Yinghai Lu
2010-07-22 18:43 ` Yinghai Lu
2010-07-22 18:43 ` [PATCH 14/16] x86: Remove not used early_res code Yinghai Lu
2010-07-22 18:43 ` Yinghai Lu
2010-07-22 18:44 ` [PATCH 15/16] x86, memblock: Use memblock_memory_size()/memblock_free_memory_size() to get correct dma_reserve Yinghai Lu
2010-07-22 18:44 ` Yinghai Lu
2010-07-22 18:44 ` [PATCH 16/16] x86: remove old bootmem code Yinghai Lu
2010-07-22 18:44 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280293338.1970.235.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=hannes@cmpxchg.org \
--cc=hpa@zytor.com \
--cc=jbeulich@novell.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).