From mboxrd@z Thu Jan  1 00:00:00 1970
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 05/16] x86, memblock: Add get_free_all_memory_range()
Date: Wed, 28 Jul 2010 15:02:18 +1000
Message-ID: <1280293338.1970.235.camel@pasglop>
References: <1279824241-17582-1-git-send-email-yinghai@kernel.org>
	 <1279824241-17582-6-git-send-email-yinghai@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <linux-arch-owner@vger.kernel.org>
Received: from gate.crashing.org ([63.228.1.57]:56613 "EHLO gate.crashing.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750794Ab0G1FCy (ORCPT <rfc822;linux-arch@vger.kernel.org>);
	Wed, 28 Jul 2010 01:02:54 -0400
In-Reply-To: <1279824241-17582-6-git-send-email-yinghai@kernel.org>
Sender: linux-arch-owner@vger.kernel.org
List-ID: <linux-arch.vger.kernel.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>, Andrew Morton <akpm@linux-foundation.org>, David Miller <davem@davemloft.net>, Linus Torvalds <torvalds@linux-foundation.org>, Johannes Weiner <hannes@cmpxchg.org>, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Jan Beulich <jbeulich@novell.com>

On Thu, 2010-07-22 at 11:43 -0700, Yinghai Lu wrote:
> 
> +       /* Take out region array itself at first*/
> +       if (memblock.reserved.regions != memblock_reserved_init_regions)
> +               memblock_free(__pa(memblock.reserved.regions), sizeof(struct memblock_region) * memblock.reserved.max);
> +

More of that horror. Don't.

Another option from what i proposed earlier is to actually have a function
inside mm/memblock to free it (memblock_free_arrays()) that does nothing
if memblock is to survive init.

I hate exporting variables or data structures like that. Functions are
semantically a lot cleaner.

Ben.