From: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Al Viro <viro@ftp.linux.org.uk>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 2/6] avr32: get rid of useless args in signal.c before other work there
Date: Mon, 01 Nov 2010 09:08:39 +0100 [thread overview]
Message-ID: <1288598919.2843.22.camel@hcegtvedt> (raw)
In-Reply-To: <20101101080201.GZ19804@ZenIV.linux.org.uk>
On Mon, 2010-11-01 at 08:02 +0000, Al Viro wrote:
> On Mon, Nov 01, 2010 at 08:58:29AM +0100, Hans-Christian Egtvedt wrote:
> > On Tue, 2010-09-28 at 03:57 +0100, Al Viro wrote:
> > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> > > @@ -261,11 +261,12 @@ handle_signal(unsigned long sig, struct k_sigaction *ka, siginfo_t *info,
> > > * doesn't want to handle. Thus you cannot kill init even with a
> > > * SIGKILL even by mistake.
> > > */
> > > -int do_signal(struct pt_regs *regs, sigset_t *oldset, int syscall)
> > > +static void do_signal(struct pt_regs *regs, int syscall)
> > > {
> > > siginfo_t info;
> > > int signr;
> > > struct k_sigaction ka;
> > > + sigset_t *oldset;
> >
> > Should be initialized as it is checked in the else if block further
> > below.
>
> That else if should be simply else...
Ah, that made a lot more sense. I'm still on my first cup of coffee
brushing dust of your series.
--
Hans-Christian Egtvedt
prev parent reply other threads:[~2010-11-01 8:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 2:57 [PATCH 2/6] avr32: get rid of useless args in signal.c before other work there Al Viro
2010-11-01 7:58 ` Hans-Christian Egtvedt
2010-11-01 8:02 ` Al Viro
2010-11-01 8:02 ` Al Viro
2010-11-01 8:08 ` Hans-Christian Egtvedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288598919.2843.22.camel@hcegtvedt \
--to=hans-christian.egtvedt@atmel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).