From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans-Christian Egtvedt Subject: Re: [PATCH 2/6] avr32: get rid of useless args in signal.c before other work there Date: Mon, 01 Nov 2010 09:08:39 +0100 Message-ID: <1288598919.2843.22.camel@hcegtvedt> References: <1288598309.2843.12.camel@hcegtvedt> <20101101080201.GZ19804@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from smtpeu1.atmel.com ([195.65.72.27]:64582 "EHLO bagnes.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754237Ab0KAIJW (ORCPT ); Mon, 1 Nov 2010 04:09:22 -0400 In-Reply-To: <20101101080201.GZ19804@ZenIV.linux.org.uk> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Al Viro Cc: Al Viro , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org On Mon, 2010-11-01 at 08:02 +0000, Al Viro wrote: > On Mon, Nov 01, 2010 at 08:58:29AM +0100, Hans-Christian Egtvedt wrote: > > On Tue, 2010-09-28 at 03:57 +0100, Al Viro wrote: > > > Signed-off-by: Al Viro > > > @@ -261,11 +261,12 @@ handle_signal(unsigned long sig, struct k_sigaction *ka, siginfo_t *info, > > > * doesn't want to handle. Thus you cannot kill init even with a > > > * SIGKILL even by mistake. > > > */ > > > -int do_signal(struct pt_regs *regs, sigset_t *oldset, int syscall) > > > +static void do_signal(struct pt_regs *regs, int syscall) > > > { > > > siginfo_t info; > > > int signr; > > > struct k_sigaction ka; > > > + sigset_t *oldset; > > > > Should be initialized as it is checked in the else if block further > > below. > > That else if should be simply else... Ah, that made a lot more sense. I'm still on my first cup of coffee brushing dust of your series. -- Hans-Christian Egtvedt