linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Roman Zippel <zippel@linux-m68k.org>,
	Andreas Schwab <schwab@linux-m68k.org>,
	linux-m68k@lists.linux-m68k.org
Subject: [PATCH v3 06/22] m68knommu: introduce little-endian bitops
Date: Tue, 23 Nov 2010 22:38:08 +0900	[thread overview]
Message-ID: <1290519504-3958-7-git-send-email-akinobu.mita@gmail.com> (raw)
In-Reply-To: <1290519504-3958-1-git-send-email-akinobu.mita@gmail.com>

Introduce little-endian bit operations by renaming native ext2 bit
operations. The ext2 bit operations are kept as wrapper macros using
little-endian bit operations to maintain bisectability until the
conversions are finished.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Acked-by: Greg Ungerer <gerg@uclinux.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Roman Zippel <zippel@linux-m68k.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
---
No change from previous submission
 arch/m68k/include/asm/bitops_no.h |   40 +++++++++++++++++++++++++++++-------
 1 files changed, 32 insertions(+), 8 deletions(-)

diff --git a/arch/m68k/include/asm/bitops_no.h b/arch/m68k/include/asm/bitops_no.h
index 292e1ce..9f5eb02 100644
--- a/arch/m68k/include/asm/bitops_no.h
+++ b/arch/m68k/include/asm/bitops_no.h
@@ -196,7 +196,15 @@ static __inline__ int __test_bit(int nr, const volatile unsigned long * addr)
 #include <asm-generic/bitops/hweight.h>
 #include <asm-generic/bitops/lock.h>
 
-static __inline__ int ext2_set_bit(int nr, volatile void * addr)
+#define BITOP_LE_SWIZZLE	((BITS_PER_LONG-1) & ~0x7)
+
+#define __set_le_bit(nr, addr) \
+	__set_bit((nr) ^ BITOP_LE_SWIZZLE, (addr))
+
+#define __clear_le_bit(nr, addr) \
+	__clear_bit((nr) ^ BITOP_LE_SWIZZLE, (addr))
+
+static inline int __test_and_set_le_bit(int nr, volatile void *addr)
 {
 	char retval;
 
@@ -215,7 +223,7 @@ static __inline__ int ext2_set_bit(int nr, volatile void * addr)
 	return retval;
 }
 
-static __inline__ int ext2_clear_bit(int nr, volatile void * addr)
+static inline int __test_and_clear_le_bit(int nr, volatile void *addr)
 {
 	char retval;
 
@@ -238,7 +246,7 @@ static __inline__ int ext2_clear_bit(int nr, volatile void * addr)
 	({						\
 		int ret;				\
 		spin_lock(lock);			\
-		ret = ext2_set_bit((nr), (addr));	\
+		ret = __test_and_set_le_bit((nr), (addr));	\
 		spin_unlock(lock);			\
 		ret;					\
 	})
@@ -247,12 +255,12 @@ static __inline__ int ext2_clear_bit(int nr, volatile void * addr)
 	({						\
 		int ret;				\
 		spin_lock(lock);			\
-		ret = ext2_clear_bit((nr), (addr));	\
+		ret = __test_and_clear_le_bit((nr), (addr));	\
 		spin_unlock(lock);			\
 		ret;					\
 	})
 
-static __inline__ int ext2_test_bit(int nr, const volatile void * addr)
+static inline int test_le_bit(int nr, const volatile void *addr)
 {
 	char retval;
 
@@ -271,10 +279,10 @@ static __inline__ int ext2_test_bit(int nr, const volatile void * addr)
 	return retval;
 }
 
-#define ext2_find_first_zero_bit(addr, size) \
-        ext2_find_next_zero_bit((addr), (size), 0)
+#define find_first_zero_le_bit(addr, size)	\
+	find_next_zero_le_bit((addr), (size), 0)
 
-static __inline__ unsigned long ext2_find_next_zero_bit(void *addr, unsigned long size, unsigned long offset)
+static inline unsigned long find_next_zero_le_bit(void *addr, unsigned long size, unsigned long offset)
 {
 	unsigned long *p = ((unsigned long *) addr) + (offset >> 5);
 	unsigned long result = offset & ~31UL;
@@ -324,8 +332,24 @@ found_middle:
 	return result + ffz(__swab32(tmp));
 }
 
+#define ext2_set_bit(nr, addr)	\
+	__test_and_set_le_bit(nr, addr)
+
+#define ext2_clear_bit(nr, addr)	\
+	test_and_clear_le_bit(nr, addr)
+
+#define ext2_test_bit(nr, addr)	\
+	test_le_bit(nr, addr)
+
+#define ext2_find_first_zero_bit(addr, size) \
+	find_first_zero_le_bit(addr, size)
+
+#define ext2_find_next_zero_bit(addr, size, offset)	\
+	find_next_zero_le_bit(addr, size, offset)
+
 #define ext2_find_next_bit(addr, size, off) \
 	find_next_le_bit((unsigned long *)(addr), (size), (off))
+
 #include <asm-generic/bitops/minix.h>
 
 #endif /* __KERNEL__ */
-- 
1.7.3.2

  parent reply	other threads:[~2010-11-23 13:38 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-23 13:38 [PATCH v3 00/22] Introduce little endian bitops Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 01/22] bitops: merge little and big endian definisions in asm-generic/bitops/le.h Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 02/22] bitops: rename generic little-endian bitops functions Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 03/22] s390: introduce little-endian bitops Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 04/22] arm: " Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 05/22] m68k: " Akinobu Mita
2010-11-23 13:38 ` Akinobu Mita [this message]
2010-11-23 13:38   ` [PATCH v3 06/22] m68knommu: " Akinobu Mita
2010-11-25  8:46   ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 07/22] bitops: introduce little-endian bitops for most architectures Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 08/22] rds: stop including asm-generic/bitops/le.h Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 09/22] kvm: " Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 10/22] asm-generic: use little-endian bitops Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 11/22] ext3: " Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 12/22] ext4: " Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 19:29   ` Ted Ts'o
2010-11-23 13:38 ` [PATCH v3 13/22] ocfs2: " Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 14/22] nilfs2: " Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 15/22] reiserfs: " Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 16/22] udf: " Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 17/22] ufs: " Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 18/22] md: use little-endian bit operations Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 19/22] dm: " Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 20/22] bitops: remove ext2 non-atomic bitops from asm/bitops.h Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 21/22] m68k: remove inline asm from minix_find_first_zero_bit Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 22/22] bitops: remove minix bitops from asm/bitops.h Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-24  5:55   ` Paul Mundt
2010-11-24 12:54   ` Ralf Baechle
2010-11-24 12:54     ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290519504-3958-7-git-send-email-akinobu.mita@gmail.com \
    --to=akinobu.mita@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=schwab@linux-m68k.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).