From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Cc: Akinobu Mita <akinobu.mita@gmail.com>, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH 1/2] bitops: use find_first_zero_bit() instead of find_next_zero_bit(addr, size, 0)
Date: Sat, 27 Nov 2010 01:28:38 +0900 [thread overview]
Message-ID: <1290788919-5057-2-git-send-email-akinobu.mita@gmail.com> (raw)
In-Reply-To: <1290788919-5057-1-git-send-email-akinobu.mita@gmail.com>
The little-endian bitops patch series introduced inefficiency to some
little-endian architectures.
include/asm-generic/bitops/le.h defines find_first_zero_le_bit() like this:
#define find_first_zero_le_bit(addr, size) \
find_next_zero_le_bit((addr), (size), 0)
All little-endian architectures include le.h and little-endian bitops
are just aliases for their native endian bitops. So above macro definision
is converted to:
#define find_first_zero_le_bit(addr, size) \
find_next_zero_bit(addr, size, 0)
This is inefficient for some architectures which have faster
find_first_zero_bit() than find_next_zero_bit(addr, size, 0).
Fix it by aliasing find_first_zero_bit() to find_first_zero_le_bit()
on little-endian architectures.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>
---
include/asm-generic/bitops/le.h | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/asm-generic/bitops/le.h b/include/asm-generic/bitops/le.h
index 6ad46ce..17a7119 100644
--- a/include/asm-generic/bitops/le.h
+++ b/include/asm-generic/bitops/le.h
@@ -12,6 +12,8 @@
find_next_zero_bit(addr, size, offset)
#define find_next_le_bit(addr, size, offset) \
find_next_bit(addr, size, offset)
+#define find_first_zero_le_bit(addr, size) \
+ find_first_zero_bit(addr, size)
#elif defined(__BIG_ENDIAN)
@@ -22,6 +24,9 @@ extern unsigned long find_next_zero_le_bit(const unsigned long *addr,
extern unsigned long find_next_le_bit(const unsigned long *addr,
unsigned long size, unsigned long offset);
+#define find_first_zero_le_bit(addr, size) \
+ find_next_zero_le_bit((addr), (size), 0)
+
#else
#error "Please fix <asm/byteorder.h>"
#endif
@@ -43,7 +48,4 @@ extern unsigned long find_next_le_bit(const unsigned long *addr,
#define __test_and_clear_le_bit(nr, addr) \
__test_and_clear_bit((nr) ^ BITOP_LE_SWIZZLE, (addr))
-#define find_first_zero_le_bit(addr, size) \
- find_next_zero_le_bit((addr), (size), 0)
-
#endif /* _ASM_GENERIC_BITOPS_LE_H_ */
--
1.7.3.2
next prev parent reply other threads:[~2010-11-26 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 16:28 [PATCH 0/2] little-endian bitops bugfixes Akinobu Mita
2010-11-26 16:28 ` Akinobu Mita [this message]
2010-11-26 16:28 ` [PATCH 2/2] bitops: introduce CONFIG_GENERIC_FIND_LE_BIT Akinobu Mita
2010-11-26 16:28 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290788919-5057-2-git-send-email-akinobu.mita@gmail.com \
--to=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).