From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>, Tejun Heo <tj@kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-arch@vger.kernel.org
Subject: Re: [PATCH v2 4/4] kthread: use kthread_create_on_cpu()
Date: Tue, 30 Nov 2010 10:59:01 +0100 [thread overview]
Message-ID: <1291111141.2904.17.camel@edumazet-laptop> (raw)
In-Reply-To: <15903.1291109892@redhat.com>
Le mardi 30 novembre 2010 à 09:38 +0000, David Howells a écrit :
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> > + p = kthread_create_on_cpu(run_ksoftirqd, hcpu, hotcpu,
> > + "ksoftirqd/%d", hotcpu);
>
> Does kthread_create_on_cpu() need to take hotcpu twice? Can one of the
> arguments be folded into the other?
>
> David
The second one is used in a printf() like to build a string, its not
really part of the API..
Caller could do instead :
char name[32];
sprintf(name, "ksoftirqd/%d", whatever_id);
p = kthread_create_on_cpu(run_ksoftirqd, hcpu, hotcpu, name);
prev parent reply other threads:[~2010-11-30 9:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1290972833.29196.90.camel@edumazet-laptop>
[not found] ` <20101128224024.GA12300@basil.fritz.box>
[not found] ` <1290984712.29196.100.camel@edumazet-laptop>
[not found] ` <20101128230146.GB12300@basil.fritz.box>
[not found] ` <1290987424.29196.128.camel@edumazet-laptop>
[not found] ` <20101129090510.GA15763@basil.fritz.box>
[not found] ` <1291023532.3435.29.camel@edumazet-laptop>
2010-11-29 15:13 ` [PATCH v2 0/4] kthread: NUMA aware kthread_create_on_cpu() Eric Dumazet
2010-11-29 16:09 ` Andi Kleen
2010-11-29 17:39 ` David Miller
2010-11-29 17:59 ` Eric Dumazet
2010-11-29 23:31 ` Rusty Russell
2010-11-29 15:14 ` [PATCH v2 2/4] mm: NUMA aware alloc_thread_info_node() Eric Dumazet
2010-11-29 15:15 ` [PATCH v2 4/4] kthread: use kthread_create_on_cpu() Eric Dumazet
2010-11-29 15:15 ` Eric Dumazet
2010-11-29 15:19 ` Tejun Heo
2010-11-29 15:19 ` Tejun Heo
2010-11-30 9:38 ` David Howells
2010-11-30 9:38 ` David Howells
2010-11-30 9:59 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291111141.2904.17.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).