From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Luck, Tony" <tony.luck@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-arch@vger.kernel.org
Subject: Re: ia64 broken by transparent huge pages - other arches too?
Date: Sat, 15 Jan 2011 18:21:36 +1100 [thread overview]
Message-ID: <1295076096.4875.60.camel@pasglop> (raw)
In-Reply-To: <4d308cf5394566ccc@agluck-desktop.sc.intel.com>
On Fri, 2011-01-14 at 09:50 -0800, Luck, Tony wrote:
> Didn't Andrew make some rash promise at kernel summit about stopping
> eating if "-mm" wasn't included in linux-next by the end of November?
>
> Must be getting pretty hungry by now.
>
> The transparent huge page code just arrived in the merge window
> without having been in linux-next. I see this error when trying
> to build for ia64 from Linus' tree this morning:
This is insane. Having such a massively invasive change to the whole mm,
barely tested on most architecture, and last I heard still generally
controversial being merged like that without even some integration
testing via -next makes no sense.
Linus, wtf is going on ?
Ben.
> In file included from /home/aegl/generic-smp/arch/ia64/include/asm/pgtable.h:611,
> from include/linux/mm.h:41,
> from /home/aegl/generic-smp/arch/ia64/include/asm/uaccess.h:39,
> from include/linux/poll.h:14,
> from include/linux/rtc.h:117,
> from include/linux/efi.h:19,
> from /home/aegl/generic-smp/arch/ia64/include/asm/sal.h:40,
> from /home/aegl/generic-smp/arch/ia64/include/asm/mca.h:20,
> from arch/ia64/kernel/asm-offsets.c:17:
> include/asm-generic/pgtable.h: In function ‘pmdp_get_and_clear’:
> include/asm-generic/pgtable.h:96: error: implicit declaration of function ‘__pmd’
> include/asm-generic/pgtable.h:96: error: incompatible types in return
> make[1]: *** [arch/ia64/kernel/asm-offsets.s] Error 1
>
>
> Looks like arch/*/include/pgtable.h needs to define __pmd() but only x86
> was blessed with it.
>
> -Tony
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2011-01-15 7:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 17:50 ia64 broken by transparent huge pages - other arches too? Luck, Tony
2011-01-14 17:50 ` Luck, Tony
2011-01-14 18:30 ` Andrea Arcangeli
2011-01-14 18:50 ` Tony Luck
2011-01-14 19:03 ` Andrea Arcangeli
2011-01-15 7:21 ` Benjamin Herrenschmidt [this message]
2011-01-15 15:59 ` Andrea Arcangeli
2011-01-15 16:47 ` James Bottomley
2011-01-15 17:23 ` Andrea Arcangeli
2011-01-15 19:02 ` Geert Uytterhoeven
2011-01-15 21:31 ` Benjamin Herrenschmidt
2011-01-16 21:05 ` Linus Torvalds
2011-01-16 21:10 ` Andrew Morton
2011-01-16 22:06 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295076096.4875.60.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).