From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-arch@vger.kernel.org
Subject: Link breakage on all architectures which implement their own show_mem
Date: Wed, 23 Mar 2011 11:41:46 -0500 [thread overview]
Message-ID: <1300898506.15899.24.camel@mulgrave.site> (raw)
This is the problem a lot of architectures will see:
Specifically this:
LD vmlinux.o
lib/lib.a(show_mem.o): In function `show_mem':
(.text.show_mem+0x0): multiple definition of `show_mem'
arch/parisc/mm/built-in.o:(.text.show_mem+0x0): first defined here
make: *** [vmlinux.o] Error 1
Caused by this patch:
commit ddd588b5dd55f14320379961e47683db4e4c1d90
Author: David Rientjes <rientjes@google.com>
Date: Tue Mar 22 16:30:46 2011 -0700
oom: suppress nodes that are not allowed from meminfo on oom kill
Is the cause. What it does is introduce a new __show_mem() which is
required by files in mm/, so the object containing it: show_mem.o gets
pulled in all the time in the link and that gives every architecture
that implements their own show_mem() a link failure because of the
double definition. Library linking works at the file level, not at the
function level. To work, you have to put these functions in separate
files.
James
next reply other threads:[~2011-03-23 16:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 16:41 James Bottomley [this message]
2011-03-24 22:21 ` Link breakage on all architectures which implement their own show_mem David Rientjes
2011-03-25 14:13 ` James Bottomley
2011-03-25 20:02 ` David Rientjes
2011-03-25 18:38 ` Josh Boyer
2011-03-25 10:55 ` Benjamin Herrenschmidt
2011-03-25 14:11 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300898506.15899.24.camel@mulgrave.site \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-arch@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).