From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 02/17] mm: mmu_gather rework Date: Fri, 01 Apr 2011 14:07:11 +0200 Message-ID: <1301659631.4859.565.camel@twins> References: <20110217162327.434629380@chello.nl> <20110217163234.823185666@chello.nl> <20110310155032.GB32302@csn.ul.ie> <1300301742.2203.1899.camel@twins> <4D87109A.1010005@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4D87109A.1010005@redhat.com> Sender: owner-linux-mm@kvack.org To: Avi Kivity Cc: Mel Gorman , Andrea Arcangeli , Thomas Gleixner , Rik van Riel , Ingo Molnar , akpm@linux-foundation.org, Linus Torvalds , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Benjamin Herrenschmidt , David Miller , Hugh Dickins , Nick Piggin , Paul McKenney , Yanmin Zhang , Martin Schwidefsky , Russell King , Paul Mundt , Jeff Dike , Tony Luck , Hugh Dickins List-Id: linux-arch.vger.kernel.org On Mon, 2011-03-21 at 10:47 +0200, Avi Kivity wrote: > On 03/16/2011 08:55 PM, Peter Zijlstra wrote: > > On Thu, 2011-03-10 at 15:50 +0000, Mel Gorman wrote: > > > > > > +static inline void > > > > +tlb_gather_mmu(struct mmu_gather *tlb, struct mm_struct *mm, uns= igned int full_mm_flush) > > > > { > > > > > > checkpatch will bitch about line length. > > > > I did a s/full_mm_flush/fullmm/ which puts the line length at 81. At > > which point I'll ignore it ;-) >=20 > How about s/unsigned int/bool/? IIRC you aren't a "bool was invented=20 > after 1971, therefore it is evil" type. No, although I do try to avoid it in structures because I'm ever unsure of the storage type used. But yes, good suggestion, thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from casper.infradead.org ([85.118.1.10]:43685 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752229Ab1DAMIX convert rfc822-to-8bit (ORCPT ); Fri, 1 Apr 2011 08:08:23 -0400 Subject: Re: [PATCH 02/17] mm: mmu_gather rework From: Peter Zijlstra In-Reply-To: <4D87109A.1010005@redhat.com> References: <20110217162327.434629380@chello.nl> <20110217163234.823185666@chello.nl> <20110310155032.GB32302@csn.ul.ie> <1300301742.2203.1899.camel@twins> <4D87109A.1010005@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Fri, 01 Apr 2011 14:07:11 +0200 Message-ID: <1301659631.4859.565.camel@twins> Mime-Version: 1.0 Sender: linux-arch-owner@vger.kernel.org List-ID: To: Avi Kivity Cc: Mel Gorman , Andrea Arcangeli , Thomas Gleixner , Rik van Riel , Ingo Molnar , akpm@linux-foundation.org, Linus Torvalds , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Benjamin Herrenschmidt , David Miller , Hugh Dickins , Nick Piggin , Paul McKenney , Yanmin Zhang , Martin Schwidefsky , Russell King , Paul Mundt , Jeff Dike , Tony Luck , Hugh Dickins Message-ID: <20110401120711.KmtJEK7uZfEIW35C8fnStDKL7S2qfoYCtvWgKL5ra0M@z> On Mon, 2011-03-21 at 10:47 +0200, Avi Kivity wrote: > On 03/16/2011 08:55 PM, Peter Zijlstra wrote: > > On Thu, 2011-03-10 at 15:50 +0000, Mel Gorman wrote: > > > > > > +static inline void > > > > +tlb_gather_mmu(struct mmu_gather *tlb, struct mm_struct *mm, unsigned int full_mm_flush) > > > > { > > > > > > checkpatch will bitch about line length. > > > > I did a s/full_mm_flush/fullmm/ which puts the line length at 81. At > > which point I'll ignore it ;-) > > How about s/unsigned int/bool/? IIRC you aren't a "bool was invented > after 1971, therefore it is evil" type. No, although I do try to avoid it in structures because I'm ever unsure of the storage type used. But yes, good suggestion, thanks!