From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Avi Kivity <avi@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
Rik van Riel <riel@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
David Miller <davem@davemloft.net>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
Mel Gorman <mel@csn.ul.ie>, Nick Piggin <npiggin@kernel.dk>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Yanmin Zhang <yanmin_zhang@linux.intel.com>
Subject: Re: [PATCH 13/20] lockdep, mutex: Provide mutex_lock_nest_lock
Date: Wed, 20 Apr 2011 13:03:56 +0200 [thread overview]
Message-ID: <1303297436.8345.158.camel@twins> (raw)
In-Reply-To: <20110419130654.95a14117.akpm@linux-foundation.org>
On Tue, 2011-04-19 at 13:06 -0700, Andrew Morton wrote:
> On Fri, 01 Apr 2011 14:13:11 +0200
> Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
>
> > Provide the mutex_lock_nest_lock() annotation.
>
> why?
>
> Neither the changelog nor the code provide any documentation for this addition to
> the lokdep API.
---
Subject: lockdep, mutex: Provide mutex_lock_nest_lock
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
Date: Fri, 26 Nov 2010 15:39:00 +0100
In order to convert i_mmap_lock to a mutex we need a mutex equivalent
to spin_lock_nest_lock(), thus provide the mutex_lock_nest_lock()
annotation.
As with spin_lock_nest_lock(), mutex_lock_nest_lock() allows
annotation of the locking pattern where an outer lock serializes the
acquisition order of nested locks. That is, if every time you lock
multiple locks A, say A1 and A2 you first acquire N, the order of
acquiring A1 and A2 is irrelevant.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Avi Kivity <avi@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
Rik van Riel <riel@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
David Miller <davem@davemloft.net>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
Mel Gorman <mel@csn.ul.ie>, Nick Piggin <npiggin@kernel.dk>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Yanmin Zhang <yanmin_zhang@linux.intel.com>
Subject: Re: [PATCH 13/20] lockdep, mutex: Provide mutex_lock_nest_lock
Date: Wed, 20 Apr 2011 13:03:56 +0200 [thread overview]
Message-ID: <1303297436.8345.158.camel@twins> (raw)
Message-ID: <20110420110356.DiE_EDX2PWqxeSRy9H1C75DWmORVRsTkcSS9K7kq3Lw@z> (raw)
In-Reply-To: <20110419130654.95a14117.akpm@linux-foundation.org>
On Tue, 2011-04-19 at 13:06 -0700, Andrew Morton wrote:
> On Fri, 01 Apr 2011 14:13:11 +0200
> Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
>
> > Provide the mutex_lock_nest_lock() annotation.
>
> why?
>
> Neither the changelog nor the code provide any documentation for this addition to
> the lokdep API.
---
Subject: lockdep, mutex: Provide mutex_lock_nest_lock
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
Date: Fri, 26 Nov 2010 15:39:00 +0100
In order to convert i_mmap_lock to a mutex we need a mutex equivalent
to spin_lock_nest_lock(), thus provide the mutex_lock_nest_lock()
annotation.
As with spin_lock_nest_lock(), mutex_lock_nest_lock() allows
annotation of the locking pattern where an outer lock serializes the
acquisition order of nested locks. That is, if every time you lock
multiple locks A, say A1 and A2 you first acquire N, the order of
acquiring A1 and A2 is irrelevant.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
next prev parent reply other threads:[~2011-04-20 11:03 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 12:12 [PATCH 00/20] mm: Preemptibility -v10 Peter Zijlstra
2011-04-01 12:12 ` Peter Zijlstra
2011-04-01 12:12 ` [PATCH 01/20] mm: mmu_gather rework Peter Zijlstra
2011-04-01 12:12 ` Peter Zijlstra
2011-04-19 20:06 ` Andrew Morton
2011-04-19 20:06 ` Andrew Morton
2011-04-20 8:47 ` Peter Zijlstra
2011-04-20 8:47 ` Peter Zijlstra
2011-04-20 9:10 ` Peter Zijlstra
2011-04-20 9:10 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 02/20] powerpc: " Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 03/20] sparc: " Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 04/20] s390: " Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 05/20] arm: " Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 06/20] sh: " Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 07/20] ia64: " Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 08/20] um: " Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 09/20] mm: Now that all old mmu_gather code is gone, remove the storage Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 10/20] mm, powerpc: Move the RCU page-table freeing into generic code Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 11/20] s390: use generic RCP page-table freeing Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 12/20] mm: Extended batches for generic mmu_gather Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-19 20:06 ` Andrew Morton
2011-04-19 20:06 ` Andrew Morton
2011-04-20 10:40 ` Peter Zijlstra
2011-04-20 10:40 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 13/20] lockdep, mutex: Provide mutex_lock_nest_lock Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-19 20:06 ` Andrew Morton
2011-04-19 20:06 ` Andrew Morton
2011-04-20 11:03 ` Peter Zijlstra [this message]
2011-04-20 11:03 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 14/20] mm: Remove i_mmap_lock lockbreak Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-19 20:07 ` Andrew Morton
2011-04-19 20:07 ` Andrew Morton
2011-04-21 13:32 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 15/20] mm: Convert i_mmap_lock to a mutex Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-19 20:07 ` Andrew Morton
2011-04-19 20:07 ` Andrew Morton
2011-04-21 13:28 ` Peter Zijlstra
2011-04-21 13:28 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 16/20] mm: Revert page_lock_anon_vma() lock annotation Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 17/20] mm: Improve page_lock_anon_vma() comment Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 18/20] mm: Use refcounts for page_lock_anon_vma() Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 19/20] mm: Convert anon_vma->lock to a mutex Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-19 20:07 ` Andrew Morton
2011-04-19 20:07 ` Andrew Morton
2011-04-21 13:28 ` Peter Zijlstra
2011-04-21 13:28 ` Peter Zijlstra
2011-04-01 12:13 ` [PATCH 20/20] mm: Optimize page_lock_anon_vma() fast-path Peter Zijlstra
2011-04-01 12:13 ` Peter Zijlstra
2011-04-19 20:08 ` Andrew Morton
2011-04-19 20:08 ` Andrew Morton
2011-04-20 12:38 ` Peter Zijlstra
2011-04-20 12:38 ` Peter Zijlstra
2011-04-20 15:00 ` Peter Zijlstra
2011-04-20 15:00 ` Peter Zijlstra
2011-04-01 13:51 ` [PATCH 00/20] mm: Preemptibility -v10 Peter Zijlstra
2011-04-01 13:51 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303297436.8345.158.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mingo@elte.hu \
--cc=npiggin@kernel.dk \
--cc=paulmck@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).