public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: David Rientjes <rientjes@google.com>
Cc: Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	Matthew Wilcox <matthew@wil.cx>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Michal Hocko <mhocko@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	Hugh Dickins <hughd@google.com>,
	linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
	linux-parisc@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	x86 maintainers <x86@kernel.org>,
	linux-arch@vger.kernel.org, Mel Gorman <mel@csn.ul.ie>
Subject: Re: [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards
Date: Thu, 21 Apr 2011 17:31:31 -0500	[thread overview]
Message-ID: <1303425091.4025.59.camel@mulgrave.site> (raw)
In-Reply-To: <alpine.DEB.2.00.1104211517150.20201@chino.kir.corp.google.com>

On Thu, 2011-04-21 at 15:19 -0700, David Rientjes wrote:
> On Thu, 21 Apr 2011, James Bottomley wrote:
> 
> > diff --git a/mm/slub.c b/mm/slub.c
> > index 94d2a33..243bd9c 100644
> > --- a/mm/slub.c
> > +++ b/mm/slub.c
> > @@ -235,7 +235,11 @@ int slab_is_available(void)
> >  
> >  static inline struct kmem_cache_node *get_node(struct kmem_cache *s, int node)
> >  {
> > +#ifdef CONFIG_NUMA
> >  	return s->node[node];
> > +#else
> > +	return s->node[0];
> > +#endif
> >  }
> >  
> >  /* Verify that a pointer has an address that is valid within a slab page */
> 
> Looks like parisc may have been just fine before 7340cc84141d (slub: 
> reduce differences between SMP and NUMA), which was merged into 2.6.37?

That's possible.  I've had no bug reports from the debian 2.6.32 kernel,
which is the only other one that has SLUB by default.  The m68k guys
seem to think this is the cause of their problems too.

But the basic fact is that all our testing has been done on SLAB.  It
wasn't until debian asked us to looks at a 2.6.38 kernel that I
accidentally picked up SLUB by importing their config into my build
environment.

James



  parent reply	other threads:[~2011-04-21 22:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20110420102314.4604.A69D9226@jp.fujitsu.com>
     [not found] ` <BANLkTi=mxWwLPEnB+rGg29b06xNUD0XvsA@mail.gmail.com>
     [not found]   ` <20110420161615.462D.A69D9226@jp.fujitsu.com>
     [not found]     ` <BANLkTimfpY3gq8oY6bPDajBW7JN6Hp+A0A@mail.gmail.com>
     [not found]       ` <20110420112020.GA31296@parisc-linux.org>
     [not found]         ` <BANLkTim+m-v-4k17HUSOYSbmNFDtJTgD6g@mail.gmail.com>
2011-04-20 14:15           ` [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards James Bottomley
2011-04-20 14:15             ` James Bottomley
2011-04-20 14:50             ` Christoph Lameter
2011-04-20 14:50               ` Christoph Lameter
2011-04-20 15:02               ` James Bottomley
2011-04-20 15:02                 ` James Bottomley
2011-04-20 15:22                 ` Christoph Lameter
2011-04-20 19:25                   ` Matthew Wilcox
2011-04-20 21:42                   ` David Rientjes
2011-04-20 21:42                     ` David Rientjes
2011-04-21 16:06                     ` James Bottomley
2011-04-21 22:19                       ` David Rientjes
2011-04-21 22:19                         ` David Rientjes
2011-04-21 22:31                         ` James Bottomley [this message]
2011-04-21 22:31                           ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1303425091.4025.59.camel@mulgrave.site \
    --to=james.bottomley@hansenpartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=hughd@google.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mel@csn.ul.ie \
    --cc=mhocko@suse.cz \
    --cc=mingo@elte.hu \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox