From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans-Christian Egtvedt Subject: Re: [PATCH 1/6] arch: add #define for each of optimized find bitops Date: Tue, 26 Apr 2011 14:23:20 +0200 Message-ID: <1303820600.3125.13.camel@hcegtvedt> References: <1303638677-11211-1-git-send-email-akinobu.mita@gmail.com> <1303638677-11211-2-git-send-email-akinobu.mita@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1303638677-11211-2-git-send-email-akinobu.mita@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Akinobu Mita Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, akpm@linux-foundation.org, arnd@arndb.de, Russell King , linux-arm-kernel@lists.infradead.org, Martin Schwidefsky , Heiko Carstens , linux390@de.ibm.com, linux-s390@vger.kernel.org, Geert Uytterhoeven , linux-m68k@vger.kernel.org, Greg Ungerer List-Id: linux-arch.vger.kernel.org On Sun, 2011-04-24 at 18:51 +0900, Akinobu Mita wrote: > The style that we normally use in asm-generic is to test the macro itself > for existence, so in asm-generic, do: > > #ifndef find_next_zero_bit_le > extern unsigned long find_next_zero_bit_le(const void *addr, > unsigned long size, unsigned long offset); > #endif > > and in the architectures, write > > static inline unsigned long find_next_zero_bit_le(const void *addr, > unsigned long size, unsigned long offset) > #define find_next_zero_bit_le find_next_zero_bit_le > > This adds the #define for each of the optimized find bitops in the > architectures. > > Suggested-by: Arnd Bergmann > Signed-off-by: Akinobu Mita > Cc: Russell King > Cc: linux-arm-kernel@lists.infradead.org > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: linux390@de.ibm.com > Cc: linux-s390@vger.kernel.org > Cc: Hans-Christian Egtvedt > Cc: Geert Uytterhoeven > Cc: linux-m68k@lists.linux-m68k.org > Cc: Greg Ungerer For the arch/avr32/include/asm/bitops.h changes. Acked-by: Hans-Christian Egtvedt -- Hans-Christian Egtvedt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newsmtp5.atmel.com ([204.2.163.5]:18627 "EHLO sjogate2.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754935Ab1DZM20 (ORCPT ); Tue, 26 Apr 2011 08:28:26 -0400 Subject: Re: [PATCH 1/6] arch: add #define for each of optimized find bitops From: Hans-Christian Egtvedt In-Reply-To: <1303638677-11211-2-git-send-email-akinobu.mita@gmail.com> References: <1303638677-11211-1-git-send-email-akinobu.mita@gmail.com> <1303638677-11211-2-git-send-email-akinobu.mita@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 26 Apr 2011 14:23:20 +0200 Message-ID: <1303820600.3125.13.camel@hcegtvedt> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Akinobu Mita Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, akpm@linux-foundation.org, arnd@arndb.de, Russell King , linux-arm-kernel@lists.infradead.org, Martin Schwidefsky , Heiko Carstens , linux390@de.ibm.com, linux-s390@vger.kernel.org, Geert Uytterhoeven , linux-m68k@vger.kernel.org, Greg Ungerer Message-ID: <20110426122320.w7o8WSeFLBPbQsseyHE36LKxTTcxGT9ckVZ7GU3iGFM@z> On Sun, 2011-04-24 at 18:51 +0900, Akinobu Mita wrote: > The style that we normally use in asm-generic is to test the macro itself > for existence, so in asm-generic, do: > > #ifndef find_next_zero_bit_le > extern unsigned long find_next_zero_bit_le(const void *addr, > unsigned long size, unsigned long offset); > #endif > > and in the architectures, write > > static inline unsigned long find_next_zero_bit_le(const void *addr, > unsigned long size, unsigned long offset) > #define find_next_zero_bit_le find_next_zero_bit_le > > This adds the #define for each of the optimized find bitops in the > architectures. > > Suggested-by: Arnd Bergmann > Signed-off-by: Akinobu Mita > Cc: Russell King > Cc: linux-arm-kernel@lists.infradead.org > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: linux390@de.ibm.com > Cc: linux-s390@vger.kernel.org > Cc: Hans-Christian Egtvedt > Cc: Geert Uytterhoeven > Cc: linux-m68k@lists.linux-m68k.org > Cc: Greg Ungerer For the arch/avr32/include/asm/bitops.h changes. Acked-by: Hans-Christian Egtvedt -- Hans-Christian Egtvedt