From: Guan Xuetao <gxt@mprc.pku.edu.cn>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, greg@kroah.com
Subject: Re: [PATCH] unicore32: fix build error for find bitops
Date: Fri, 10 Jun 2011 11:16:55 +0800 [thread overview]
Message-ID: <1307675815.1537.9.camel@epip-laptop> (raw)
In-Reply-To: <BANLkTimWYjzxhQBH2A76D590KBfjKbguTA@mail.gmail.com>
On Thu, 2011-06-09 at 23:05 +0900, Akinobu Mita wrote:
> 2011/6/9 Akinobu Mita <akinobu.mita@gmail.com>:
> > 2011/6/9 GuanXuetao <gxt@mprc.pku.edu.cn>:
> >> From: Guan Xuetao <gxt@mprc.pku.edu.cn>
> >>
> >> Remove the __uc32_ prefix in find bitops functions.
> >> see commit <19de85ef574c3a2182e3ccad9581805052f14946>
> >> bitops: add #ifndef for each of find bitops
> >>
> >> Signed-off-by: Guan Xuetao <gxt@mprc.pku.edu.cn>
> >> Cc: Akinobu Mita <akinobu.mita@gmail.com>
> >> ---
> >> arch/unicore32/include/asm/bitops.h | 6 ------
> >> arch/unicore32/kernel/ksyms.c | 4 ++--
> >> arch/unicore32/lib/findbit.S | 14 ++++++++------
> >> 3 files changed, 10 insertions(+), 14 deletions(-)
> >>
> >> diff --git a/arch/unicore32/include/asm/bitops.h b/arch/unicore32/include/asm/bitops.h
> >> index 1628a63..a9653f0 100644
> >> --- a/arch/unicore32/include/asm/bitops.h
> >> +++ b/arch/unicore32/include/asm/bitops.h
> >> @@ -13,12 +13,6 @@
> >> #ifndef __UNICORE_BITOPS_H__
> >> #define __UNICORE_BITOPS_H__
> >>
> >> -#define find_next_bit __uc32_find_next_bit
> >> -#define find_next_zero_bit __uc32_find_next_zero_bit
> >> -
> >> -#define find_first_bit __uc32_find_first_bit
> >> -#define find_first_zero_bit __uc32_find_first_zero_bit
> >> -
> >
> > Is this patch really fix the build error?
> >
> > If these find_*_bit macros are removed, vmlinux will have multiple
> > definisions of find_*_bit. Because lib/find_next_bit.c is built
> > unconditionally after the commit 63e424c84429903c92a0f1e9654c31ccaf6694d0
> > ("arch: remove CONFIG_GENERIC_FIND_{NEXT_BIT,BIT_LE,LAST_BIT}".
>
> The attached patch hopefully fix the build error but it is untested
> because I can't find crosstool for unicore32. So could you apply
> this patch on top of your patch and check whether it fixes?
Thanks Akinobu.
I want to avoid the duplication of the 'extern' function definitions in
asm-generic header and arch-specific header.
Guan Xuetao
next prev parent reply other threads:[~2011-06-10 3:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 11:09 [PATCH] unicore32: fix build error for find bitops GuanXuetao
2011-06-09 11:09 ` GuanXuetao
2011-06-09 11:32 ` Akinobu Mita
2011-06-09 14:05 ` Akinobu Mita
2011-06-10 3:16 ` Guan Xuetao [this message]
2011-06-10 4:22 ` Akinobu Mita
2011-06-13 8:57 ` Guan Xuetao
2011-06-13 8:57 ` Guan Xuetao
2011-06-13 9:33 ` Akinobu Mita
2011-06-13 10:22 ` Guan Xuetao
2011-06-13 11:32 ` Akinobu Mita
2011-06-10 3:13 ` Guan Xuetao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307675815.1537.9.camel@epip-laptop \
--to=gxt@mprc.pku.edu.cn \
--cc=akinobu.mita@gmail.com \
--cc=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox