From: Jonas Bonn <jonas@southpole.se>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
liqin.chen@sunplusct.com, gxt@mprc.pku.edu.cn
Subject: Re: [PATCH 1/2] asm-generic: add MMU variants of io.h functions
Date: Sat, 02 Jul 2011 18:47:30 +0200 [thread overview]
Message-ID: <1309625250.24186.1224.camel@localhost> (raw)
In-Reply-To: <CAMjpGUfZwZu-ZCJj2cmq1w6B71-gQ8G27FpYdhseyq3hoZRL+Q@mail.gmail.com>
On Sat, 2011-07-02 at 12:38 -0400, Mike Frysinger wrote:
> On Sat, Jul 2, 2011 at 11:53, Jonas Bonn wrote:
> > Some of the implementations, in particular the ioremap variants, in
> > asm-generic/io.h are for systems with an MMU.
>
> do you mean "without an MMU" ?
Yes, of course... that's supposed to be _without_ an MMU.
>
> > +#ifdef CONFIG_MMU
> > +#define xlate_dev_mem_ptr(p) __va(p)
> > +#else
> > #define xlate_dev_mem_ptr(p) ((void *) (p))
> > +#endif
>
> i wonder if we could do:
> #ifndef __va
> #define __va(p) ((void *)(p))
> #endif
> #define xlate_dev_mem_ptr(p) __va(p)
> -mike
This seems to introduce an artificial definition of a "virtual" address
for systems without an MMU, which strikes me as a bit odd. If this is
what people prefer, that's fine... I think I prefer the former variant,
though.
/Jonas
next prev parent reply other threads:[~2011-07-02 16:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-02 15:53 [PATCH 1/2] asm-generic: add MMU variants of io.h functions Jonas Bonn
2011-07-02 15:53 ` Jonas Bonn
2011-07-02 15:53 ` [PATCH 2/2] iomap: make IOPORT/PCI mapping functions conditional Jonas Bonn
2011-07-02 19:46 ` Arnd Bergmann
2011-07-02 19:54 ` Jonas Bonn
2011-07-02 20:15 ` Arnd Bergmann
2011-07-02 16:38 ` [PATCH 1/2] asm-generic: add MMU variants of io.h functions Mike Frysinger
2011-07-02 16:47 ` Jonas Bonn [this message]
2011-07-02 17:04 ` Mike Frysinger
2011-07-02 17:04 ` Mike Frysinger
2011-07-02 17:36 ` [PATCH v2 1/1] " Jonas Bonn
2011-07-02 18:43 ` Mike Frysinger
2011-07-02 19:44 ` Arnd Bergmann
2011-07-04 2:28 ` Guan Xuetao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309625250.24186.1224.camel@localhost \
--to=jonas@southpole.se \
--cc=gxt@mprc.pku.edu.cn \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liqin.chen@sunplusct.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox