Re: [PATCHv4 11/11] Phonet: Use *_dec_not_zero instead of *_add_unless

Rémi Denis-Courmont
2011-07-27T10:29:41Z

On Wednesday 27 July 2011 12:47:50 ext Sven Eckelmann, you wrote:
> atomic_dec_not_zero is defined for each architecture through
> <linux/atomic.h> to provide the functionality of
> atomic_add_unless(x, -1, 0).
>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> Cc: Remi Denis-Courmont <remi.denis-courmont@nokia.com>

Acked-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>

> ---
> net/phonet/pep.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/phonet/pep.c b/net/phonet/pep.c
> index f17fd84..b192c83 100644
> --- a/net/phonet/pep.c
> +++ b/net/phonet/pep.c
> @@ -1013,7 +1013,7 @@ static int pipe_skb_send(struct sock *sk, struct
> sk_buff *skb) int err;
>
> if (pn_flow_safe(pn->tx_fc) &&
> - !atomic_add_unless(&pn->tx_credits, -1, 0)) {
> + !atomic_dec_not_zero(&pn->tx_credits)) {
> kfree_skb(skb);
> return -ENOBUFS;
> }

--
Rémi Denis-Courmont