From: Yinghai Lu <yinghai@kernel.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Tony Luck <tony.luck@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH 16/22] PCI: Double checking setting for bus register and bus struct.
Date: Fri, 10 Feb 2012 20:06:19 -0800 [thread overview]
Message-ID: <1328933185-15154-17-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1328933185-15154-1-git-send-email-yinghai@kernel.org>
User could use setpci change bridge's bus register. that could make value of register
and struct is out of sync.
User later will use rescan to see the devices is moving.
In the rescaning, we need to double check the range and remove the old struct at first.
to make thing working user may need have script to remove children devices under bridge
at first, and then use setpci update bus register and then rescan.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
drivers/pci/probe.c | 40 ++++++++++++++++++++++++++++++++++++++++
1 files changed, 40 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 346dc22..009946a 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -814,6 +814,46 @@ int __devinit pci_scan_bridge(struct pci_bus *bus, struct pci_dev *dev, int max,
(primary != bus->number || secondary <= bus->number))
broken = 1;
+ if (!pass && dev->subordinate) {
+ child = dev->subordinate;
+ /*
+ * User could change bus register in bridge manually with
+ * setpci and rescan. So double check the setting, and remove
+ * old structs. Don't set broken yet, let following check
+ * to see if the new setting good.
+ */
+ if (primary != child->primary ||
+ secondary != child->secondary ||
+ subordinate != child->subordinate) {
+ dev_info(&dev->dev,
+ "someone changed bus register from pri:%02x, sec:%02x, sub:%02x to pri:%02x, sec:%02x, sub:%02x\n",
+ child->primary, child->secondary, child->subordinate,
+ primary, secondary, subordinate);
+ if (!list_empty(&dev->subordinate->devices)) {
+ u32 old_buses;
+
+ dev_info(&dev->dev,
+ "but children devices are not removed manually before that.\n");
+ /*
+ * Try best to remove left children devices
+ * but we need to set bus register back, otherwise
+ * We can not access children device and stop them
+ */
+ old_buses = (buses & 0xff000000)
+ | ((unsigned int)(child->primary) << 0)
+ | ((unsigned int)(child->secondary) << 8)
+ | ((unsigned int)(child->subordinate) << 16);
+ pci_write_config_dword(dev, PCI_PRIMARY_BUS,
+ old_buses);
+ pci_remove_behind_bridge(dev);
+ pci_write_config_dword(dev, PCI_PRIMARY_BUS,
+ buses);
+ }
+ pci_remove_bus(dev->subordinate);
+ dev->subordinate = NULL;
+ }
+ }
+
/* more strict checking */
if (!pass && !broken && !dev->subordinate)
broken = pci_bridge_check_busn_broken(bus, dev,
--
1.7.7
next prev parent reply other threads:[~2012-02-11 4:06 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-11 4:06 [PATCH -v6 0/22] PCI: allocate pci bus num range for unassigned bridge busn + pci rescan cleanup Yinghai Lu
2012-02-11 4:06 ` [PATCH 01/22] PCI: Add busn_res into struct pci_bus Yinghai Lu
2012-02-11 4:06 ` [PATCH 02/22] PCI: Add busn_res operation functions Yinghai Lu
2012-02-11 4:06 ` [PATCH 03/22] PCI: Add busn_res tracking in core Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu
2012-02-11 4:06 ` [PATCH 04/22] PCI, x86: Register busn_res for root buses Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu
2012-02-11 4:06 ` [PATCH 05/22] PCI, ia64: " Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu
2012-02-11 4:06 ` [PATCH 06/22] PCI, sparc: " Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu
2012-02-11 4:06 ` [PATCH 07/22] PCI, powerpc: " Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu
2012-02-11 4:06 ` [PATCH 08/22] PCI, parisc: " Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu
2012-02-11 4:06 ` [PATCH 09/22] PCI: Add pci_bus_extend/shrink_top() Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu
2012-02-11 4:06 ` [PATCH 10/22] PCI: Probe safe range that we can use for unassigned bridge Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu
2012-02-11 4:06 ` [PATCH 11/22] PCI: Strict checking of valid range for bridge Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu
2012-02-11 4:06 ` [PATCH 12/22] PCI: Allocate bus range instead of use max blindly Yinghai Lu
2012-02-11 4:06 ` [PATCH 13/22] PCI: kill pci_fixup_parent_subordinate_busnr() Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu
2012-02-11 4:06 ` [PATCH 14/22] PCI: Seperate child bus scanning to two passes overall Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu
2012-02-11 4:06 ` [PATCH 15/22] pcmcia: remove workaround for fixing pci parent bus subordinate Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu [this message]
2012-02-11 4:06 ` [PATCH 16/22] PCI: Double checking setting for bus register and bus struct Yinghai Lu
2012-02-11 4:06 ` [PATCH 17/22] PCI, pciehp: Remove not needed bus number range checking Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu
2012-02-11 4:06 ` [PATCH 18/22] PCI, sys: Use device_type and attr_groups with pci dev Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu
2012-02-11 4:06 ` [PATCH 19/22] PCI, sysfs: create rescan_bridge under /sys/.../pci/devices/... for pci bridges Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu
2012-02-11 4:06 ` [PATCH 20/22] PCI: Add pci_bus_add_single_device() Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu
2012-02-11 4:06 ` [PATCH 21/22] PCI: make pci_rescan_bus_bridge_resize use pci_scan_bridge instead Yinghai Lu
2012-02-11 4:06 ` Yinghai Lu
2012-02-11 4:06 ` [PATCH 22/22] PCI: clean up rescan_bus_bridge_resize Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328933185-15154-17-git-send-email-yinghai@kernel.org \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).