From: Jonas Bonn <jonas@southpole.se>
To: Matt Fleming <matt@console-pimps.org>
Cc: linux-arch@vger.kernel.org, Matt Fleming <matt.fleming@intel.com>,
Arnd Bergmann <arnd@arndb.de>, Oleg Nesterov <oleg@redhat.com>,
linux-kernel@vger.kernel.org, linux@lists.openrisc.net,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 21/40] OpenRISC: Don't reimplement force_sigsegv()
Date: Wed, 15 Feb 2012 16:40:56 +0100 [thread overview]
Message-ID: <1329320456.2670.86.camel@crucifix> (raw)
In-Reply-To: <1329219673-28711-22-git-send-email-matt@console-pimps.org>
Acked-by: Jonas Bonn <jonas@southpole.se>
...for OpenRISC, all 4 patches (20-23 in this series).
Should I take these in the OpenRISC tree or how did you want to do?
/Jonas
On Tue, 2012-02-14 at 11:40 +0000, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@intel.com>
>
> Instead of open coding the sequence from force_sigsegv() just call
> it. This also fixes a bug because we were modifying ka->sa.sa_handler
> (which is a copy of sighand->action[]), whereas the intention of the
> code was to modify sighand->action[] directly.
>
> As the original code was working with a copy it had no effect on
> signal delivery.
>
> Acked-by: Oleg Nesterov <oleg@redhat.com>
> Cc: Jonas Bonn <jonas@southpole.se>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: linux@lists.openrisc.net
> Signed-off-by: Matt Fleming <matt.fleming@intel.com>
> ---
> arch/openrisc/kernel/signal.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/arch/openrisc/kernel/signal.c b/arch/openrisc/kernel/signal.c
> index 95207ab..53741ba 100644
> --- a/arch/openrisc/kernel/signal.c
> +++ b/arch/openrisc/kernel/signal.c
> @@ -250,9 +250,7 @@ static void setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
> return;
>
> give_sigsegv:
> - if (sig == SIGSEGV)
> - ka->sa.sa_handler = SIG_DFL;
> - force_sig(SIGSEGV, current);
> + force_sigsegv(sig, current);
> }
>
> static inline void
--
Jonas Bonn South Pole AB
Phone : +46-8-56237100 Anderstorpsvägen 16
Mobile: +46-768-527755 SE-17154 Solna
jonas@southpole.se www.southpoleconsulting.com
_______________________________________________
Linux mailing list
Linux@lists.openrisc.net
http://lists.openrisc.net/listinfo/linux
WARNING: multiple messages have this Message-ID (diff)
From: Jonas Bonn <jonas@southpole.se>
To: Matt Fleming <matt@console-pimps.org>
Cc: linux-arch@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Matt Fleming <matt.fleming@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
linux@lists.openrisc.net
Subject: Re: [PATCH 21/40] OpenRISC: Don't reimplement force_sigsegv()
Date: Wed, 15 Feb 2012 16:40:56 +0100 [thread overview]
Message-ID: <1329320456.2670.86.camel@crucifix> (raw)
Message-ID: <20120215154056.1w-HST1Z5zGRYqwkJ5jxjrYVy3DiyvCO1Rb4GmfcwRU@z> (raw)
In-Reply-To: <1329219673-28711-22-git-send-email-matt@console-pimps.org>
Acked-by: Jonas Bonn <jonas@southpole.se>
...for OpenRISC, all 4 patches (20-23 in this series).
Should I take these in the OpenRISC tree or how did you want to do?
/Jonas
On Tue, 2012-02-14 at 11:40 +0000, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@intel.com>
>
> Instead of open coding the sequence from force_sigsegv() just call
> it. This also fixes a bug because we were modifying ka->sa.sa_handler
> (which is a copy of sighand->action[]), whereas the intention of the
> code was to modify sighand->action[] directly.
>
> As the original code was working with a copy it had no effect on
> signal delivery.
>
> Acked-by: Oleg Nesterov <oleg@redhat.com>
> Cc: Jonas Bonn <jonas@southpole.se>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: linux@lists.openrisc.net
> Signed-off-by: Matt Fleming <matt.fleming@intel.com>
> ---
> arch/openrisc/kernel/signal.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/arch/openrisc/kernel/signal.c b/arch/openrisc/kernel/signal.c
> index 95207ab..53741ba 100644
> --- a/arch/openrisc/kernel/signal.c
> +++ b/arch/openrisc/kernel/signal.c
> @@ -250,9 +250,7 @@ static void setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
> return;
>
> give_sigsegv:
> - if (sig == SIGSEGV)
> - ka->sa.sa_handler = SIG_DFL;
> - force_sig(SIGSEGV, current);
> + force_sigsegv(sig, current);
> }
>
> static inline void
--
Jonas Bonn South Pole AB
Phone : +46-8-56237100 Anderstorpsvägen 16
Mobile: +46-768-527755 SE-17154 Solna
jonas@southpole.se www.southpoleconsulting.com
next prev parent reply other threads:[~2012-02-15 15:40 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 11:40 [PATCH 00/40] arch: set_current_blocked() and block_sigmask() Matt Fleming
2012-02-14 11:40 ` [PATCH 01/40] alpha: Use " Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:40 ` [PATCH 02/40] arm: " Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:40 ` [PATCH 03/40] avr32: Don't mask signals in the error path Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:40 ` [PATCH 04/40] avr32: use set_current_blocked() in handle_signal/sys_rt_sigreturn Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:40 ` [PATCH 05/40] avr32: Use block_sigmask() Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:40 ` [PATCH 06/40] blackfin: Use set_current_blocked() and block_sigmask() Matt Fleming
2012-02-16 9:28 ` Bob Liu
2012-02-14 11:40 ` [PATCH 07/40] C6X: " Matt Fleming
2012-02-14 11:40 ` [PATCH 08/40] cris: " Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-15 8:43 ` Jesper Nilsson
2012-02-14 11:40 ` [PATCH 09/40] frv: " Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:40 ` [PATCH 10/40] h8300: " Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:40 ` [PATCH 11/40] Hexagon: " Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:40 ` [PATCH 12/40] ia64: " Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:40 ` [PATCH 13/40] m32r: " Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:40 ` [PATCH 14/40] m68k: " Matt Fleming
2012-02-14 11:40 ` [PATCH 15/40] microblaze: Don't reimplement force_sigsegv() Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:40 ` [PATCH 16/40] microblaze: No need to reset handler if SA_ONESHOT Matt Fleming
2012-02-14 11:40 ` [PATCH 17/40] microblaze: Fix signal masking Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:40 ` [PATCH 18/40] microblaze: Use set_current_blocked() and block_sigmask() Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:40 ` [PATCH 19/40] MIPS: " Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:40 ` [PATCH 20/40] mn10300: " Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:40 ` [PATCH 21/40] OpenRISC: Don't reimplement force_sigsegv() Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-15 15:40 ` Jonas Bonn [this message]
2012-02-15 15:40 ` Jonas Bonn
2012-02-15 15:49 ` Matt Fleming
2012-02-15 15:57 ` Jonas Bonn
2012-02-15 15:57 ` Jonas Bonn
2012-02-14 11:40 ` [PATCH 22/40] OpenRISC: No need to reset handler if SA_ONESHOT Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:40 ` [PATCH 23/40] OpenRISC: Don't mask signals if we fail to setup signal stack Matt Fleming
2012-02-14 11:40 ` [PATCH 24/40] OpenRISC: Use set_current_blocked() and block_sigmask() Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:40 ` [PATCH 25/40] parisc: " Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-04-06 14:59 ` Kyle McMartin
2012-02-14 11:40 ` [PATCH 26/40] powerpc: " Matt Fleming
2012-02-14 11:40 ` Matt Fleming
2012-02-14 11:41 ` [PATCH 27/40] [S390] Use block_sigmask() Matt Fleming
2012-02-14 11:41 ` Matt Fleming
2012-02-14 11:41 ` [PATCH 28/40] score: Don't mask signals if we fail to setup signal stack Matt Fleming
2012-02-14 11:41 ` Matt Fleming
2012-02-14 11:41 ` [PATCH 29/40] score: Use set_current_blocked() and block_sigmask() Matt Fleming
2012-02-14 11:41 ` Matt Fleming
2012-02-14 11:41 ` [PATCH 30/40] sh: No need to reset handler if SA_ONESHOT Matt Fleming
2012-02-14 11:41 ` Matt Fleming
2012-02-14 11:41 ` [PATCH 31/40] sh: Use set_current_blocked() and block_sigmask() Matt Fleming
2012-02-14 11:41 ` Matt Fleming
2012-02-14 11:41 ` [PATCH 32/40] sparc: Use block_sigmask() Matt Fleming
2012-02-14 11:41 ` Matt Fleming
2012-02-15 3:57 ` David Miller
2012-02-15 3:57 ` David Miller
2012-02-14 11:41 ` [PATCH 33/40] tile: Use set_current_blocked() and block_sigmask() Matt Fleming
2012-02-14 11:41 ` Matt Fleming
2012-02-14 11:41 ` [PATCH 34/40] um: Don't restore current->blocked on error Matt Fleming
2012-02-14 11:41 ` Matt Fleming
2012-02-14 11:41 ` [PATCH 35/40] um: Use set_current_blocked() and block_sigmask() Matt Fleming
2012-02-14 11:41 ` Matt Fleming
2012-02-14 11:41 ` [PATCH 36/40] unicore32: Use block_sigmask() Matt Fleming
2012-02-14 11:41 ` Matt Fleming
2012-02-14 11:41 ` [PATCH 37/40] xtensa: Don't reimplement force_sigsegv() Matt Fleming
2012-02-14 11:41 ` Matt Fleming
2012-02-14 11:41 ` [PATCH 38/40] xtensa: No need to reset handler if SA_ONESHOT Matt Fleming
2012-02-14 11:41 ` Matt Fleming
2012-02-14 11:41 ` [PATCH 39/40] xtensa: Don't mask signals if we fail to setup signal stack Matt Fleming
2012-02-14 11:41 ` Matt Fleming
2012-02-14 11:41 ` [PATCH 40/40] xtensa: Use set_current_blocked() and block_sigmask() Matt Fleming
2012-02-14 11:41 ` Matt Fleming
2012-02-14 13:45 ` [PATCH 00/40] arch: " Mark Salter
2012-02-14 13:52 ` Matt Fleming
2012-02-14 13:58 ` Mark Salter
2012-02-14 14:08 ` Matt Fleming
2012-02-14 15:56 ` [PATCH 20/40] mn10300: Use " David Howells
2012-02-14 17:23 ` Oleg Nesterov
2012-02-14 17:59 ` Matt Fleming
2012-02-14 18:12 ` David Howells
2012-02-14 18:24 ` Oleg Nesterov
2012-02-14 18:30 ` David Howells
2012-02-14 18:30 ` David Howells
2012-02-15 11:49 ` Matt Fleming
2012-02-14 17:32 ` [PATCH 00/40] arch: " Oleg Nesterov
2012-02-15 11:47 ` Matt Fleming
2012-02-15 11:47 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329320456.2670.86.camel@crucifix \
--to=jonas@southpole.se \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@lists.openrisc.net \
--cc=matt.fleming@intel.com \
--cc=matt@console-pimps.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).