From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH v1 09/11] powerpc/PCI: replace pci_probe_only with pci_flags Date: Thu, 23 Feb 2012 08:41:49 +1100 Message-ID: <1329946909.20389.10.camel@pasglop> References: <20120222181556.27513.9413.stgit@bhelgaas.mtv.corp.google.com> <20120222181948.27513.96215.stgit@bhelgaas.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120222181948.27513.96215.stgit@bhelgaas.mtv.corp.google.com> Sender: linux-pci-owner@vger.kernel.org To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: linux-arch.vger.kernel.org On Wed, 2012-02-22 at 11:19 -0700, Bjorn Helgaas wrote: > We already use pci_flags, so this just sets pci_flags directly and removes > the intermediate step of figuring out pci_probe_only, then using it to set > pci_flags. Ah yes, those flags are now common indeed. > The PCI core provides a pci_flags definition (currently __weak), so drop > the powerpc definitions in favor of that. Note that we must set the ppc64 > default (PCI_PROBE_ONLY set) in the 64-bit setup_arch() before calling > the platform .setup_arch() method, which may override the default. Ah wait, I have a patch about to hit -next that flips the ppc64 default... Maybe it's easier if you just pick it up and stick it in your series, that will avoid integration clashes.. http://patchwork.ozlabs.org/patch/141225/ Cheers, Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org ([63.228.1.57]:38367 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755043Ab2BVVl6 (ORCPT ); Wed, 22 Feb 2012 16:41:58 -0500 Message-ID: <1329946909.20389.10.camel@pasglop> Subject: Re: [PATCH v1 09/11] powerpc/PCI: replace pci_probe_only with pci_flags From: Benjamin Herrenschmidt Date: Thu, 23 Feb 2012 08:41:49 +1100 In-Reply-To: <20120222181948.27513.96215.stgit@bhelgaas.mtv.corp.google.com> References: <20120222181556.27513.9413.stgit@bhelgaas.mtv.corp.google.com> <20120222181948.27513.96215.stgit@bhelgaas.mtv.corp.google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-arch-owner@vger.kernel.org List-ID: To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Message-ID: <20120222214149.9WgNYgFDBXAhX3f393oV_0ytMnKwkMmhSz0xReLiOiQ@z> On Wed, 2012-02-22 at 11:19 -0700, Bjorn Helgaas wrote: > We already use pci_flags, so this just sets pci_flags directly and removes > the intermediate step of figuring out pci_probe_only, then using it to set > pci_flags. Ah yes, those flags are now common indeed. > The PCI core provides a pci_flags definition (currently __weak), so drop > the powerpc definitions in favor of that. Note that we must set the ppc64 > default (PCI_PROBE_ONLY set) in the 64-bit setup_arch() before calling > the platform .setup_arch() method, which may override the default. Ah wait, I have a patch about to hit -next that flips the ppc64 default... Maybe it's easier if you just pick it up and stick it in your series, that will avoid integration clashes.. http://patchwork.ozlabs.org/patch/141225/ Cheers, Ben.