From: Yinghai Lu <yinghai@kernel.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Tony Luck <tony.luck@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH 01/23] x86, PCI: Merge pcibios_scan_root and pci_scan_bus_on_node
Date: Fri, 24 Feb 2012 02:18:49 -0800 [thread overview]
Message-ID: <1330078751-7299-2-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1330078751-7299-1-git-send-email-yinghai@kernel.org>
Those two almost the same.
Let pcibios_scan_root call pci_scan_bus_on_node instead.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
arch/x86/pci/common.c | 27 ++++-----------------------
1 files changed, 4 insertions(+), 23 deletions(-)
diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c
index 323481e..8e04ec5 100644
--- a/arch/x86/pci/common.c
+++ b/arch/x86/pci/common.c
@@ -430,9 +430,7 @@ void __init dmi_check_pciprobe(void)
struct pci_bus * __devinit pcibios_scan_root(int busnum)
{
- LIST_HEAD(resources);
struct pci_bus *bus = NULL;
- struct pci_sysdata *sd;
while ((bus = pci_find_next_bus(bus)) != NULL) {
if (bus->number == busnum) {
@@ -441,28 +439,10 @@ struct pci_bus * __devinit pcibios_scan_root(int busnum)
}
}
- /* Allocate per-root-bus (not per bus) arch-specific data.
- * TODO: leak; this memory is never freed.
- * It's arguable whether it's worth the trouble to care.
- */
- sd = kzalloc(sizeof(*sd), GFP_KERNEL);
- if (!sd) {
- printk(KERN_ERR "PCI: OOM, not probing PCI bus %02x\n", busnum);
- return NULL;
- }
-
- sd->node = get_mp_bus_to_node(busnum);
-
- printk(KERN_DEBUG "PCI: Probing PCI hardware (bus %02x)\n", busnum);
- x86_pci_root_bus_resources(busnum, &resources);
- bus = pci_scan_root_bus(NULL, busnum, &pci_root_ops, sd, &resources);
- if (!bus) {
- pci_free_resource_list(&resources);
- kfree(sd);
- }
-
- return bus;
+ return pci_scan_bus_on_node(busnum, &pci_root_ops,
+ get_mp_bus_to_node(busnum));
}
+
void __init pcibios_set_cache_line_size(void)
{
struct cpuinfo_x86 *c = &boot_cpu_data;
@@ -656,6 +636,7 @@ struct pci_bus * __devinit pci_scan_bus_on_node(int busno, struct pci_ops *ops,
}
sd->node = node;
x86_pci_root_bus_resources(busno, &resources);
+ printk(KERN_DEBUG "PCI: Probing PCI hardware (bus %02x)\n", busno);
bus = pci_scan_root_bus(NULL, busno, ops, sd, &resources);
if (!bus) {
pci_free_resource_list(&resources);
--
1.7.7
next prev parent reply other threads:[~2012-02-24 10:18 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 10:18 [PATCH -v7 0/23] PCI: allocate pci bus num range for unassigned bridge busn + pci rescan cleanup Yinghai Lu
2012-02-24 10:18 ` Yinghai Lu
2012-02-24 10:18 ` Yinghai Lu [this message]
2012-02-24 10:18 ` [PATCH 01/23] x86, PCI: Merge pcibios_scan_root and pci_scan_bus_on_node Yinghai Lu
2012-02-24 10:18 ` [PATCH 02/23] PCI: Add busn_res into struct pci_bus Yinghai Lu
2012-02-24 10:18 ` [PATCH 03/23] PCI: Add busn_res operation functions Yinghai Lu
2012-02-24 10:18 ` Yinghai Lu
2012-02-24 10:18 ` [PATCH 04/23] PCI: Add busn_res tracking in core Yinghai Lu
2012-02-24 10:18 ` Yinghai Lu
2012-02-24 10:18 ` [PATCH 05/23] PCI, x86: Register busn_res for root buses Yinghai Lu
2012-02-24 10:18 ` Yinghai Lu
2012-02-24 10:18 ` [PATCH 06/23] PCI, ia64: " Yinghai Lu
2012-02-24 10:18 ` [PATCH 07/23] PCI, sparc: " Yinghai Lu
2012-02-24 10:18 ` Yinghai Lu
2012-02-24 10:18 ` [PATCH 08/23] PCI, powerpc: " Yinghai Lu
2012-02-24 10:18 ` [PATCH 09/23] PCI, parisc: " Yinghai Lu
2012-02-24 10:18 ` Yinghai Lu
2012-02-24 10:18 ` [PATCH 10/23] PCI: Add pci_bus_extend/shrink_top() Yinghai Lu
2012-02-24 10:18 ` Yinghai Lu
2012-02-24 10:18 ` [PATCH 11/23] PCI: Probe safe range that we can use for unassigned bridge Yinghai Lu
2012-02-24 10:18 ` Yinghai Lu
2012-02-24 10:19 ` [PATCH 12/23] PCI: Strict checking of valid range for bridge Yinghai Lu
2012-02-24 10:19 ` Yinghai Lu
2012-02-24 10:19 ` [PATCH 13/23] PCI: Allocate bus range instead of use max blindly Yinghai Lu
2012-02-24 10:19 ` Yinghai Lu
2012-02-24 10:19 ` [PATCH 14/23] PCI: kill pci_fixup_parent_subordinate_busnr() Yinghai Lu
2012-02-24 10:19 ` Yinghai Lu
2012-02-24 10:19 ` [PATCH 15/23] PCI: Seperate child bus scanning to two passes overall Yinghai Lu
2012-02-24 10:19 ` Yinghai Lu
2012-02-24 10:19 ` [PATCH 16/23] pcmcia: remove workaround for fixing pci parent bus subordinate Yinghai Lu
2012-02-24 10:19 ` Yinghai Lu
2012-02-24 10:19 ` [PATCH 17/23] PCI: Double checking setting for bus register and bus struct Yinghai Lu
2012-02-24 10:19 ` Yinghai Lu
2012-02-24 10:19 ` [PATCH 18/23] PCI, pciehp: Remove not needed bus number range checking Yinghai Lu
2012-02-24 10:19 ` Yinghai Lu
2012-02-24 10:19 ` [PATCH 19/23] PCI, sys: Use device_type and attr_groups with pci dev Yinghai Lu
2012-02-24 10:19 ` Yinghai Lu
2012-02-24 10:19 ` [PATCH 20/23] PCI, sysfs: create rescan_bridge under /sys/.../pci/devices/... for pci bridges Yinghai Lu
2012-02-24 10:19 ` Yinghai Lu
2012-02-24 10:19 ` [PATCH 21/23] PCI: Add pci_bus_add_single_device() Yinghai Lu
2012-02-24 10:19 ` Yinghai Lu
2012-02-24 10:19 ` [PATCH 22/23] PCI: make pci_rescan_bus_bridge_resize use pci_scan_bridge instead Yinghai Lu
2012-02-24 10:19 ` Yinghai Lu
2012-02-24 10:19 ` [PATCH 23/23] PCI: clean up rescan_bus_bridge_resize Yinghai Lu
2012-02-24 10:19 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330078751-7299-2-git-send-email-yinghai@kernel.org \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).