From: Jonas Bonn <jonas@southpole.se>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Cc: Kautuk Consul <consul.kautuk@gmail.com>,
"Mohd. Faris" <mohdfarisq2010@gmail.com>,
Jonas Bonn <jonas@southpole.se>
Subject: [PATCH 3/6] openrisc/mm/fault.c: Port OOM changes to do_page_fault
Date: Tue, 8 May 2012 11:54:02 +0200 [thread overview]
Message-ID: <1336470845-13859-4-git-send-email-jonas@southpole.se> (raw)
In-Reply-To: <1336470845-13859-1-git-send-email-jonas@southpole.se>
From: Kautuk Consul <consul.kautuk@gmail.com>
Commit d065bd810b6deb67d4897a14bfe21f8eb526ba99
(mm: retry page fault when blocking on disk transfer) and
commit 37b23e0525d393d48a7d59f870b3bc061a30ccdb
(x86,mm: make pagefault killable)
The above commits introduced changes into the x86 pagefault handler
for making the page fault handler retryable as well as killable.
These changes reduce the mmap_sem hold time, which is crucial
during OOM killer invocation.
Port these changes to openrisc.
Signed-off-by: Mohd. Faris <mohdfarisq2010@gmail.com>
Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
Signed-off-by: Jonas Bonn <jonas@southpole.se>
---
arch/openrisc/mm/fault.c | 32 ++++++++++++++++++++++++++------
1 files changed, 26 insertions(+), 6 deletions(-)
diff --git a/arch/openrisc/mm/fault.c b/arch/openrisc/mm/fault.c
index a5dce82..40f850e 100644
--- a/arch/openrisc/mm/fault.c
+++ b/arch/openrisc/mm/fault.c
@@ -54,6 +54,7 @@ asmlinkage void do_page_fault(struct pt_regs *regs, unsigned long address,
struct vm_area_struct *vma;
siginfo_t info;
int fault;
+ unsigned int flags = FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE;
tsk = current;
@@ -105,6 +106,7 @@ asmlinkage void do_page_fault(struct pt_regs *regs, unsigned long address,
if (in_interrupt() || !mm)
goto no_context;
+retry:
down_read(&mm->mmap_sem);
vma = find_vma(mm, address);
@@ -143,6 +145,7 @@ good_area:
if (write_acc) {
if (!(vma->vm_flags & VM_WRITE))
goto bad_area;
+ flags |= FAULT_FLAG_WRITE;
} else {
/* not present */
if (!(vma->vm_flags & (VM_READ | VM_EXEC)))
@@ -159,7 +162,11 @@ good_area:
* the fault.
*/
- fault = handle_mm_fault(mm, vma, address, write_acc);
+ fault = handle_mm_fault(mm, vma, address, flags);
+
+ if ((fault & VM_FAULT_RETRY) && fatal_signal_pending(current))
+ return;
+
if (unlikely(fault & VM_FAULT_ERROR)) {
if (fault & VM_FAULT_OOM)
goto out_of_memory;
@@ -167,11 +174,24 @@ good_area:
goto do_sigbus;
BUG();
}
- /*RGD modeled on Cris */
- if (fault & VM_FAULT_MAJOR)
- tsk->maj_flt++;
- else
- tsk->min_flt++;
+
+ if (flags & FAULT_FLAG_ALLOW_RETRY) {
+ /*RGD modeled on Cris */
+ if (fault & VM_FAULT_MAJOR)
+ tsk->maj_flt++;
+ else
+ tsk->min_flt++;
+ if (fault & VM_FAULT_RETRY) {
+ flags &= ~FAULT_FLAG_ALLOW_RETRY;
+
+ /* No need to up_read(&mm->mmap_sem) as we would
+ * have already released it in __lock_page_or_retry
+ * in mm/filemap.c.
+ */
+
+ goto retry;
+ }
+ }
up_read(&mm->mmap_sem);
return;
--
1.7.0.4
next prev parent reply other threads:[~2012-05-08 9:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 9:53 [PATCH 0/6] OpenRISC patches for review Jonas Bonn
2012-05-08 9:54 ` [PATCH 1/6] openrisc: implement irqdomains Jonas Bonn
2012-05-08 9:54 ` Jonas Bonn
2012-05-08 9:54 ` [PATCH 2/6] openrisc: remove unnecessary includes Jonas Bonn
2012-05-08 9:54 ` Jonas Bonn
2012-05-08 9:54 ` Jonas Bonn [this message]
2012-05-08 9:54 ` [PATCH 3/6] openrisc/mm/fault.c: Port OOM changes to do_page_fault Jonas Bonn
2012-05-08 9:54 ` [PATCH 4/6] openrisc: header file cleanups Jonas Bonn
2012-05-08 9:54 ` Jonas Bonn
2012-05-08 9:54 ` [PATCH 5/6] openrisc: provide dma_map_ops Jonas Bonn
2012-05-08 9:54 ` Jonas Bonn
2012-05-08 9:54 ` [PATCH 6/6] openrisc: use scratch regs in atomic syscall Jonas Bonn
2012-05-08 9:54 ` Jonas Bonn
2012-05-08 11:24 ` [PATCH 0/6] OpenRISC patches for review Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336470845-13859-4-git-send-email-jonas@southpole.se \
--to=jonas@southpole.se \
--cc=consul.kautuk@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohdfarisq2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).