From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH v5 6/7] x86/tlb: optimizing flush_tlb_mm Date: Tue, 15 May 2012 12:00:27 +0200 Message-ID: <1337076027.27694.13.camel@twins> References: <1337072138-8323-1-git-send-email-alex.shi@intel.com> <1337072138-8323-7-git-send-email-alex.shi@intel.com> <1337073529.27694.8.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from casper.infradead.org ([85.118.1.10]:45818 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757259Ab2EOKAs convert rfc822-to-8bit (ORCPT ); Tue, 15 May 2012 06:00:48 -0400 In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Nick Piggin Cc: Alex Shi , tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, arnd@arndb.de, rostedt@goodmis.org, fweisbec@gmail.com, jeremy@goop.org, riel@redhat.com, luto@mit.edu, avi@redhat.com, len.brown@intel.com, dhowells@redhat.com, fenghua.yu@intel.com, borislav.petkov@amd.com, yinghai@kernel.org, ak@linux.intel.com, cpw@sgi.com, steiner@sgi.com, akpm@linux-foundation.org, penberg@kernel.org, hughd@google.com, rientjes@google.com, kosaki.motohiro@jp.fujitsu.com, n-horiguchi@ah.jp.nec.com, tj@kernel.org, oleg@redhat.com, axboe@kernel.dk, jmorris@namei.org, kamezawa.hiroyu@jp.fujitsu.com, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, yongjie.ren@intel.com, linux-arch@vger.kernel.org On Tue, 2012-05-15 at 19:52 +1000, Nick Piggin wrote: > > It could be warranted to change tlb_flush_mmu to a range API to > avoid doing the per-entry tracking which those architectures do? The per-entry could result in a much smaller range, there's no point in flushing tlbs for unpopulated pages. Anyway, I don't think even think we'd need to change the API for that, you could track the entire range through tlb_start_vma() if you wanted (although nobody does that IIRC).