From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Subject: [PATCH 10/20] sh: Do not call do_signal() with irqs disabled Date: Sat, 26 May 2012 00:04:26 +0200 Message-ID: <1337983476-22081-10-git-send-email-richard@nod.at> References: <1337983476-22081-1-git-send-email-richard@nod.at> Return-path: Received: from a.ns.miles-group.at ([95.130.255.143]:47839 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934010Ab2EYWFB (ORCPT ); Fri, 25 May 2012 18:05:01 -0400 In-Reply-To: <1337983476-22081-1-git-send-email-richard@nod.at> Sender: linux-arch-owner@vger.kernel.org List-ID: To: linux-kernel@vger.kernel.org Cc: linux-arch@vger.kernel.org, Richard Weinberger , Paul Mundt , linux-sh@vger.kernel.org get_signal_to_deliver() calls try_to_freeze() which might sleep. Cc: Paul Mundt Cc: linux-sh@vger.kernel.org Signed-off-by: Richard Weinberger --- arch/sh/kernel/signal_32.c | 3 +++ arch/sh/kernel/signal_64.c | 3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/arch/sh/kernel/signal_32.c b/arch/sh/kernel/signal_32.c index cb4172c..4f1db5e 100644 --- a/arch/sh/kernel/signal_32.c +++ b/arch/sh/kernel/signal_32.c @@ -25,6 +25,7 @@ #include #include #include +#include #include #include #include @@ -619,6 +620,8 @@ static void do_signal(struct pt_regs *regs, unsigned int save_r0) asmlinkage void do_notify_resume(struct pt_regs *regs, unsigned int save_r0, unsigned long thread_info_flags) { + local_irq_enable(); + /* deal with pending signal delivery */ if (thread_info_flags & _TIF_SIGPENDING) do_signal(regs, save_r0); diff --git a/arch/sh/kernel/signal_64.c b/arch/sh/kernel/signal_64.c index b589a35..f92fdb7 100644 --- a/arch/sh/kernel/signal_64.c +++ b/arch/sh/kernel/signal_64.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include #include @@ -679,6 +680,8 @@ handle_signal(unsigned long sig, siginfo_t *info, struct k_sigaction *ka, asmlinkage void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags) { + local_irq_enable(); + if (thread_info_flags & _TIF_SIGPENDING) do_signal(regs); -- 1.7.7.3