From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH 16/25] parisc: Use Kbuild infrastructure to handle asm-generic headers Date: Sat, 13 Oct 2012 10:17:06 -0400 Message-ID: <1350137826.24256.110.camel@gandalf.local.home> References: <20121013022632.024527228@goodmis.org> <20121013022954.722147403@goodmis.org> <1350131814.2485.46.camel@dabdike.int.hansenpartnership.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit Return-path: Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:15670 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753535Ab2JMORI (ORCPT ); Sat, 13 Oct 2012 10:17:08 -0400 In-Reply-To: <1350131814.2485.46.camel@dabdike.int.hansenpartnership.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: James Bottomley Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Andrew Morton , "James E.J. Bottomley" , Helge Deller On Sat, 2012-10-13 at 13:36 +0100, James Bottomley wrote: > On Fri, 2012-10-12 at 22:26 -0400, Steven Rostedt wrote: > > plain text document attachment > > (0016-parisc-Use-Kbuild-infrastructure-to-handle-asm-gener.patch) > > From: Steven Rostedt > > > > Use Kbuild infrastructure to handle the asm-generic headers > > and remove the wrapper headers that call them. > > > > This only affects headers that do nothing but include the generic > > equivalent. It does not touch any header that does a little more. > > > > Cc: linux-kbuild@vger.kernel.org > > Cc: linux-parisc@vger.kernel.org > > Cc: "James E.J. Bottomley" > > Cc: Helge Deller > > Signed-off-by: Steven Rostedt > > Actually, we're already evaluating a patch like this: > > http://marc.info/?l=linux-kernel&m=134883983019018 > > When I compare the two, I notice you missed a few (segment.h, vga.h, > hw_irq.h, mutex.h), so you probably want to adjust your scripts. > Scripts? Naw I did this by hand: cd arch/parisc/include/asm vim `grep -l asm-generic *.h` And in another terminal added the changes needed to Kbuild. I did this by hand because it would have taken me the same time to verify scripts to do it. By doing it by hand, I was less likely to add something that I shouldn't have. As Arnd mentioned, I didn't do a compare to check if what is in the header is identical to the asm-generic version. That was going to be "take 2". As this was just removing the simple cases of either: foo.h: #include or foo.h: #ifndef _ASM_PARISC_FOO_H #define _ASM_PARISC_FOO_H #include #endif As for the ones I missed: mutex.h has: #include which did not match mutex.h, so I ignored it. It would be removed in "take 2" because it's identical to asm-generic/mutex.h. segment.h: #ifndef __PARISC_SEGMENT_H #define __PARISC_SEGMENT_H /* Only here because we have some old header files that expect it.. */ #endif It missed the 'grep -l asm-generic' part. vga.h and hw_irq.h are also empty (no asm-generic added). segment.h and hw_irq.h are also empty in asm-generic, so they could be removed in take 2 as well. vga.h has some defines, but probably wouldn't affect parisc. I don't care if you take this patch or not. As long as the old method of adding a stub file to include asm-generic/foo.h is removed. This patch set was caused by my frustration of looking at how to add a new asm-generic file and coming up with the wrong implementation, and I want to make sure that this doesn't happen again with another developer. -- Steve