From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH 00/25] asm-generic: Convert all to use Kbuild file Date: Sat, 13 Oct 2012 10:24:02 -0400 Message-ID: <1350138242.24256.114.camel@gandalf.local.home> References: <20121013022632.024527228@goodmis.org> <1762180.8nMW7nCt7B@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1762180.8nMW7nCt7B@wuerfel> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Andrew Morton , Andy Whitcroft List-Id: linux-arch.vger.kernel.org On Sat, 2012-10-13 at 09:09 +0000, Arnd Bergmann wrote: > Note that while you are addressing all the obvious candidates that > have only a single #include statement in them, there is room to take > this further because a lot of the other header files in architectures > are still identical to their asm-generic counterparts (aside from > whitespace and comments). I would recommend to arch maintainers that > have not already done so to go through all the headers and replace > the identical ones with generated headers that include the asm-generic > version. I was thinking of doing this as a "take 2", after this set got in. I'm not sure if it's already there or not, but perhaps checkpatch could add a way to see if a new file is created in arch/*/include/asm/* that only adds an include of asm-generic (ignoring the #ifndef _FOO_H wrappers), and tell the user to use the generic-y += in Kbuild method. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:4680 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753118Ab2JMOYE (ORCPT ); Sat, 13 Oct 2012 10:24:04 -0400 Message-ID: <1350138242.24256.114.camel@gandalf.local.home> Subject: Re: [PATCH 00/25] asm-generic: Convert all to use Kbuild file From: Steven Rostedt Date: Sat, 13 Oct 2012 10:24:02 -0400 In-Reply-To: <1762180.8nMW7nCt7B@wuerfel> References: <20121013022632.024527228@goodmis.org> <1762180.8nMW7nCt7B@wuerfel> Content-Type: text/plain; charset="ISO-8859-15" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Andrew Morton , Andy Whitcroft Message-ID: <20121013142402.lKk2tL-vWCFnkVFR5CRDfY3JrHBtITOBhYG3_u8ZrJU@z> On Sat, 2012-10-13 at 09:09 +0000, Arnd Bergmann wrote: > Note that while you are addressing all the obvious candidates that > have only a single #include statement in them, there is room to take > this further because a lot of the other header files in architectures > are still identical to their asm-generic counterparts (aside from > whitespace and comments). I would recommend to arch maintainers that > have not already done so to go through all the headers and replace > the identical ones with generated headers that include the asm-generic > version. I was thinking of doing this as a "take 2", after this set got in. I'm not sure if it's already there or not, but perhaps checkpatch could add a way to see if a new file is created in arch/*/include/asm/* that only adds an include of asm-generic (ignoring the #ifndef _FOO_H wrappers), and tell the user to use the generic-y += in Kbuild method. -- Steve