From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: [RESEND PATCH 1/4] asm-generic: io: remove {read,write} string functions Date: Wed, 17 Oct 2012 16:45:01 +0100 Message-ID: <1350488704-3711-2-git-send-email-will.deacon@arm.com> References: <1350488704-3711-1-git-send-email-will.deacon@arm.com> Return-path: In-Reply-To: <1350488704-3711-1-git-send-email-will.deacon@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Cc: Will Deacon , Arnd Bergmann , Mike Frysinger , Ben Herrenschmidt List-Id: linux-arch.vger.kernel.org The {read,write}s{b,w,l} functions are not defined across all architectures and therefore shouldn't be used by portable drivers. We should encourage driver writers to use the io{read,write}{8,16,32}_rep functions instead. This patch removes the {read,write} string functions for the generic IO header as they have no place in a new architecture port. Cc: Arnd Bergmann Cc: Mike Frysinger Cc: Ben Herrenschmidt Signed-off-by: Will Deacon --- include/asm-generic/io.h | 30 ------------------------------ 1 files changed, 0 insertions(+), 30 deletions(-) diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h index 448303b..3607921 100644 --- a/include/asm-generic/io.h +++ b/include/asm-generic/io.h @@ -217,36 +217,6 @@ static inline void outsl(unsigned long addr, const void *buffer, int count) } #endif -static inline void readsl(const void __iomem *addr, void *buf, int len) -{ - insl(addr - PCI_IOBASE, buf, len); -} - -static inline void readsw(const void __iomem *addr, void *buf, int len) -{ - insw(addr - PCI_IOBASE, buf, len); -} - -static inline void readsb(const void __iomem *addr, void *buf, int len) -{ - insb(addr - PCI_IOBASE, buf, len); -} - -static inline void writesl(const void __iomem *addr, const void *buf, int len) -{ - outsl(addr - PCI_IOBASE, buf, len); -} - -static inline void writesw(const void __iomem *addr, const void *buf, int len) -{ - outsw(addr - PCI_IOBASE, buf, len); -} - -static inline void writesb(const void __iomem *addr, const void *buf, int len) -{ - outsb(addr - PCI_IOBASE, buf, len); -} - #ifndef CONFIG_GENERIC_IOMAP #define ioread8(addr) readb(addr) #define ioread16(addr) readw(addr) -- 1.7.4.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:40058 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932343Ab2JQPpU (ORCPT ); Wed, 17 Oct 2012 11:45:20 -0400 From: Will Deacon Subject: [RESEND PATCH 1/4] asm-generic: io: remove {read,write} string functions Date: Wed, 17 Oct 2012 16:45:01 +0100 Message-ID: <1350488704-3711-2-git-send-email-will.deacon@arm.com> In-Reply-To: <1350488704-3711-1-git-send-email-will.deacon@arm.com> References: <1350488704-3711-1-git-send-email-will.deacon@arm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Cc: Will Deacon , Arnd Bergmann , Mike Frysinger , Ben Herrenschmidt Message-ID: <20121017154501.pCwtulnJXdI7mpqojsUMDVVLhyQqaG6G9Fbycx1Kjsk@z> The {read,write}s{b,w,l} functions are not defined across all architectures and therefore shouldn't be used by portable drivers. We should encourage driver writers to use the io{read,write}{8,16,32}_rep functions instead. This patch removes the {read,write} string functions for the generic IO header as they have no place in a new architecture port. Cc: Arnd Bergmann Cc: Mike Frysinger Cc: Ben Herrenschmidt Signed-off-by: Will Deacon --- include/asm-generic/io.h | 30 ------------------------------ 1 files changed, 0 insertions(+), 30 deletions(-) diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h index 448303b..3607921 100644 --- a/include/asm-generic/io.h +++ b/include/asm-generic/io.h @@ -217,36 +217,6 @@ static inline void outsl(unsigned long addr, const void *buffer, int count) } #endif -static inline void readsl(const void __iomem *addr, void *buf, int len) -{ - insl(addr - PCI_IOBASE, buf, len); -} - -static inline void readsw(const void __iomem *addr, void *buf, int len) -{ - insw(addr - PCI_IOBASE, buf, len); -} - -static inline void readsb(const void __iomem *addr, void *buf, int len) -{ - insb(addr - PCI_IOBASE, buf, len); -} - -static inline void writesl(const void __iomem *addr, const void *buf, int len) -{ - outsl(addr - PCI_IOBASE, buf, len); -} - -static inline void writesw(const void __iomem *addr, const void *buf, int len) -{ - outsw(addr - PCI_IOBASE, buf, len); -} - -static inline void writesb(const void __iomem *addr, const void *buf, int len) -{ - outsb(addr - PCI_IOBASE, buf, len); -} - #ifndef CONFIG_GENERIC_IOMAP #define ioread8(addr) readb(addr) #define ioread16(addr) readw(addr) -- 1.7.4.1