From: Jonas Bonn <jonas@southpole.se>
To: James Hogan <james.hogan@imgtec.com>
Cc: linux-arch@vger.kernel.org, linux-xtensa@linux-xtensa.org,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Mike Frysinger <vapier@gentoo.org>, Arnd Bergmann <arnd@arndb.de>,
Chris Zankel <chris@zankel.net>,
linux-kernel@vger.kernel.org, Max Filippov <jcmvbkbc@gmail.com>,
linux@lists.openrisc.net,
uclinux-dist-devel@blackfin.uclinux.org,
Chen Liqin <liqin.chen@sunplusct.com>,
Lennox Wu <lennox.wu@gmail.com>
Subject: Re: [PATCH] asm-generic/io.h: remove asm/cacheflush.h include
Date: Thu, 25 Oct 2012 15:40:16 +0200 [thread overview]
Message-ID: <1351172416.6232.70.camel@jerome.southpole.se> (raw)
In-Reply-To: <1350984117-17369-1-git-send-email-james.hogan@imgtec.com>
[-- Attachment #1.1: Type: text/plain, Size: 978 bytes --]
On Tue, 2012-10-23 at 10:21 +0100, James Hogan wrote:
> Including <asm/cacheflush.h> from <asm-generic/io.h> prevents
> cacheflush.h being able to use I/O functions like readl and writel due
> to circular include dependencies. It doesn't appear as if anything from
> cacheflush.h is actually used by the generic io.h, so remove the
> include.
>
> I've compile tested a defconfig compilation of blackfin, openrisc (which
> needed <asm/pgtable.h> including from it's <asm/io.h> to get the PAGE_*
> definitions), and xtensa.
>
> Other architectures which use asm-generic/io.h are score and unicore32,
> and looking at their io.h I don't see any obvious problems.
Acked-by: Jonas Bonn <jonas@southpole.se> for OpenRISC
Who's tree should this go via. I can take it via the openrisc tree, but
it would be good to get some Ack's that this isn't going to break things
for the other arch's (in particular score and unicore32, since they are
untested).
/Jonas
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Jonas Bonn <jonas@southpole.se>
To: James Hogan <james.hogan@imgtec.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux@lists.openrisc.net,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
linux-xtensa@linux-xtensa.org, Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
Mike Frysinger <vapier@gentoo.org>,
Chen Liqin <liqin.chen@sunplusct.com>,
Lennox Wu <lennox.wu@gmail.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>
Subject: Re: [PATCH] asm-generic/io.h: remove asm/cacheflush.h include
Date: Thu, 25 Oct 2012 15:40:16 +0200 [thread overview]
Message-ID: <1351172416.6232.70.camel@jerome.southpole.se> (raw)
Message-ID: <20121025134016.QBrQgOsNbertMKo3Ao1OkPb-Aau8st2VhHOby3kAZiQ@z> (raw)
In-Reply-To: <1350984117-17369-1-git-send-email-james.hogan@imgtec.com>
[-- Attachment #1: Type: text/plain, Size: 978 bytes --]
On Tue, 2012-10-23 at 10:21 +0100, James Hogan wrote:
> Including <asm/cacheflush.h> from <asm-generic/io.h> prevents
> cacheflush.h being able to use I/O functions like readl and writel due
> to circular include dependencies. It doesn't appear as if anything from
> cacheflush.h is actually used by the generic io.h, so remove the
> include.
>
> I've compile tested a defconfig compilation of blackfin, openrisc (which
> needed <asm/pgtable.h> including from it's <asm/io.h> to get the PAGE_*
> definitions), and xtensa.
>
> Other architectures which use asm-generic/io.h are score and unicore32,
> and looking at their io.h I don't see any obvious problems.
Acked-by: Jonas Bonn <jonas@southpole.se> for OpenRISC
Who's tree should this go via. I can take it via the openrisc tree, but
it would be good to get some Ack's that this isn't going to break things
for the other arch's (in particular score and unicore32, since they are
untested).
/Jonas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-10-25 13:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 9:21 [PATCH] asm-generic/io.h: remove asm/cacheflush.h include James Hogan
2012-10-23 9:21 ` James Hogan
2012-10-25 13:40 ` Jonas Bonn [this message]
2012-10-25 13:40 ` Jonas Bonn
2012-10-25 14:07 ` Arnd Bergmann
2012-10-25 14:07 ` Arnd Bergmann
2012-10-25 14:07 ` James Hogan
2012-10-25 14:07 ` James Hogan
2012-10-25 14:10 ` Arnd Bergmann
2012-10-25 14:10 ` Arnd Bergmann
2012-10-25 21:19 ` Max Filippov
2012-10-29 1:28 ` guanxuetao
2012-10-29 1:28 ` guanxuetao
2012-10-29 9:28 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351172416.6232.70.camel@jerome.southpole.se \
--to=jonas@southpole.se \
--cc=arnd@arndb.de \
--cc=chris@zankel.net \
--cc=gxt@mprc.pku.edu.cn \
--cc=james.hogan@imgtec.com \
--cc=jcmvbkbc@gmail.com \
--cc=lennox.wu@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@lists.openrisc.net \
--cc=liqin.chen@sunplusct.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).