From: Stephen Warren <swarren@wwwdotorg.org>
To: Russell King <linux@arm.linux.org.uk>
Cc: Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
John Stultz <johnstul@us.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Stephen Warren <swarren@nvidia.com>
Subject: [PATCH V3 10/11] ARM: remove struct sys_timer suspend and resume fields
Date: Mon, 19 Nov 2012 11:31:06 -0700 [thread overview]
Message-ID: <1353349867-28494-11-git-send-email-swarren@wwwdotorg.org> (raw)
In-Reply-To: <1353349867-28494-1-git-send-email-swarren@wwwdotorg.org>
From: Stephen Warren <swarren@nvidia.com>
These fields duplicate e.g. struct clock_event_device's suspend and
resume fields, so remove them now that nothing is using them. The aim
is to remove all fields from struct sys_timer except .init, then replace
the ARM machine descriptor's .timer field with a .init_time function
instead, and delete struct sys_timer.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
arch/arm/include/asm/mach/time.h | 11 -----------
arch/arm/kernel/time.c | 34 ----------------------------------
2 files changed, 45 deletions(-)
diff --git a/arch/arm/include/asm/mach/time.h b/arch/arm/include/asm/mach/time.h
index cac8d9c..d316d76 100644
--- a/arch/arm/include/asm/mach/time.h
+++ b/arch/arm/include/asm/mach/time.h
@@ -17,15 +17,6 @@
* Initialise the kernels jiffy timer source, claim interrupt
* using setup_irq. This is called early on during initialisation
* while interrupts are still disabled on the local CPU.
- * - suspend
- * Suspend the kernel jiffy timer source, if necessary. This
- * is called with interrupts disabled, after all normal devices
- * have been suspended. If no action is required, set this to
- * NULL.
- * - resume
- * Resume the kernel jiffy timer source, if necessary. This
- * is called with interrupts disabled before any normal devices
- * are resumed. If no action is required, set this to NULL.
* - offset
* Return the timer offset in microseconds since the last timer
* interrupt. Note: this must take account of any unprocessed
@@ -33,8 +24,6 @@
*/
struct sys_timer {
void (*init)(void);
- void (*suspend)(void);
- void (*resume)(void);
};
extern void timer_tick(void);
diff --git a/arch/arm/kernel/time.c b/arch/arm/kernel/time.c
index ea36bfa..0b51a7c 100644
--- a/arch/arm/kernel/time.c
+++ b/arch/arm/kernel/time.c
@@ -21,7 +21,6 @@
#include <linux/timex.h>
#include <linux/errno.h>
#include <linux/profile.h>
-#include <linux/syscore_ops.h>
#include <linux/timer.h>
#include <linux/irq.h>
@@ -119,39 +118,6 @@ int __init register_persistent_clock(clock_access_fn read_boot,
return -EINVAL;
}
-#if defined(CONFIG_PM) && !defined(CONFIG_GENERIC_CLOCKEVENTS)
-static int timer_suspend(void)
-{
- if (system_timer->suspend)
- system_timer->suspend();
-
- return 0;
-}
-
-static void timer_resume(void)
-{
- if (system_timer->resume)
- system_timer->resume();
-}
-#else
-#define timer_suspend NULL
-#define timer_resume NULL
-#endif
-
-static struct syscore_ops timer_syscore_ops = {
- .suspend = timer_suspend,
- .resume = timer_resume,
-};
-
-static int __init timer_init_syscore_ops(void)
-{
- register_syscore_ops(&timer_syscore_ops);
-
- return 0;
-}
-
-device_initcall(timer_init_syscore_ops);
-
void __init time_init(void)
{
system_timer = machine_desc->timer;
--
1.7.10.4
next prev parent reply other threads:[~2012-11-19 18:31 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 18:30 [PATCH V3 00/11] ARM: delete struct sys_timer Stephen Warren
2012-11-19 18:30 ` Stephen Warren
2012-11-19 18:30 ` [PATCH V3 01/11] cris: move usec/nsec conversion to do_slow_gettimeoffset Stephen Warren
2012-11-19 18:30 ` [PATCH V3 02/11] time: convert arch_gettimeoffset to a pointer Stephen Warren
2012-11-19 18:30 ` Stephen Warren
2012-11-19 18:30 ` [PATCH V3 03/11] m68k: set arch_gettimeoffset directly Stephen Warren
2012-11-19 18:30 ` Stephen Warren
2012-11-19 18:31 ` [PATCH V3 04/11] ARM: " Stephen Warren
2012-11-19 18:31 ` Stephen Warren
2012-11-19 18:31 ` [PATCH V3 05/11] ARM: at91: convert timer suspend/resume to clock_event_device Stephen Warren
2012-11-19 18:31 ` Stephen Warren
2012-11-19 18:31 ` [PATCH V3 06/11] ARM: pxa: " Stephen Warren
2012-11-19 18:31 ` Stephen Warren
2012-11-19 18:31 ` [PATCH V3 07/11] ARM: sa1100: " Stephen Warren
2012-11-19 18:31 ` Stephen Warren
2012-11-19 18:31 ` [PATCH V3 08/11] ARM: ux500: " Stephen Warren
2012-11-19 18:31 ` Stephen Warren
2012-11-21 8:14 ` Linus Walleij
2012-11-21 8:14 ` Linus Walleij
2012-11-19 18:31 ` [PATCH V3 09/11] ARM: samsung: register syscore_ops for timer resume directly Stephen Warren
2012-11-19 18:31 ` Stephen Warren
2012-11-19 18:31 ` Stephen Warren [this message]
2012-11-19 18:31 ` [PATCH V3 10/11] ARM: remove struct sys_timer suspend and resume fields Stephen Warren
2012-11-21 8:21 ` Linus Walleij
2012-11-21 8:28 ` Linus Walleij
2012-11-26 19:25 ` Stephen Warren
2012-11-26 21:26 ` Linus Walleij
2012-11-19 18:31 ` [PATCH V3 11/11] ARM: delete struct sys_timer Stephen Warren
2012-11-21 4:43 ` Haojian Zhuang
2012-11-21 4:43 ` Haojian Zhuang
2012-11-26 19:15 ` Stephen Warren
2012-11-26 19:15 ` Stephen Warren
2012-12-07 9:51 ` Igor Grinberg
2012-12-07 17:08 ` Stephen Warren
2012-12-24 16:40 ` [PATCH V3 00/11] " Stephen Warren
2012-12-24 16:40 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353349867-28494-11-git-send-email-swarren@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=arnd@arndb.de \
--cc=johnstul@us.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=swarren@nvidia.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).