From: Stephen Warren <swarren@wwwdotorg.org>
To: Russell King <linux@arm.linux.org.uk>
Cc: Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
John Stultz <johnstul@us.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Stephen Warren <swarren@nvidia.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>
Subject: [PATCH V3 06/11] ARM: pxa: convert timer suspend/resume to clock_event_device
Date: Mon, 19 Nov 2012 11:31:02 -0700 [thread overview]
Message-ID: <1353349867-28494-7-git-send-email-swarren@wwwdotorg.org> (raw)
In-Reply-To: <1353349867-28494-1-git-send-email-swarren@wwwdotorg.org>
From: Stephen Warren <swarren@nvidia.com>
Move PXA's timer suspend/resume functions from struct sys_timer
pxa_timer into struct clock_event_device ckevt_pxa_osmr0. This
will allow the sys_timer suspend/resume fields to be removed, and
eventually lead to a complete removal of struct sys_timer.
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
Acked-by: Eric Miao <eric.y.miao@gmail.com>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
arch/arm/mach-pxa/time.c | 76 +++++++++++++++++++++++-----------------------
1 file changed, 38 insertions(+), 38 deletions(-)
diff --git a/arch/arm/mach-pxa/time.c b/arch/arm/mach-pxa/time.c
index 4bc47d6..ce58bc9 100644
--- a/arch/arm/mach-pxa/time.c
+++ b/arch/arm/mach-pxa/time.c
@@ -89,12 +89,50 @@ pxa_osmr0_set_mode(enum clock_event_mode mode, struct clock_event_device *dev)
}
}
+#ifdef CONFIG_PM
+static unsigned long osmr[4], oier, oscr;
+
+static void pxa_timer_suspend(struct clock_event_device *cedev)
+{
+ osmr[0] = readl_relaxed(OSMR0);
+ osmr[1] = readl_relaxed(OSMR1);
+ osmr[2] = readl_relaxed(OSMR2);
+ osmr[3] = readl_relaxed(OSMR3);
+ oier = readl_relaxed(OIER);
+ oscr = readl_relaxed(OSCR);
+}
+
+static void pxa_timer_resume(struct clock_event_device *cedev)
+{
+ /*
+ * Ensure that we have at least MIN_OSCR_DELTA between match
+ * register 0 and the OSCR, to guarantee that we will receive
+ * the one-shot timer interrupt. We adjust OSMR0 in preference
+ * to OSCR to guarantee that OSCR is monotonically incrementing.
+ */
+ if (osmr[0] - oscr < MIN_OSCR_DELTA)
+ osmr[0] += MIN_OSCR_DELTA;
+
+ writel_relaxed(osmr[0], OSMR0);
+ writel_relaxed(osmr[1], OSMR1);
+ writel_relaxed(osmr[2], OSMR2);
+ writel_relaxed(osmr[3], OSMR3);
+ writel_relaxed(oier, OIER);
+ writel_relaxed(oscr, OSCR);
+}
+#else
+#define pxa_timer_suspend NULL
+#define pxa_timer_resume NULL
+#endif
+
static struct clock_event_device ckevt_pxa_osmr0 = {
.name = "osmr0",
.features = CLOCK_EVT_FEAT_ONESHOT,
.rating = 200,
.set_next_event = pxa_osmr0_set_next_event,
.set_mode = pxa_osmr0_set_mode,
+ .suspend = pxa_timer_suspend,
+ .resume = pxa_timer_resume,
};
static struct irqaction pxa_ost0_irq = {
@@ -127,44 +165,6 @@ static void __init pxa_timer_init(void)
clockevents_register_device(&ckevt_pxa_osmr0);
}
-#ifdef CONFIG_PM
-static unsigned long osmr[4], oier, oscr;
-
-static void pxa_timer_suspend(void)
-{
- osmr[0] = readl_relaxed(OSMR0);
- osmr[1] = readl_relaxed(OSMR1);
- osmr[2] = readl_relaxed(OSMR2);
- osmr[3] = readl_relaxed(OSMR3);
- oier = readl_relaxed(OIER);
- oscr = readl_relaxed(OSCR);
-}
-
-static void pxa_timer_resume(void)
-{
- /*
- * Ensure that we have at least MIN_OSCR_DELTA between match
- * register 0 and the OSCR, to guarantee that we will receive
- * the one-shot timer interrupt. We adjust OSMR0 in preference
- * to OSCR to guarantee that OSCR is monotonically incrementing.
- */
- if (osmr[0] - oscr < MIN_OSCR_DELTA)
- osmr[0] += MIN_OSCR_DELTA;
-
- writel_relaxed(osmr[0], OSMR0);
- writel_relaxed(osmr[1], OSMR1);
- writel_relaxed(osmr[2], OSMR2);
- writel_relaxed(osmr[3], OSMR3);
- writel_relaxed(oier, OIER);
- writel_relaxed(oscr, OSCR);
-}
-#else
-#define pxa_timer_suspend NULL
-#define pxa_timer_resume NULL
-#endif
-
struct sys_timer pxa_timer = {
.init = pxa_timer_init,
- .suspend = pxa_timer_suspend,
- .resume = pxa_timer_resume,
};
--
1.7.10.4
next prev parent reply other threads:[~2012-11-19 18:31 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 18:30 [PATCH V3 00/11] ARM: delete struct sys_timer Stephen Warren
2012-11-19 18:30 ` Stephen Warren
2012-11-19 18:30 ` [PATCH V3 01/11] cris: move usec/nsec conversion to do_slow_gettimeoffset Stephen Warren
2012-11-19 18:30 ` [PATCH V3 02/11] time: convert arch_gettimeoffset to a pointer Stephen Warren
2012-11-19 18:30 ` Stephen Warren
2012-11-19 18:30 ` [PATCH V3 03/11] m68k: set arch_gettimeoffset directly Stephen Warren
2012-11-19 18:30 ` Stephen Warren
2012-11-19 18:31 ` [PATCH V3 04/11] ARM: " Stephen Warren
2012-11-19 18:31 ` Stephen Warren
2012-11-19 18:31 ` [PATCH V3 05/11] ARM: at91: convert timer suspend/resume to clock_event_device Stephen Warren
2012-11-19 18:31 ` Stephen Warren
2012-11-19 18:31 ` Stephen Warren [this message]
2012-11-19 18:31 ` [PATCH V3 06/11] ARM: pxa: " Stephen Warren
2012-11-19 18:31 ` [PATCH V3 07/11] ARM: sa1100: " Stephen Warren
2012-11-19 18:31 ` Stephen Warren
2012-11-19 18:31 ` [PATCH V3 08/11] ARM: ux500: " Stephen Warren
2012-11-19 18:31 ` Stephen Warren
2012-11-21 8:14 ` Linus Walleij
2012-11-21 8:14 ` Linus Walleij
2012-11-19 18:31 ` [PATCH V3 09/11] ARM: samsung: register syscore_ops for timer resume directly Stephen Warren
2012-11-19 18:31 ` Stephen Warren
2012-11-19 18:31 ` [PATCH V3 10/11] ARM: remove struct sys_timer suspend and resume fields Stephen Warren
2012-11-19 18:31 ` Stephen Warren
2012-11-21 8:21 ` Linus Walleij
2012-11-21 8:28 ` Linus Walleij
2012-11-26 19:25 ` Stephen Warren
2012-11-26 21:26 ` Linus Walleij
2012-11-19 18:31 ` [PATCH V3 11/11] ARM: delete struct sys_timer Stephen Warren
2012-11-21 4:43 ` Haojian Zhuang
2012-11-21 4:43 ` Haojian Zhuang
2012-11-26 19:15 ` Stephen Warren
2012-11-26 19:15 ` Stephen Warren
2012-12-07 9:51 ` Igor Grinberg
2012-12-07 17:08 ` Stephen Warren
2012-12-24 16:40 ` [PATCH V3 00/11] " Stephen Warren
2012-12-24 16:40 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353349867-28494-7-git-send-email-swarren@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=arnd@arndb.de \
--cc=haojian.zhuang@gmail.com \
--cc=johnstul@us.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=swarren@nvidia.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).