linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, mingo@redhat.com, x86@kernel.org
Cc: rth@twiddle.net, linux@arm.linux.org.uk, msalter@redhat.com,
	starvik@axis.com, dhowells@redhat.com, tony.luck@intel.com,
	benh@kernel.crashing.org, takata@linux-m32r.org,
	geert@linux-m68k.org, james.hogan@imgtec.com, monstr@monstr.eu,
	ralf@linux-mips.org, jonas@southpole.se, rkuo@codeaurora.org,
	schwidefsky@de.ibm.com, liqin.chen@sunplusct.com,
	davem@davemloft.net, lethal@linux-sh.org, vgupta@synopsys.com,
	chris@zankel.net, cmetcalf@tilera.com,
	ysato@users.sourceforge.jp, gxt@mprc.pku.edu.cn,
	jdike@addtoit.com, Tejun Heo <tj@kernel.org>
Subject: [PATCH 2/5] sparc32: make show_stack() acquire %fp if @_ksp is not specified
Date: Fri, 29 Mar 2013 19:27:05 -0700	[thread overview]
Message-ID: <1364610428-2074-3-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1364610428-2074-1-git-send-email-tj@kernel.org>

show_stack(current or NULL, NULL) is used by arch-independent code to
dump backtrace of the current task; however, sparc32 show_stack()
doesn't implement it and wouldn't print any backtrace when NULL @_ksp
is specfied.

Make show_stack() acquire and use %fp if @tsk is NULL or current and
@_ksp is NULL.  This makes %fp fetching in dump_stack() unnecessary.
Make it use NULL for @_ksp instead.

Only compile tested.

Signed-off-by: Tejun Heo <tj@kernel.org>
---
 arch/sparc/kernel/process_32.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/arch/sparc/kernel/process_32.c b/arch/sparc/kernel/process_32.c
index 62eede1..0d57b24 100644
--- a/arch/sparc/kernel/process_32.c
+++ b/arch/sparc/kernel/process_32.c
@@ -153,11 +153,13 @@ void show_stack(struct task_struct *tsk, unsigned long *_ksp)
 	struct reg_window32 *rw;
 	int count = 0;
 
-	if (tsk != NULL)
-		task_base = (unsigned long) task_stack_page(tsk);
-	else
-		task_base = (unsigned long) current_thread_info();
+	if (!tsk)
+		tsk = current;
 
+	if (tsk == current && !_ksp)
+		__asm__ __volatile__("mov	%%fp, %0" : "=r" (_ksp));
+
+	task_base = (unsigned long) task_stack_page(tsk);
 	fp = (unsigned long) _ksp;
 	do {
 		/* Bogus frame pointer? */
@@ -175,11 +177,7 @@ void show_stack(struct task_struct *tsk, unsigned long *_ksp)
 
 void dump_stack(void)
 {
-	unsigned long *ksp;
-
-	__asm__ __volatile__("mov	%%fp, %0"
-			     : "=r" (ksp));
-	show_stack(current, ksp);
+	show_stack(current, NULL);
 }
 
 EXPORT_SYMBOL(dump_stack);
-- 
1.8.1.4

  parent reply	other threads:[~2013-03-30  2:27 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-30  2:27 [PATCHSET] arch: unify task dump debug info Tejun Heo
2013-03-30  2:27 ` [PATCH 1/5] x86: don't show trace beyond show_stack(NULL, NULL) Tejun Heo
2013-03-30  2:27 ` Tejun Heo [this message]
2013-03-30  3:29   ` [PATCH 2/5] sparc32: make show_stack() acquire %fp if @_ksp is not specified David Miller
2013-03-30  2:27 ` [PATCH 3/5] dump_stack: consolidate dump_stack() implementations and unify their behaviors Tejun Heo
2013-03-30  2:27   ` Tejun Heo
2013-03-30  3:30   ` David Miller
2013-03-30  5:27   ` Vineet Gupta
2013-03-30 11:45   ` Heiko Carstens
2013-04-02  6:48     ` Martin Schwidefsky
2013-04-02 18:26       ` Tejun Heo
2013-04-02  9:22   ` Jesper Nilsson
2013-04-16 14:59   ` James Hogan
2013-03-30  2:27 ` [PATCH 4/5] dump_stack: implement arch-specific hardware description in task dumps Tejun Heo
2013-03-30  2:27   ` Tejun Heo
2013-04-01 18:11   ` Bjorn Helgaas
2013-04-01 18:11     ` Bjorn Helgaas
2013-04-02 18:24     ` Tejun Heo
2013-04-02 18:24       ` Tejun Heo
2013-03-30  2:27 ` [PATCH 5/5] dump_stack: unify debug information printed by show_regs() Tejun Heo
2013-03-30  2:27   ` Tejun Heo
2013-03-30  3:24   ` [PATCH v2 " Tejun Heo
2013-03-30  3:30     ` David Miller
2013-03-30  6:13     ` Vineet Gupta
2013-04-02 18:07       ` Tejun Heo
2013-04-02  9:21     ` Jesper Nilsson
2013-04-02  9:21       ` Jesper Nilsson
2013-04-03  4:57     ` Vineet Gupta
2013-04-16 15:05     ` James Hogan
2013-04-02  9:24 ` [PATCHSET] arch: unify task dump debug info David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364610428-2074-3-git-send-email-tj@kernel.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=chris@zankel.net \
    --cc=cmetcalf@tilera.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=james.hogan@imgtec.com \
    --cc=jdike@addtoit.com \
    --cc=jonas@southpole.se \
    --cc=lethal@linux-sh.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=liqin.chen@sunplusct.com \
    --cc=mingo@redhat.com \
    --cc=monstr@monstr.eu \
    --cc=msalter@redhat.com \
    --cc=ralf@linux-mips.org \
    --cc=rkuo@codeaurora.org \
    --cc=rth@twiddle.net \
    --cc=schwidefsky@de.ibm.com \
    --cc=starvik@axis.com \
    --cc=takata@linux-m32r.org \
    --cc=tony.luck@intel.com \
    --cc=vgupta@synopsys.com \
    --cc=x86@kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).