From: Oskar Andero <oskar.andero@sonymobile.com>
To: linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
davem@davemloft.net, anil.s.keshavamurthy@intel.com,
ananth@in.ibm.com, Joonsoo Kim <iamjoonsoo.kim@lge.com>,
radovan.lekanovic@sonymobile.com, bjorn.davidsson@sonymobile.com,
oskar.andero@sonymobile.com
Subject: [PATCH v3 3/4] kprobes: move x86-specific blacklist symbols to arch directory
Date: Fri, 5 Apr 2013 15:26:39 +0200 [thread overview]
Message-ID: <1365168400-17954-4-git-send-email-oskar.andero@sonymobile.com> (raw)
In-Reply-To: <1365168400-17954-1-git-send-email-oskar.andero@sonymobile.com>
From: Björn Davidsson <bjorn.davidsson@sonymobile.com>
The common kprobes blacklist contains x86-specific symbols.
Looking for these in kallsyms takes unnecessary time during startup
on non-X86 platform. The symbols where moved to
arch/x86/kernel/kprobes/core.c.
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: linux-arch@vger.kernel.org
Reviewed-by: Radovan Lekanovic <radovan.lekanovic@sonymobile.com>
Signed-off-by: Björn Davidsson <bjorn.davidsson@sonymobile.com>
Signed-off-by: Oskar Andero <oskar.andero@sonymobile.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
---
arch/x86/kernel/kprobes/core.c | 7 +++++++
kernel/kprobes.c | 3 ---
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c
index 7bfe318..41ce6c1 100644
--- a/arch/x86/kernel/kprobes/core.c
+++ b/arch/x86/kernel/kprobes/core.c
@@ -65,6 +65,13 @@ void jprobe_return_end(void);
DEFINE_PER_CPU(struct kprobe *, current_kprobe) = NULL;
DEFINE_PER_CPU(struct kprobe_ctlblk, kprobe_ctlblk);
+const char * const arch_kprobes_blacksyms[] = {
+ "native_get_debugreg",
+ "irq_entries_start",
+ "common_interrupt",
+};
+const size_t arch_kprobes_blacksyms_size = ARRAY_SIZE(arch_kprobes_blacksyms);
+
#define stack_addr(regs) ((unsigned long *)kernel_stack_pointer(regs))
#define W(row, b0, b1, b2, b3, b4, b5, b6, b7, b8, b9, ba, bb, bc, bd, be, bf)\
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index 2458ae1..b289384 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -95,9 +95,6 @@ static raw_spinlock_t *kretprobe_table_lock_ptr(unsigned long hash)
*/
static const char * const common_kprobes_blacksyms[] = {
"preempt_schedule",
- "native_get_debugreg",
- "irq_entries_start",
- "common_interrupt",
"mcount", /* mcount can be called from everywhere */
};
static const size_t common_kprobes_blacksyms_size =
--
1.8.1.5
next prev parent reply other threads:[~2013-04-05 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 13:26 [PATCH v3 0/4] kprobes: split blacklist into common and arch Oskar Andero
2013-04-05 13:26 ` [PATCH v3 1/4] kprobes: delay blacklist symbol lookup until we actually need it Oskar Andero
2013-04-05 13:26 ` Oskar Andero
2013-04-08 10:58 ` Masami Hiramatsu
2013-04-08 10:58 ` Masami Hiramatsu
2013-04-05 13:26 ` [PATCH v3 2/4] kprobes: split blacklist into common and arch Oskar Andero
2013-04-05 13:26 ` Oskar Andero
2013-04-08 11:02 ` Masami Hiramatsu
2013-04-05 13:26 ` Oskar Andero [this message]
2013-04-05 13:26 ` [PATCH v3 3/4] kprobes: move x86-specific blacklist symbols to arch directory Oskar Andero
2013-04-05 13:26 ` [PATCH v3 4/4] kprobes: replace printk with pr_-functions Oskar Andero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365168400-17954-4-git-send-email-oskar.andero@sonymobile.com \
--to=oskar.andero@sonymobile.com \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=bjorn.davidsson@sonymobile.com \
--cc=davem@davemloft.net \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=radovan.lekanovic@sonymobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).