From: Jiang Liu <liuj97@gmail.com> To: Andrew Morton <akpm@linux-foundation.org> Cc: Jiang Liu <jiang.liu@huawei.com>, David Rientjes <rientjes@google.com>, Wen Congyang <wency@cn.fujitsu.com>, Mel Gorman <mgorman@suse.de>, Minchan Kim <minchan@kernel.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Michal Hocko <mhocko@suse.cz>, James Bottomley <James.Bottomley@HansenPartnership.com>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, David Howells <dhowells@redhat.com>, Mark Salter <msalter@redhat.com>, Jianguo Wu <wujianguo@huawei.com>, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Metcalf <cmetcalf@tilera.com>, Bjorn Helgaas <bhelgaas@google.com>, "David S. Miller" <davem@davemloft.net> Subject: [PATCH v4, part3 36/41] mm/tile: prepare for removing num_physpages and simplify mem_init() Date: Sat, 6 Apr 2013 22:32:35 +0800 [thread overview] Message-ID: <1365258760-30821-37-git-send-email-jiang.liu@huawei.com> (raw) In-Reply-To: <1365258760-30821-1-git-send-email-jiang.liu@huawei.com> Prepare for removing num_physpages and simplify mem_init(). Signed-off-by: Jiang Liu <jiang.liu@huawei.com> Cc: Chris Metcalf <cmetcalf@tilera.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Wen Congyang <wency@cn.fujitsu.com> Cc: linux-kernel@vger.kernel.org --- arch/tile/kernel/setup.c | 16 ++++++++-------- arch/tile/mm/init.c | 15 +-------------- 2 files changed, 9 insertions(+), 22 deletions(-) diff --git a/arch/tile/kernel/setup.c b/arch/tile/kernel/setup.c index a986b71..54469a5 100644 --- a/arch/tile/kernel/setup.c +++ b/arch/tile/kernel/setup.c @@ -329,6 +329,7 @@ static void __init setup_memory(void) #if defined(CONFIG_HIGHMEM) || defined(__tilegx__) long lowmem_pages; #endif + unsigned long physpages = 0; /* We are using a char to hold the cpu_2_node[] mapping */ BUILD_BUG_ON(MAX_NUMNODES > 127); @@ -388,8 +389,8 @@ static void __init setup_memory(void) continue; } } - if (num_physpages + PFN_DOWN(range.size) > maxmem_pfn) { - int max_size = maxmem_pfn - num_physpages; + if (physpages + PFN_DOWN(range.size) > maxmem_pfn) { + int max_size = maxmem_pfn - physpages; if (max_size > 0) { pr_err("Maxmem reduced node %d to %d pages\n", i, max_size); @@ -446,7 +447,7 @@ static void __init setup_memory(void) node_start_pfn[i] = start; node_end_pfn[i] = end; node_controller[i] = range.controller; - num_physpages += size; + physpages += size; max_pfn = end; /* Mark node as online */ @@ -465,7 +466,7 @@ static void __init setup_memory(void) * we're willing to use at 8 million pages (32GB of 4KB pages). */ cap = 8 * 1024 * 1024; /* 8 million pages */ - if (num_physpages > cap) { + if (physpages > cap) { int num_nodes = num_online_nodes(); int cap_each = cap / num_nodes; unsigned long dropped_pages = 0; @@ -476,10 +477,10 @@ static void __init setup_memory(void) node_end_pfn[i] = node_start_pfn[i] + cap_each; } } - num_physpages -= dropped_pages; + physpages -= dropped_pages; pr_warning("Only using %ldMB memory;" " ignoring %ldMB.\n", - num_physpages >> (20 - PAGE_SHIFT), + physpages >> (20 - PAGE_SHIFT), dropped_pages >> (20 - PAGE_SHIFT)); pr_warning("Consider using a larger page size.\n"); } @@ -497,7 +498,7 @@ static void __init setup_memory(void) lowmem_pages = (mappable_physpages > MAXMEM_PFN) ? MAXMEM_PFN : mappable_physpages; - highmem_pages = (long) (num_physpages - lowmem_pages); + highmem_pages = (long) (physpages - lowmem_pages); pr_notice("%ldMB HIGHMEM available.\n", pages_to_mb(highmem_pages > 0 ? highmem_pages : 0)); @@ -514,7 +515,6 @@ static void __init setup_memory(void) pr_warning("Use a HIGHMEM enabled kernel.\n"); max_low_pfn = MAXMEM_PFN; max_pfn = MAXMEM_PFN; - num_physpages = MAXMEM_PFN; node_end_pfn[0] = MAXMEM_PFN; } else { pr_notice("%ldMB memory available.\n", diff --git a/arch/tile/mm/init.c b/arch/tile/mm/init.c index f2ac2f4..e182958 100644 --- a/arch/tile/mm/init.c +++ b/arch/tile/mm/init.c @@ -821,7 +821,6 @@ static void __init set_max_mapnr_init(void) void __init mem_init(void) { - int codesize, datasize, initsize; int i; #ifndef __tilegx__ void *last; @@ -853,19 +852,7 @@ void __init mem_init(void) set_non_bootmem_pages_init(); #endif - codesize = (unsigned long)&_etext - (unsigned long)&_text; - datasize = (unsigned long)&_end - (unsigned long)&_sdata; - initsize = (unsigned long)&_einittext - (unsigned long)&_sinittext; - initsize += (unsigned long)&_einitdata - (unsigned long)&_sinitdata; - - pr_info("Memory: %luk/%luk available (%dk kernel code, %dk data, %dk init, %ldk highmem)\n", - (unsigned long) nr_free_pages() << (PAGE_SHIFT-10), - num_physpages << (PAGE_SHIFT-10), - codesize >> 10, - datasize >> 10, - initsize >> 10, - (unsigned long) (totalhigh_pages << (PAGE_SHIFT-10)) - ); + mem_init_print_info(NULL); /* * In debug mode, dump some interesting memory mappings. -- 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Jiang Liu <liuj97@gmail.com> To: Andrew Morton <akpm@linux-foundation.org> Cc: Jiang Liu <jiang.liu@huawei.com>, David Rientjes <rientjes@google.com>, Wen Congyang <wency@cn.fujitsu.com>, Mel Gorman <mgorman@suse.de>, Minchan Kim <minchan@kernel.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Michal Hocko <mhocko@suse.cz>, James Bottomley <James.Bottomley@HansenPartnership.com>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, David Howells <dhowells@redhat.com>, Mark Salter <msalter@redhat.com>, Jianguo Wu <wujianguo@huawei.com>, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Metcalf <cmetcalf@tilera.com>, Bjorn Helgaas <bhelgaas@google.com>, "David S. Miller" <davem@davemloft.net> Subject: [PATCH v4, part3 36/41] mm/tile: prepare for removing num_physpages and simplify mem_init() Date: Sat, 6 Apr 2013 22:32:35 +0800 [thread overview] Message-ID: <1365258760-30821-37-git-send-email-jiang.liu@huawei.com> (raw) Message-ID: <20130406143235.kKIGXD1azJ90pixj8qTDG0-iw0zUtOSxl_71-_Pe-EE@z> (raw) In-Reply-To: <1365258760-30821-1-git-send-email-jiang.liu@huawei.com> Prepare for removing num_physpages and simplify mem_init(). Signed-off-by: Jiang Liu <jiang.liu@huawei.com> Cc: Chris Metcalf <cmetcalf@tilera.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Wen Congyang <wency@cn.fujitsu.com> Cc: linux-kernel@vger.kernel.org --- arch/tile/kernel/setup.c | 16 ++++++++-------- arch/tile/mm/init.c | 15 +-------------- 2 files changed, 9 insertions(+), 22 deletions(-) diff --git a/arch/tile/kernel/setup.c b/arch/tile/kernel/setup.c index a986b71..54469a5 100644 --- a/arch/tile/kernel/setup.c +++ b/arch/tile/kernel/setup.c @@ -329,6 +329,7 @@ static void __init setup_memory(void) #if defined(CONFIG_HIGHMEM) || defined(__tilegx__) long lowmem_pages; #endif + unsigned long physpages = 0; /* We are using a char to hold the cpu_2_node[] mapping */ BUILD_BUG_ON(MAX_NUMNODES > 127); @@ -388,8 +389,8 @@ static void __init setup_memory(void) continue; } } - if (num_physpages + PFN_DOWN(range.size) > maxmem_pfn) { - int max_size = maxmem_pfn - num_physpages; + if (physpages + PFN_DOWN(range.size) > maxmem_pfn) { + int max_size = maxmem_pfn - physpages; if (max_size > 0) { pr_err("Maxmem reduced node %d to %d pages\n", i, max_size); @@ -446,7 +447,7 @@ static void __init setup_memory(void) node_start_pfn[i] = start; node_end_pfn[i] = end; node_controller[i] = range.controller; - num_physpages += size; + physpages += size; max_pfn = end; /* Mark node as online */ @@ -465,7 +466,7 @@ static void __init setup_memory(void) * we're willing to use at 8 million pages (32GB of 4KB pages). */ cap = 8 * 1024 * 1024; /* 8 million pages */ - if (num_physpages > cap) { + if (physpages > cap) { int num_nodes = num_online_nodes(); int cap_each = cap / num_nodes; unsigned long dropped_pages = 0; @@ -476,10 +477,10 @@ static void __init setup_memory(void) node_end_pfn[i] = node_start_pfn[i] + cap_each; } } - num_physpages -= dropped_pages; + physpages -= dropped_pages; pr_warning("Only using %ldMB memory;" " ignoring %ldMB.\n", - num_physpages >> (20 - PAGE_SHIFT), + physpages >> (20 - PAGE_SHIFT), dropped_pages >> (20 - PAGE_SHIFT)); pr_warning("Consider using a larger page size.\n"); } @@ -497,7 +498,7 @@ static void __init setup_memory(void) lowmem_pages = (mappable_physpages > MAXMEM_PFN) ? MAXMEM_PFN : mappable_physpages; - highmem_pages = (long) (num_physpages - lowmem_pages); + highmem_pages = (long) (physpages - lowmem_pages); pr_notice("%ldMB HIGHMEM available.\n", pages_to_mb(highmem_pages > 0 ? highmem_pages : 0)); @@ -514,7 +515,6 @@ static void __init setup_memory(void) pr_warning("Use a HIGHMEM enabled kernel.\n"); max_low_pfn = MAXMEM_PFN; max_pfn = MAXMEM_PFN; - num_physpages = MAXMEM_PFN; node_end_pfn[0] = MAXMEM_PFN; } else { pr_notice("%ldMB memory available.\n", diff --git a/arch/tile/mm/init.c b/arch/tile/mm/init.c index f2ac2f4..e182958 100644 --- a/arch/tile/mm/init.c +++ b/arch/tile/mm/init.c @@ -821,7 +821,6 @@ static void __init set_max_mapnr_init(void) void __init mem_init(void) { - int codesize, datasize, initsize; int i; #ifndef __tilegx__ void *last; @@ -853,19 +852,7 @@ void __init mem_init(void) set_non_bootmem_pages_init(); #endif - codesize = (unsigned long)&_etext - (unsigned long)&_text; - datasize = (unsigned long)&_end - (unsigned long)&_sdata; - initsize = (unsigned long)&_einittext - (unsigned long)&_sinittext; - initsize += (unsigned long)&_einitdata - (unsigned long)&_sinitdata; - - pr_info("Memory: %luk/%luk available (%dk kernel code, %dk data, %dk init, %ldk highmem)\n", - (unsigned long) nr_free_pages() << (PAGE_SHIFT-10), - num_physpages << (PAGE_SHIFT-10), - codesize >> 10, - datasize >> 10, - initsize >> 10, - (unsigned long) (totalhigh_pages << (PAGE_SHIFT-10)) - ); + mem_init_print_info(NULL); /* * In debug mode, dump some interesting memory mappings. -- 1.7.9.5
next prev parent reply other threads:[~2013-04-06 14:32 UTC|newest] Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-04-06 14:31 [PATCH v4, part3 00/41] Simplify mem_init() implementations and kill num_physpages Jiang Liu 2013-04-06 14:31 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 01/41] vmlinux.lds: add comments for global variables and clean up useless declarations Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 02/41] avr32: normalize global variables exported by vmlinux.lds Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-07 8:00 ` Hans-Christian Egtvedt 2013-04-07 8:00 ` Hans-Christian Egtvedt 2013-04-06 14:32 ` [PATCH v4, part3 03/41] c6x: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 04/41] h8300: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 05/41] score: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 06/41] tile: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-12 20:54 ` Chris Metcalf 2013-04-06 14:32 ` [PATCH v4, part3 07/41] UML: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 08/41] mm: introduce helper function mem_init_print_info() to simplify mem_init() Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 09/41] mm: use totalram_pages instead of num_physpages at runtime Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 10/41] mm/hotplug: prepare for removing num_physpages Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 11/41] mm/alpha: prepare for removing num_physpages and simplify mem_init() Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 12/41] mm/ARC: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 13/41] mm/ARM: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-19 16:54 ` Russell King - ARM Linux 2013-04-20 15:19 ` Jiang Liu 2013-04-20 15:19 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 14/41] mm/ARM64: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 15/41] mm/AVR32: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-07 7:59 ` Hans-Christian Egtvedt 2013-04-07 7:59 ` Hans-Christian Egtvedt 2013-04-06 14:32 ` [PATCH v4, part3 16/41] mm/blackfin: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 17/41] mm/c6x: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 18/41] mm/cris: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-08 9:52 ` Jesper Nilsson 2013-04-06 14:32 ` [PATCH v4, part3 19/41] mm/frv: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 20/41] mm/h8300: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 21/41] mm/hexagon: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 22/41] mm/IA64: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 23/41] mm/m32r: " Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 24/41] mm/m68k: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-08 1:34 ` Greg Ungerer 2013-04-08 1:34 ` Greg Ungerer 2013-04-06 14:32 ` [PATCH v4, part3 25/41] mm/metag: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 26/41] mm/microblaze: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 27/41] mm/MIPS: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 28/41] mm/mn10300: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 29/41] mm/openrisc: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 30/41] mm/PARISC: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 31/41] mm/ppc: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 32/41] mm/s390: " Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 33/41] mm/score: " Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 34/41] mm/SH: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 35/41] mm/SPARC: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu [this message] 2013-04-06 14:32 ` [PATCH v4, part3 36/41] mm/tile: " Jiang Liu 2013-04-12 20:56 ` Chris Metcalf 2013-04-06 14:32 ` [PATCH v4, part3 37/41] mm/um: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 38/41] mm/unicore32: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 39/41] mm/x86: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 40/41] mm/xtensa: " Jiang Liu 2013-04-06 14:32 ` Jiang Liu 2013-04-06 14:32 ` [PATCH v4, part3 41/41] mm: kill global variable num_physpages Jiang Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1365258760-30821-37-git-send-email-jiang.liu@huawei.com \ --to=liuj97@gmail.com \ --cc=James.Bottomley@HansenPartnership.com \ --cc=akpm@linux-foundation.org \ --cc=bhelgaas@google.com \ --cc=cmetcalf@tilera.com \ --cc=davem@davemloft.net \ --cc=dhowells@redhat.com \ --cc=jiang.liu@huawei.com \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@suse.cz \ --cc=minchan@kernel.org \ --cc=msalter@redhat.com \ --cc=rientjes@google.com \ --cc=sergei.shtylyov@cogentembedded.com \ --cc=wency@cn.fujitsu.com \ --cc=wujianguo@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).