From: Waiman Long <Waiman.Long@hp.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
Dave Jones <davej@redhat.com>,
Clark Williams <williams@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: Waiman Long <Waiman.Long@hp.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-arch@vger.kernel.org, "Chandramouleeswaran,
Aswin" <aswin@hp.com>, Davidlohr Bueso <davidlohr.bueso@hp.com>,
"Norton, Scott J" <scott.norton@hp.com>,
Rik van Riel <riel@redhat.com>
Subject: [PATCH v2 optional 3/3] mutex: back out architecture specific check for negative mutex count
Date: Mon, 15 Apr 2013 10:37:59 -0400 [thread overview]
Message-ID: <1366036679-9702-4-git-send-email-Waiman.Long@hp.com> (raw)
In-Reply-To: <1366036679-9702-1-git-send-email-Waiman.Long@hp.com>
If it is confirmed that all the supported architectures can allow a
negative mutex count without incorrect behavior, we can then back
out the architecture specific change and allow the mutex count to
go to any negative number. That should further reduce contention for
non-x86 architecture.
If this is not the case, this patch should be dropped.
Signed-off-by: Waiman Long <Waiman.Long@hp.com>
---
arch/x86/include/asm/mutex.h | 10 ----------
kernel/mutex.c | 9 ++-------
2 files changed, 2 insertions(+), 17 deletions(-)
diff --git a/arch/x86/include/asm/mutex.h b/arch/x86/include/asm/mutex.h
index bc2a0b0..7d3a482 100644
--- a/arch/x86/include/asm/mutex.h
+++ b/arch/x86/include/asm/mutex.h
@@ -3,13 +3,3 @@
#else
# include <asm/mutex_64.h>
#endif
-
-#ifndef __ASM_MUTEX_H
-#define __ASM_MUTEX_H
-/*
- * For the x86 architecture, it allows any negative number (besides -1) in
- * the mutex count to indicate that some other threads are waiting on the
- * mutex.
- */
-#define __ARCH_ALLOW_ANY_NEGATIVE_MUTEX_COUNT 1
-#endif
diff --git a/kernel/mutex.c b/kernel/mutex.c
index e6a90de..5600bdf 100644
--- a/kernel/mutex.c
+++ b/kernel/mutex.c
@@ -38,15 +38,10 @@
#endif
/*
- * A mutex count of -1 indicates that waiters are sleeping waiting for the
- * mutex. Some architectures can allow any negative number, not just -1, for
- * this purpose.
+ * A negative mutex count indicates that waiters are sleeping waiting for the
+ * mutex.
*/
-#ifdef __ARCH_ALLOW_ANY_NEGATIVE_MUTEX_COUNT
#define MUTEX_SHOW_NO_WAITER(mutex) (atomic_read(&(mutex)->count) >= 0)
-#else
-#define MUTEX_SHOW_NO_WAITER(mutex) (atomic_read(&(mutex)->count) != -1)
-#endif
void
__mutex_init(struct mutex *lock, const char *name, struct lock_class_key *key)
--
1.7.1
next prev parent reply other threads:[~2013-04-15 14:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 14:37 [PATCH 0/3 v2] mutex: Improve mutex performance by doing less atomic-ops & better spinning Waiman Long
2013-04-15 14:37 ` [PATCH v2 1/3] mutex: Make more scalable by doing less atomic operations Waiman Long
2013-04-15 14:45 ` Rik van Riel
2013-04-15 14:37 ` [PATCH v2 2/3] mutex: Queue mutex spinners with MCS lock to reduce cacheline contention Waiman Long
2013-04-15 14:37 ` Waiman Long
2013-04-15 16:27 ` Rik van Riel
2013-04-16 4:24 ` Davidlohr Bueso
2013-04-16 12:05 ` Waiman Long
2013-04-16 9:10 ` Ingo Molnar
2013-04-16 14:26 ` Waiman Long
2013-04-17 7:50 ` Ingo Molnar
2013-04-17 7:50 ` Ingo Molnar
2013-04-15 14:37 ` Waiman Long [this message]
2013-04-15 14:37 ` [PATCH v2 optional 3/3] mutex: back out architecture specific check for negative mutex count Waiman Long
2013-04-16 10:05 ` Will Deacon
2013-04-16 12:10 ` Waiman Long
2013-04-16 9:12 ` [PATCH 0/3 v2] mutex: Improve mutex performance by doing less atomic-ops & better spinning Ingo Molnar
2013-04-16 9:12 ` Ingo Molnar
2013-04-16 11:49 ` Waiman Long
2013-04-16 13:09 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366036679-9702-4-git-send-email-Waiman.Long@hp.com \
--to=waiman.long@hp.com \
--cc=aswin@hp.com \
--cc=davej@redhat.com \
--cc=davidlohr.bueso@hp.com \
--cc=dhowells@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).