public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Salter <msalter@redhat.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux-Arch <linux-arch@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: possible problem with generic asm/types.h
Date: Sat, 25 May 2013 12:37:11 -0400	[thread overview]
Message-ID: <1369499831.25297.67.camel@t520.redhat.com> (raw)
In-Reply-To: <CAMuHMdVqFdbv88qDgHAGB7kmBFEwPZWVhr27KqUgiqhrUrga+A@mail.gmail.com>

On Sat, 2013-05-25 at 18:01 +0200, Geert Uytterhoeven wrote:
> On Sat, May 25, 2013 at 5:14 PM, Mark Salter <msalter@redhat.com> wrote:
> >     /*
> >      * int-ll64 is used practically everywhere now,
> 
> This comment is obsolete, it's used everywhere now.
> 
> >      * so use it as a reasonable default.
> >      */
> >     #include <asm-generic/int-ll64.h>
> >
> > Shouldn't this be:
> >
> >     #include <asm/bitsperlong.h>
> >     #if __BITS_PER_LONG == 64
> >     #include <asm-generic/int-l64.h>
> >     #else
> >     #include <asm-generic/int-ll64.h>
> >     #endif
> 
> No. Inside the kernel, all 64-bit platforms use int-ll64.h.

Except for alpha and ia64...

> 
> For backwards compatibility, alpha, ia64, mips, and powerpc (unless
> __SANE_USERSPACE_TYPES__ is defined) still use int-l64.h in userspace.
> 
> So it seems your glibc ues the old convention. Any chance you can still
> switch?

Not glibc, which provides the same stdint.h for all arches. The problem
is the namespace pollution caused by the app defining __s64 to be
glibc's int64_t. I assume that aarch64 kernel headers pull in the kernel
definition of __s64 for some reason where other kernel arches do not. So
it is just by luck that fuse builds on the other arches. I think I'll
take it up with the fuse maintainers...

--Mark

  reply	other threads:[~2013-05-25 16:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-25 15:14 possible problem with generic asm/types.h Mark Salter
2013-05-25 16:01 ` Geert Uytterhoeven
2013-05-25 16:37   ` Mark Salter [this message]
2013-05-25 16:39     ` Geert Uytterhoeven
2013-05-25 16:43       ` Mark Salter
2013-05-26  7:40         ` Geert Uytterhoeven
2013-05-26 10:32 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369499831.25297.67.camel@t520.redhat.com \
    --to=msalter@redhat.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-arch@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox