From: "Xuetao Guan " <gxt@pku.edu.cn>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>,
linux-kernel@vger.kernel.org,
linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH] unicore32: Remove unneeded Kconfig entry NO_IOPORT_MAP
Date: Sun, 28 Sep 2014 09:49:29 +0800 (CST) [thread overview]
Message-ID: <1373895763.5110.1411868969556.JavaMail.root@bj-mail03.pku.edu.cn> (raw)
In-Reply-To: <1411586033.19525.34.camel@x220>
Sorry for late reply.
I checked this config, and it's only used for HAS_IOPORT_MAP in lib/Kconfig
Sure, removing it means no different for .config file.
I think a better way is reserving it or moving it into arch/Kconfig
Cc: linux-arch@vger.kernel.org
Xuetao Guan
----- Paul Bolle <pebolle@tiscali.nl> 写道：
> Architectures only need a Kconfig entry for NO_IOPORT_MAP if it is
> possible that its value will be 'y'. For unicore32 its value will always
> be 'n', making it pointless. Remove it.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Tested by playing with arch/unicore32/configs/unicore32_defconfig. This
> patch made no difference whatsoever to the generated .config file.
> Please note that it has
> CONFIG_HAS_IOPORT_MAP=y
>
> set after invoking "make oldconfig" both before and after this patch.
>
> arch/unicore32/Kconfig | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/unicore32/Kconfig b/arch/unicore32/Kconfig
> index 928237a7b9ca..2322cc87e7cb 100644
> --- a/arch/unicore32/Kconfig
> +++ b/arch/unicore32/Kconfig
> @@ -27,9 +27,6 @@ config UNICORE32
> config GENERIC_CSUM
> def_bool y
>
> -config NO_IOPORT_MAP
> - bool
> -
> config STACKTRACE_SUPPORT
> def_bool y
>
> --
> 1.9.3
>
next parent reply other threads:[~2014-09-28 1:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1411586033.19525.34.camel@x220>
2014-09-28 1:49 ` Xuetao Guan [this message]
2014-09-28 1:49 ` [PATCH] unicore32: Remove unneeded Kconfig entry NO_IOPORT_MAP Xuetao Guan
2014-09-29 9:00 ` Paul Bolle
2014-10-01 14:38 ` 回复： " Xuetao Guan
2014-10-01 14:38 ` Xuetao Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373895763.5110.1411868969556.JavaMail.root@bj-mail03.pku.edu.cn \
--to=gxt@pku.edu.cn \
--cc=gxt@mprc.pku.edu.cn \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).