linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@suse.cz>,
	David Rientjes <rientjes@google.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	azurIt <azurit@pobox.sk>,
	linux-mm@kvack.org, cgroups@vger.kernel.org, x86@kernel.org,
	linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [patch 0/6] improve memcg oom killer robustness
Date: Thu, 25 Jul 2013 18:25:32 -0400	[thread overview]
Message-ID: <1374791138-15665-1-git-send-email-hannes@cmpxchg.org> (raw)

The memcg code can trap tasks in the context of the failing allocation
until an OOM situation is resolved.  They can hold all kinds of locks
(fs, mm) at this point, which makes it prone to deadlocking.

This series converts memcg OOM handling into a two step process that
is started in the charge context, but any waiting is done after the
fault stack is fully unwound.

Patches 1-4 prepare architecture handlers to support the new memcg
requirements, but in doing so they also remove old cruft and unify
out-of-memory behavior across architectures.

Patch 5 disables the memcg OOM handling for syscalls, readahead,
kernel faults, because they can gracefully unwind the stack with
-ENOMEM.  OOM handling is restricted to user triggered faults that
have no other option.

Patch 6 implements the two-part OOM handling such that tasks are never
trapped with the full charge stack in an OOM situation.

 arch/alpha/mm/fault.c      |   7 ++++---
 arch/arc/mm/fault.c        |  11 ++++-------
 arch/arm/mm/fault.c        |  23 +++++++++++++----------
 arch/arm64/mm/fault.c      |  23 +++++++++++++----------
 arch/avr32/mm/fault.c      |   4 +++-
 arch/cris/mm/fault.c       |   6 ++++--
 arch/frv/mm/fault.c        |  10 ++++++----
 arch/hexagon/mm/vm_fault.c |   6 ++++--
 arch/ia64/mm/fault.c       |   6 ++++--
 arch/m32r/mm/fault.c       |  10 ++++++----
 arch/m68k/mm/fault.c       |   2 ++
 arch/metag/mm/fault.c      |   6 ++++--
 arch/microblaze/mm/fault.c |   7 +++++--
 arch/mips/mm/fault.c       |   8 ++++++--
 arch/mn10300/mm/fault.c    |   2 ++
 arch/openrisc/mm/fault.c   |   1 +
 arch/parisc/mm/fault.c     |   7 +++++--
 arch/powerpc/mm/fault.c    |   7 ++++---
 arch/s390/mm/fault.c       |   2 ++
 arch/score/mm/fault.c      |  13 ++++++-------
 arch/sh/mm/fault.c         |   9 ++++++---
 arch/sparc/mm/fault_32.c   |  12 +++++++++---
 arch/sparc/mm/fault_64.c   |   8 +++++---
 arch/tile/mm/fault.c       |  13 +++++--------
 arch/um/kernel/trap.c      |  22 ++++++++++++++--------
 arch/unicore32/mm/fault.c  |  22 +++++++++++++---------
 arch/x86/mm/fault.c        |  43 ++++++++++++++++++++++---------------------
 arch/xtensa/mm/fault.c     |   2 ++
 include/linux/memcontrol.h |  40 ++++++++++++++++++++++++++++++++++++++++
 include/linux/mm.h         |   1 +
 include/linux/sched.h      |   6 ++++++
 mm/filemap.c               |  11 ++++++++++-
 mm/memcontrol.c            | 156 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------
 mm/memory.c                |  43 +++++++++++++++++++++++++++++++++----------
 mm/oom_kill.c              |   7 +++++--
 35 files changed, 373 insertions(+), 183 deletions(-)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@suse.cz>,
	David Rientjes <rientjes@google.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	azurIt <azurit@pobox.sk>,
	linux-mm@kvack.org, cgroups@vger.kernel.org, x86@kernel.org,
	linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [patch 0/6] improve memcg oom killer robustness
Date: Thu, 25 Jul 2013 18:25:32 -0400	[thread overview]
Message-ID: <1374791138-15665-1-git-send-email-hannes@cmpxchg.org> (raw)
Message-ID: <20130725222532.vh3RAs-6NhDYVqkgIU4PX7neLf18aYdG7DP4oHB4TWc@z> (raw)

The memcg code can trap tasks in the context of the failing allocation
until an OOM situation is resolved.  They can hold all kinds of locks
(fs, mm) at this point, which makes it prone to deadlocking.

This series converts memcg OOM handling into a two step process that
is started in the charge context, but any waiting is done after the
fault stack is fully unwound.

Patches 1-4 prepare architecture handlers to support the new memcg
requirements, but in doing so they also remove old cruft and unify
out-of-memory behavior across architectures.

Patch 5 disables the memcg OOM handling for syscalls, readahead,
kernel faults, because they can gracefully unwind the stack with
-ENOMEM.  OOM handling is restricted to user triggered faults that
have no other option.

Patch 6 implements the two-part OOM handling such that tasks are never
trapped with the full charge stack in an OOM situation.

 arch/alpha/mm/fault.c      |   7 ++++---
 arch/arc/mm/fault.c        |  11 ++++-------
 arch/arm/mm/fault.c        |  23 +++++++++++++----------
 arch/arm64/mm/fault.c      |  23 +++++++++++++----------
 arch/avr32/mm/fault.c      |   4 +++-
 arch/cris/mm/fault.c       |   6 ++++--
 arch/frv/mm/fault.c        |  10 ++++++----
 arch/hexagon/mm/vm_fault.c |   6 ++++--
 arch/ia64/mm/fault.c       |   6 ++++--
 arch/m32r/mm/fault.c       |  10 ++++++----
 arch/m68k/mm/fault.c       |   2 ++
 arch/metag/mm/fault.c      |   6 ++++--
 arch/microblaze/mm/fault.c |   7 +++++--
 arch/mips/mm/fault.c       |   8 ++++++--
 arch/mn10300/mm/fault.c    |   2 ++
 arch/openrisc/mm/fault.c   |   1 +
 arch/parisc/mm/fault.c     |   7 +++++--
 arch/powerpc/mm/fault.c    |   7 ++++---
 arch/s390/mm/fault.c       |   2 ++
 arch/score/mm/fault.c      |  13 ++++++-------
 arch/sh/mm/fault.c         |   9 ++++++---
 arch/sparc/mm/fault_32.c   |  12 +++++++++---
 arch/sparc/mm/fault_64.c   |   8 +++++---
 arch/tile/mm/fault.c       |  13 +++++--------
 arch/um/kernel/trap.c      |  22 ++++++++++++++--------
 arch/unicore32/mm/fault.c  |  22 +++++++++++++---------
 arch/x86/mm/fault.c        |  43 ++++++++++++++++++++++---------------------
 arch/xtensa/mm/fault.c     |   2 ++
 include/linux/memcontrol.h |  40 ++++++++++++++++++++++++++++++++++++++++
 include/linux/mm.h         |   1 +
 include/linux/sched.h      |   6 ++++++
 mm/filemap.c               |  11 ++++++++++-
 mm/memcontrol.c            | 156 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------
 mm/memory.c                |  43 +++++++++++++++++++++++++++++++++----------
 mm/oom_kill.c              |   7 +++++--
 35 files changed, 373 insertions(+), 183 deletions(-)


             reply	other threads:[~2013-07-25 22:25 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 22:25 Johannes Weiner [this message]
2013-07-25 22:25 ` [patch 0/6] improve memcg oom killer robustness Johannes Weiner
2013-07-25 22:25 ` [patch 1/6] arch: mm: remove obsolete init OOM protection Johannes Weiner
2013-07-25 22:25   ` Johannes Weiner
2013-07-26 13:00   ` Michal Hocko
2013-07-26 13:00     ` Michal Hocko
2013-07-29 18:55   ` KOSAKI Motohiro
2013-07-29 18:55     ` KOSAKI Motohiro
2013-07-25 22:25 ` [patch 2/6] arch: mm: do not invoke OOM killer on kernel fault OOM Johannes Weiner
2013-07-25 22:25   ` Johannes Weiner
2013-07-26 13:07   ` Michal Hocko
2013-07-26 13:07     ` Michal Hocko
     [not found]   ` <1374791138-15665-3-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2013-07-29 18:58     ` KOSAKI Motohiro
2013-07-29 18:58       ` KOSAKI Motohiro
2013-08-01 21:59       ` Johannes Weiner
2013-08-01 21:59         ` Johannes Weiner
2013-07-25 22:25 ` [patch 3/6] arch: mm: pass userspace fault flag to generic fault handler Johannes Weiner
2013-07-25 22:25   ` Johannes Weiner
     [not found]   ` <1374791138-15665-4-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2013-07-26 13:19     ` Michal Hocko
2013-07-26 13:19       ` Michal Hocko
2013-07-26 18:45       ` Johannes Weiner
2013-07-26 18:45         ` Johannes Weiner
2013-07-25 22:25 ` [patch 4/6] x86: finish user fault error path with fatal signal Johannes Weiner
2013-07-25 22:25   ` Johannes Weiner
2013-07-26 13:52   ` Michal Hocko
2013-07-26 13:52     ` Michal Hocko
2013-07-26 18:46     ` Johannes Weiner
2013-07-26 18:46       ` Johannes Weiner
2013-07-29 12:45       ` Michal Hocko
2013-07-29 12:45         ` Michal Hocko
2013-07-29 19:01   ` KOSAKI Motohiro
2013-07-29 19:01     ` KOSAKI Motohiro
2013-07-25 22:25 ` [patch 5/6] mm: memcg: enable memcg OOM killer only for user faults Johannes Weiner
2013-07-25 22:25   ` Johannes Weiner
     [not found]   ` <1374791138-15665-6-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2013-07-26 14:16     ` Michal Hocko
2013-07-26 14:16       ` Michal Hocko
2013-07-26 18:54       ` Johannes Weiner
2013-07-26 18:54         ` Johannes Weiner
2013-07-29 19:18   ` KOSAKI Motohiro
2013-07-29 19:18     ` KOSAKI Motohiro
     [not found]     ` <51F6C00C.5050702-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-07-29 19:44       ` Johannes Weiner
2013-07-29 19:44         ` Johannes Weiner
2013-07-29 19:47         ` KOSAKI Motohiro
2013-07-25 22:25 ` [patch 6/6] mm: memcg: do not trap chargers with full callstack on OOM Johannes Weiner
2013-07-25 22:25   ` Johannes Weiner
     [not found]   ` <1374791138-15665-7-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2013-07-26 14:43     ` Michal Hocko
2013-07-26 14:43       ` Michal Hocko
2013-07-26 21:28       ` Johannes Weiner
2013-07-26 21:28         ` Johannes Weiner
2013-07-29 14:12         ` Michal Hocko
2013-07-29 14:12           ` Michal Hocko
     [not found]           ` <20130729141250.GF4678-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-07-29 14:55             ` Johannes Weiner
2013-07-29 14:55               ` Johannes Weiner
     [not found]               ` <20130729145529.GW715-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2013-07-29 15:52                 ` Michal Hocko
2013-07-29 15:52                   ` Michal Hocko
     [not found]         ` <20130726212808.GD17975-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2013-07-30 14:09           ` Michal Hocko
2013-07-30 14:09             ` Michal Hocko
     [not found]             ` <20130730140913.GC15847-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-07-30 14:32               ` Johannes Weiner
2013-07-30 14:32                 ` Johannes Weiner
     [not found]                 ` <20130730143228.GD715-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2013-07-30 14:56                   ` Michal Hocko
2013-07-30 14:56                     ` Michal Hocko
2013-07-25 22:31 ` [patch 3.2] memcg OOM robustness (x86 only) Johannes Weiner
2013-07-25 22:31   ` Johannes Weiner
2013-08-03  8:38   ` azurIt
2013-08-03  8:38     ` azurIt
2013-08-03 16:30     ` Johannes Weiner
2013-08-03 16:30       ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374791138-15665-1-git-send-email-hannes@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=akpm@linux-foundation.org \
    --cc=azurit@pobox.sk \
    --cc=cgroups@vger.kernel.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=rientjes@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).